Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#881 Remove mixed protocol when behind SSL

None
closed
None
1
2014-01-02
2014-01-02
Ben
No

When awstats is behind https, the Google Chart API results in mixed protocol (http/https) which most browsers now block by default. All Google URL's should be https without care of awstats protocol.

File: wwwroot/cgi-bin/plugins/graphgooglechartapi.pm

Line 32:
- my $ChartProtocol = "http://";
+ my $ChartProtocol = "https://";

Line 172:
- print "<script type="text/javascript" src="http://www.google.com/jsapi"></script>\n";
+ print "<script type="text/javascript" src="https://www.google.com/jsapi"></script>\n";

Discussion

  • Ben
    Ben
    2014-01-02

    Ugh!! Stupid forms:

    File: wwwroot/cgi-bin/plugins/graphgooglechartapi.pm

    Line 32:
    - my $ChartProtocol = "http://";
    + my $ChartProtocol = "https://";

    Line 172:
    - print "<script type='text/javascript' src='http://www.google.com/jsapi'></script>\n";
    + print "<script type='text/javascript' src='https://www.google.com/jsapi'></script>\n";

     
  • Patch added into 7.3 beta

     
    • status: open --> closed
    • assigned_to: Laurent Destailleur (Eldy)
    • Group: -->