Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#208 TemporalSoften

v2.6x
closed-invalid
Internals (76)
5
2010-08-01
2010-07-30
Wilbert Dijkhof
No

Discussion

  • Ian Brabham
    Ian Brabham
    2010-07-30

    • assigned_to: nobody --> wilbertd
    • status: open --> pending
     
  • Ian Brabham
    Ian Brabham
    2010-07-30

    """There's still oddities in the original source for 2.5.8 (Temporal::Soften accumulate_line_mode2 is commented as having funny results regardless of variable choice for the inline asm) and ... """

    void TemporalSoften::isse_accumulate_line(const BYTE* c_plane, const BYTE** planeP, int planes, int rowsize, __int64* t) {
    ...
    const __int64 t2 = *t;
    ...
    movq mm3,[t2] // Using t also gives funny results

    So the code has a weird comment, where is the bug report. ???????

     
  • I'm not aware of any bug related to it. The comment sounded serious, and is probably there since ages.

    If you can't see anything obviously wrong with the code or the comments are meaningless to you, you can close the item.

    I'm not able to judge this myself.

     
    • status: pending --> open
     
  • Ian Brabham
    Ian Brabham
    2010-08-01

    • labels: --> Internals
    • milestone: --> v2.6x
    • status: open --> closed-invalid
     
  • Ian Brabham
    Ian Brabham
    2010-08-01

    Thinking about the code and the comment a little more, I believe it is the result of frustration due to either a mind lock about t being type __int64* or not being able to directly access the contests *t without extra instructions.

    To access the contents of *t the following code would have been required :-
    mov eax,[t] // Get address of t
    movq mm3, qword ptr[eax] // Get contents of t

    Using movq mm3,[t] would result in loading the address of t plus the next dword on the stack into mm3.