#57 nothing should change before prebackup

closed-invalid
nobody
None
5
2011-11-21
2011-11-21
Manuel Mendez
No

Only config checks / variable setups should take place before prebackup.
My prebackup script mounts a network share at the base backup directory, post umount's it. Currently actions are intermingled with setups and should be avoided. Seems to me that creating backup dirs is part of the backup process and as such should happen after prebackup.

Discussion

  • PittaGurneyi
    PittaGurneyi
    2011-11-21

    • status: open --> closed-invalid
     
  • PittaGurneyi
    PittaGurneyi
    2011-11-21

    Well, why don't you just create a wrapper script or just add lines before and after the automysqlbackup command to your cron script? This is surely not something related to the pre and postbackup scripts. They are in place, so that you are able to take action just before the real backup process begins and just afterwards while having full access to all configuration and runtime variables.

     
  • PittaGurneyi
    PittaGurneyi
    2011-11-21

    If you need configuration variables, copy out the default configuration function from automysqlbackup, run it in your script and source your config file afterwards.

     
  • Manuel Mendez
    Manuel Mendez
    2011-11-21

    I was going to go the wrapper script route until I saw those vars in the config file, and thought there was no need. That is until I saw daily/weekly/monthly @ my mount point. Guess its a mis-read of the config docs.