#14 Weekly Rotation broken

closed
nobody
None
7
2010-07-05
2006-10-11
John Sivak
No

I just noticed that the Weekly backups weren't being
deleted after 5 weeks.

The reason is on line 539 of the script:
eval rm -fv "$BACKUPDIR/weekly/$DB_week.$REMW.*"

The line needs to be:
eval rm -fv "$BACKUPDIR/weekly/$DB/${DB}_week.$REMW.*"

Notice the extra $DB directory and the {}'s around the
$DB reference in the file name.

Not sure how this bug hasn't been hit yet..
I'm using separate backup files for each database.

Discussion

  • John Sivak
    John Sivak
    2006-10-11

    • priority: 5 --> 7
     
  • Thomas Kofler
    Thomas Kofler
    2006-10-18

    Logged In: YES
    user_id=142624

    Confirm that bug

     
  • Logged In: NO

    Just got hit with this one myself as I noticed my backup tarballs were getting larger every day. Surprised it wasn't mentioned earlier as a bug...

     
  • tothborn
    tothborn
    2007-04-11

    Logged In: YES
    user_id=1245019
    Originator: NO

    You are right. Thank you for the submit.

     
  • Logged In: NO

    Confirmed. Thank you.

     
  • Dave Lehman
    Dave Lehman
    2008-08-01

    Logged In: YES
    user_id=1910395
    Originator: NO

    Confirmed. Patch appears correct.

     
  • budacsik
    budacsik
    2009-04-16

    How is it necessary to use this patch?

     
  • Changed routine for rotation.

     
    • status: open --> closed