#18 SoundTouch code doesn't need GCC as it claims

closed-wont-fix
nobody
None
5
2008-03-18
2008-03-09
Brian Cameron
No

The SoundTouch code fails to build if you aren't using the GCC compiler, due to the code in cpu_detect_x86_gcc.cpp.

However, this code is only used if you are building with optimizations.

This patch fixes FIRFilter.cpp and TDStretch so that they only bother calling detectCPUextensions if optimizations are actually being used. It also adds a "#include STTypes.h" to the top of the cpu_detect_x86_gcc.cpp file and basically ifdef's out the whole file if ALLOW_OPTIMIZATIONS is not set. This allows you to build without optimizations, since it is not necessary to check for GCC support in this case.

Discussion

  • Brian Cameron
    Brian Cameron
    2008-03-09

    Logged In: YES
    user_id=689771
    Originator: YES

    Note this patch also removes ^M characters from the cpu_detect_x86_gcc.cpp file.

     
  • Brian Cameron
    Brian Cameron
    2008-03-18

    • status: open --> closed-wont-fix
     
  • Brian Cameron
    Brian Cameron
    2008-03-18

    Logged In: YES
    user_id=689771
    Originator: YES

    Now that audacity doesn't include SoundTouch directly anymore, should we just close this bug? I can take up this issue with the SoundTouch maintainer directly. So, closing. Sound good?