Re: [Audacity-quality] Not saving projects >= 2^31 samples
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve t. F. <ste...@gm...> - 2013-10-31 02:35:49
|
On 31 October 2013 01:42, Vaughan Johnson <va...@au...> wrote: > > > On 10/30/2013 4:16 PM, Steve the Fiddle wrote: >> On 30 October 2013 22:26, Richard Ash <ri...@au...> wrote: >>> On Tue, 29 Oct 2013 01:42:47 +0000 >>> Steve the Fiddle <ste...@gm...> wrote: >>> >>>> Here's a revised (simplified) patch for preventing saving projects >>>> with tracks >= 2^31 samples with an error message based on Gale's >>>> suggestion, >>> >>> Before you get too deep into this (if I'm not too late), why not just >>> fix loading (I think it's loading not saving which is broken) of >>> waveclips which are more than 2^31 samples long? > > Amen. Big picture fix! > > >>> >>> Given that you can tell me it's the length of a waveclip (not any other >>> project element) which is the problem, it's pretty easy to see what is >>> going wrong (use of a Long to store the value when it should be a >>> sampleCount). >>> >>> I'm working on a patch which should cure the root problem (loading >>> projects with waveclips which are more than 2^31 long) and should have >>> something some time tomorrow - which is likely to be no longer than the >>> current code! > > Thank you! I echo Leland's "yippee"! > > >>> >>> Richard >> >> Not too late Richard - right on cue :-) > > Given the thousands of words and nearly 20 messages discussing the exact > likely-baffling-to-most-users wording of the error alert, I'd say it is > too late, "too deep" has already been reached. (And I'm NOT blaming > Richard.) Nah, 20 e-mails is insignificant compared with the countless reams of forum posts helping users stitch together irreplaceable projects, lost due to this bug over the last couple of years. I don't know how to fix the root problem, so I was looking to mitigate, but a fix is much better and very welcome. Steve > > >> Much better to fix the root problem. > > Exactly. > > - V > |