Re: [Audacity-devel] [audacity] r12482 committed - Cleanup: Fixed lots of trivial MSVC warnings.
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Martyn S. <mar...@gm...> - 2013-08-27 21:59:38
|
Thanks Paul and Vaughan for the explanation - it just shows the care that needs to be taken in cross-platform development! Martyn On 27/08/2013 01:38, Paul Livesey wrote: > The two changes that needed reverting changed the method parameter. > > -void FileIO::SetCatalogInfo(wxUint32 WXUNUSED(type)) > +void FileIO::SetCatalogInfo(wxUint32 type) > > and > > -void KeyConfigPrefs::OnKeyDown(wxListEvent & WXUNUSED(event)) > +void KeyConfigPrefs::OnKeyDown(wxListEvent & e) > > I presume this was to get rid of some annoying unused parameter warnings. > However the methods contained some platform specific sections and the > Mac and Linux versions required the parameters that had been flagged > as WXUNUSED. In the second method e had also been renamed to event. > > Paul. > > On 27 Aug 2013, at 00:24, Martyn Shaw wrote: > >> Did you figure out why that broke it? I was tempted to fix all those >> warnings, but they are only warnings. >> >> Martyn >> >> On 26/08/2013 23:38, James Crook wrote: >>> For the record, Paul figured it out. Gave exact instructions for how to >>> fix it. >>> >>> It was my 'bad' in that it was changes I made that were fine for Windows >>> but not fine for Linux/Mac. >>> >>> --James. >>> >>> >>> >>> >>> On 26/08/2013 23:12, Vaughan Johnson wrote: >>>> Thanks. James figured it out and fixed it. >>>> >>>> - V >>>> >>>> >>>> On 8/26/2013 3:05 PM, Benjamin Drung wrote: >>>>> The error message _was_ on Linux: >>>>> [...] >>>>> >>>>> Am Montag, den 26.08.2013, 15:00 -0700 schrieb Vaughan Johnson: >>>>>> Thanks, Paul. I think it would be more helpful to know what about the >>>>>> build is broken with current HEAD. >>>>>> >>>>>> - Vaughan >>>>>> >>>>>> >>>>>> On 8/26/2013 9:26 AM, Paul Livesey wrote: >>>>>>> These changes in this revision break the build on a Mac (and possibly Linux but I haven't checked that). >>>>>>> >>>>>>> The following diff (backing out a couple of the changes) fixes things but reintroduce whatever the original problem was so I haven't committed it. >>>>>>> >>>>>>> Paul. >>>>>>> [...] >>>> >>>> ------------------------------------------------------------------------------ >>>> Introducing Performance Central, a new site from SourceForge and >>>> AppDynamics. Performance Central is your source for news, insights, >>>> analysis and resources for efficient Application Performance Management. >>>> Visit us today! >>>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk >>>> _______________________________________________ >>>> audacity-devel mailing list >>>> aud...@li... >>>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>>> >>>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Introducing Performance Central, a new site from SourceForge and >>> AppDynamics. Performance Central is your source for news, insights, >>> analysis and resources for efficient Application Performance Management. >>> Visit us today! >>> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> audacity-devel mailing list >>> aud...@li... >>> https://lists.sourceforge.net/lists/listinfo/audacity-devel >>> >> >> ------------------------------------------------------------------------------ >> Introducing Performance Central, a new site from SourceForge and >> AppDynamics. Performance Central is your source for news, insights, >> analysis and resources for efficient Application Performance Management. >> Visit us today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk >> _______________________________________________ >> audacity-devel mailing list >> aud...@li... >> https://lists.sourceforge.net/lists/listinfo/audacity-devel > > > ------------------------------------------------------------------------------ > Introducing Performance Central, a new site from SourceForge and > AppDynamics. Performance Central is your source for news, insights, > analysis and resources for efficient Application Performance Management. > Visit us today! > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |