Re: [Audacity-devel] Patch for the Bug 393

[Gale A. <ga...@au...>]

| From Chandranshu Garg <cg...@cg...> 
| Thu, 23 Aug 2012 12:02:54 +0530
| Subject: [Audacity-devel] Patch for the Bug 393
> Thanks Gale.
> 
> Please find the patch bug393_v3, bug393_v4 attached with this mail
> 
> in the earlier patch bug393_v2, I forgot the fact the SetFocusedTrack
> method called in EnsureVisible method is also doing Refresh everytime.
> 
> One way out could be to remove SetFocusedTrack call from the method
> EnsureVisible. But there could be a chance that it affects other methods
> calling EnsureVisible and benefiting from SetFocusedTrack call. Though I
> was not able to find any problematic case, because in almost all the places
> I could see, EnsureVisible call follows the SetFocusedTrack call. So, as
> far as I think, it should not create any problem.
> patch v4 does this
> 
> Also, going by what Vaughan said..
> 
> >>Sounds like it works well on our largest usership, on Windows, but in
> >>that minority use case of Linux, that one call to
> >>TrackPanel::EnsureVisible() is doing too much refresh.
> >>
> >>My guess is that it needs to check at the top whether the t argument is
> >>already visible before proceeding. If so, just return. That will
> >>probably work for all platforms, but there's no current Track method
> >>that will do that, afaik.
> 
> In the patch v3, I made a separate method IsVisible, which checks if a
> Track is already visible or not. It is better because it makes no changes
> in the already existing and used method EnsureVisible.
> 
> Please see if above approaches are correct or not.
> Also, check and tell if either of the patch solves the problem.
> Sorry in case I am not able to articulate my explanation clearly. 

I made clean builds trying first v3 patch then v4 on Ubuntu 12.04 
32-bit, but any stereo track still shakes up and down as soon
as I drag it left or right (or up and down) with Time Shift Tool.




Gale 



> 
> Chandranshu Garg
> 
> On Thu, Aug 23, 2012 at 1:29 AM, Gale Andrews <ga...@au...> wrote:
> 
> >
> > | From Chandranshu Garg <cg...@cg...>
> > | Wed, 22 Aug 2012 09:18:31 +0530
> > | Subject: [Audacity-devel] Patch for the Bug 393
> > > I fear asking this...
> > > but is there any good way to debug this issue other than sending you
> > > patches each time repeatedly.
> >
> > I don't mind testing patches, if you have some other idea. You
> > can always send patches to me offlist in the first instance.
> >
> > The problem seems to be only with stereo tracks. Does that tell
> > you anything?
> >
> > Does anyone else see this shaking issue on Linux if they try your
> > v2 patch
> >
> > http://audacity.238276.n2.nabble.com/Patch-for-the-Bug-393-td7555990.html#a7556070?
> >
> >
> > Thanks
> >
> >
> >
> > Gale