Re: [Audacity-devel] Audacity not building on Ubuntu 12.04 (released 1st of March)
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Michael C. <mc...@gm...> - 2012-03-13 19:09:40
|
On Tue, Mar 13, 2012 at 8:08 AM, Vaughan Johnson <va...@au...> wrote: > > > On 3/13/2012 6:30 AM, Benjamin Drung wrote: >> Am Samstag, den 10.03.2012, 11:32 +1100 schrieb David Timms: >>> On 09/03/12 03:46, Benjamin Drung wrote: >>>> This build failure only affects Ubuntu 12.04, but not Ubuntu 11.10 or >>>> earlier. The build failure is not Ubuntu specific. It will affect all >>>> Linux distributions that will ship this glib version or newer. Probably >>>> all upcoming Linux distributions will be affected (like Fedora, etc). >>> It would be good to know which glib versions were OK, since I built RC8 >>> from minsrc, using external system libraries, successfully a few days >>> ago, on all current Fedora release + devel package sets. >>> F-16: >>> glib2-2.30.2-1.fc16 >>> >>> F-17: (release expected april/may) >>> glib2-2.31.18-1.fc17 >>> >>> F-18: (rawhide oct/november): this will get updated to at least >>> 2.31.18, but still plenty of time. >>> glib2-2.31.16-2.fc18 >>> >>> However, I have been carrying a small patch for what seems like this >>> issue since 2011-october (it just removes that include reference, where >>> as Ben's version replaces it with something else: >>> >>> --- src/AudacityApp.cpp.orig 2011-11-04 10:44:41.016958277 +1100 >>> +++ src/AudacityApp.cpp 2011-11-01 17:15:19.000000000 +1100 >>> @@ -406,7 +406,7 @@ >>> * Happily we can avoid the hack, as we only need some of the headers, not >>> * the full GTK headers >>> */ >>> -#include <glib/gtypes.h> >>> +//#include <glib/gtypes.h> >>> #include <glib-object.h> >>> >>> typedef struct _GnomeProgram GnomeProgram; >>> >>> So, yes, some change is needed here, but given I am able to build >>> without the include at all (I made this change november, released it >>> december, and is the active public build that Fedora users have been >>> using), perhaps Ben can try without as well ? >> >> Glib 2.31.20 triggers the build failure on Ubuntu. Audacity builds on >> all tested Ubuntu versions (from 10.10 to 12.04 in the daily PPA [1]) if >> the include is removed. > > And it has been, right? That was in RC9. Yes, that was removed, so I think Benjamin is the builds no longer fail. > >> >> The comment above the include should be removed, too. > > Okay, but *after* we release 2.0. No need to make new tarballs for that. As Vaughan says this doesn't matter for 2.0. I will note that I don't feel strongly but the comment seems to still make sense since we still do a glib-object.h include so I would be inclined to leave it post 2.0. Perhaps it may be expanded to note the newer wxGTK conflict. Michael |