Re: [Audacity-devel] Audacity not building on Ubuntu 12.04 (released 1st of March)

[Benjamin D. <bd...@ub...>]

(1) As written in the other thread, this change will be compatible to
all glib versions (because that's the way glib should be included). It
will lead to a build failure if the user uses a wxGTK version that is
affected by [1], which was fixed three years ago, but this is a bug in
_wxGTK_!

(2) This change only affects building Audacity with wxGTK [more
precisely: #if defined(__WXGTK__) && defined(HAVE_GTK)]. Therefore only
the source tarballs are affected, but not the Windows or Mac builds.

I did a test build on Ubuntu 11.04 and it still builds with the patch
there.

[1] http://trac.wxwidgets.org/ticket/10883

Am Donnerstag, den 08.03.2012, 13:47 -0800 schrieb Vaughan Johnson:
> Thanks for the discussion on this. I had the same concern as Alan, that
> it not break any current distros.
> 
> Otherwise, it seems Michael and Alan do not think this is a P1. I'm not
> qualified to say, but I'd like to see answers from Benjamin about (1)
> compatibility and (2) Michael's assertion about wxGTK, and that making
> it okay in rc8.
> 
> It's certainly a modest change in terms of amount of code, but I have no
> idea the repercussions. The comment above is in both versions, so I
> don't see how it's a justification for the change.
> 
> And as James pointed out, it's late in the release cycle, and I'd hate
> to have to do another rc.
> 
> Thanks,
> Vaughan
> 
> 
> On 3/8/2012 9:14 AM, Alan Horstmann wrote:
> > On Thursday 08 March 2012 16:33, James Crook wrote:
> >> In http://bugzilla.audacityteam.org/show_bug.cgi?id=484
> >>
> >> You wrote: Audacity 2.0.0rc8 fails to build on Ubuntu 12.04 which ships
> >> glib 2.31.20
> >>
> >> Would you say this is a show stopper, a P1 bug?  It sounds to me like it
> >> makes Audacity unusable on current Ubuntu.  If it is a P1, it is a major
> >> hassle only finding out about it at the end of the release cycle.
> > 
> > Excuse my commenting if it seems inappropriate.
> > 
> > As a user/devel almost exclusively Linux based, I don't see this as a big 
> > problem.  Libraries are always changing and breaking builds.  It is only the 
> > build from source that is affected, is it not?  Ubuntu will patch locally and 
> > build, and Ubuntu users (I'm not one) will download from the repository 
> > without an issue.  That is one of the roles of distro providers in the Linux 
> > world.
> > 
> > Anyone else building from source may/may-not have a problem, but the Audacity 
> > bug report should be easy to find with search tool, and the fix is easy.
> > 
> > (On the other hand, the fix looks pretty safe, though it would be best to 
> > check backwards compatibility with older glib versions, in case there's an 
> > issue.)
> > 
> > Just my '2p'.
> > 
> > Regards and best wishes for 2.0.0,
> > 
> > Alan
> > 

-- 
Benjamin Drung
Debian & Ubuntu Developer