Re: [Audacity-devel] r10469 - audacity - Audacity: Free, Cross-Platform Audio Editor and Recorder - Google Project Hosting

[Vaughan J. <vau...@sb...>]

Hey, Clayton, what about the other changes in that commit, especially
the one in ProgressDialog.cpp?

- V


On 2/6/2012 3:18 PM, Vaughan Johnson wrote:
> I've been running Vigilant Sentry on the current code. It flagged a
> possible problem at CommandManager.cpp line 391 (because of a second
> declaration of the "label" var).
> 
> This was changed by Clayton with
> http://code.google.com/p/audacity/source/detail?r=10469#. The comment
> there says it's about changing the layout of the TimeScale effect
> dialog, but this is a pretty significant change in
> CommandManager::InsertItem(), which is called by lots of other code.
> 
> So Clayton, or anybody, why change the assignment to the "label" var to
> not use wxMenuItem::GetLabelText? Removing that means that accelerator
> characters and mnemonics do *not* get stripped from the result.
> 
> QA folks, does that sound like any bugs you know?
> 
> I'm inclined to revert it if we don't get a good answer why it was done.
> 

On 2/7/2012 2:33 PM, Vaughan Johnson wrote:
> On 2/6/2012 4:34 PM, Clayton Otey wrote:
>> This should be reverted.  I believe I had a compilation issue with
>> wxWidgets at the time, which I worked around with this change to
>> CommandManager.cpp, and inadvertently committed the change.
>>
>
> Thanks, Clayton! I'll do the change.
>
> - V
>
>