Re: [Audacity-devel] patch to repair typos in comments
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Gale A. <ga...@au...> - 2009-10-18 23:01:14
|
| From Vaughan Johnson <va...@au...> | Sun, 18 Oct 2009 13:36:08 -0700 | Subject: [Audacity-devel] patch to repair typos in comments > Gale Andrews wrote: > > | From "Ed Musgrove" <edg...@wa...> > .... > >> typo? > >> in file Prefs.cpp line 15: > >> Audacity uses wxWindows' wxConfig class > >> should be: > >> Audacity uses wxWidgets' wxConfig class > > > > I have not committed that because I don't believe your change is > > correct - it should be changed to "wxFileConfig" (though I've > > noticed "wxWindows" before and been a bit confused). > > It was originally called wxWindows, and then renamed when Microsoft > threatened legal action. Thanks, that clarifies it. > IMO, discussing these trivialities at length is bordering on misuse of > attention bandwidth. Don't agree with you there, either that out-of-date/incorrect comments in the code are necessarily "trivial" to someone learning that code, or that the responses made here were of excessive length. Obviously someone who knew the answer for sure/noticed the typo and who had write access would just commit the change without writing here. A new developer does not have those rights. Gale |