Re: [Audacity-devel] Export multiple colon wrongly accepted as legal character
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Richard A. <ri...@au...> - 2008-01-19 16:26:23
|
On Sat, 2008-01-19 at 00:14 +0000, Martyn Shaw wrote: > > ... Won't it mean > > though that Mac/Linux users are going to get half a dozen or so > > characters replaced where they don't need to be replaced e.g. "?" on > > Mac? Yes it means the file names are portable, but I would not > > expect it to be a "popular" move. No doubt the current fix is better > > than what we have now for Windows users. > > Yes, it was just a trial. We will have to do some differences for > each OS - just a different set of illegal chars at compile time. There is already supposed to be a function to get this list in wx: http://www.wxwidgets.org/manuals/2.6/wx_wxfilename.html#wxfilenamegetforbiddenchars There isn't one to do the checking, but it's half way there. > Here's another idea: > 1 Proceed until an illegal name is found. > 2 Change the name to a legal one. > 3 Pop up a dialog box with the suggested legal name so it can be > edited, only allowing legal chars. > 4 Cancel stops the rest of the export. I don't like this, because it means I can go away leaving it doing file 1 of 12, and come back when all 12 should have been done, only to find that it is stuck on file 4 asking me what name to change it to. I would be more in favour of doing a name sanitation pass at the start before any files are exported (which would also include a check for file write-ability), so that it should always do the run without stopping to ask for information. Richard |