Re: [Audacity-devel] ImportOGG.cpp
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Joshua H. <jo...@ha...> - 2004-03-01 07:13:44
|
On Feb 29, 2004, at 6:48 PM, Matt Brubeck wrote: > Every Ogg file (or nearly every Ogg file) was truncated by about 1-3 > seconds before the fix was applied. This was definitely true of the 1.0 code, where the fix was initially applied, but is it also true of the 1.2 code? I also think that the addition of WaveTrack::Flush() might have changed things; before that method was added, WaveTrack::Append() would flush the data automatically which made it prudent for the importers to give data to the WaveTrack 2MB at a time. Since that's no longer an issue, the importing loop now sends data to the WaveTrack every iteration of the loop instead of batching it into 2MB chunks. That means that there isn't residue left over from the 2 MB batches. I'm growing increasingly confident that these lines are unnecessary. What I (or someone else) should really do is test it compiled both ways and see which produces the expected results. Josh |