Thread: [Audacity-devel] Solo and Mute not working on stereo track at top of window
A free multi-track audio editor and recorder
Brought to you by:
aosiniao
From: Steve <ste...@gm...> - 2009-07-31 14:51:23
|
This is rather difficult to describe without illustrations so I have posted a description here: http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 Steve |
From: David B. <drb...@go...> - 2009-07-31 17:06:42
|
On Fri, Jul 31, 2009 at 3:51 PM, Steve<ste...@gm...> wrote: > This is rather difficult to describe without illustrations so I have > posted a description here: > http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 > > Steve confirmed here on Vista. The problem can be reproduced using a slightly simpler procedure: 1. open a stero track. 2. Adjust the height of the Audacity window so that only the top channel of the track is visible. 3. scroll down to see the bottom channel. 4. The reappearing mute and solo controls don't work properly, as described by Steve. David. |
From: Al D. <bus...@gm...> - 2009-07-31 17:22:48
|
On Friday 31 July 2009 11:06:23 David Bailes wrote: > On Fri, Jul 31, 2009 at 3:51 PM, Steve<ste...@gm...> wrote: > > This is rather difficult to describe without illustrations so I have > > posted a description here: > > http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 > > > > Steve > > confirmed here on Vista. > The problem can be reproduced using a slightly simpler procedure: > 1. open a stero track. > 2. Adjust the height of the Audacity window so that only the top > channel of the track is visible. > 3. scroll down to see the bottom channel. > 4. The reappearing mute and solo controls don't work properly, as > described by Steve. > The re-appearing controls are labeled like they should apply to the right channel only; the gain and pan sliders work, and apply to both channels together (having them apply to just the right channel, IMO, would be much worse, since the controls are not reliably present... also pan is pretty much meaningless if applied to only one channel). |
From: Al D. <bus...@gm...> - 2009-07-31 18:31:15
Attachments:
solo_mute_fix.patch
|
On Friday 31 July 2009 11:06:23 David Bailes wrote: > On Fri, Jul 31, 2009 at 3:51 PM, Steve<ste...@gm...> wrote: > > This is rather difficult to describe without illustrations so I have > > posted a description here: > > http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 > > > > Steve > > confirmed here on Vista. > The problem can be reproduced using a slightly simpler procedure: > 1. open a stero track. > 2. Adjust the height of the Audacity window so that only the top > channel of the track is visible. > 3. scroll down to see the bottom channel. > 4. The reappearing mute and solo controls don't work properly, as > described by Steve. > > David. The mute and solo handlers were using GetLinked() to check if the tracks were linked, which works only for the first (left) of the linked tracks. Here's a patch that fixes it for me. |
From: Gale A. <ga...@au...> - 2009-07-31 21:36:34
|
| From Al Dimond <bus...@gm...> | Fri, 31 Jul 2009 12:31:04 -0600 | Subject: [Audacity-devel] Solo and Mute not working on stereo track at top of window > On Friday 31 July 2009 11:06:23 David Bailes wrote: > > On Fri, Jul 31, 2009 at 3:51 PM, Steve<ste...@gm...> wrote: > > > This is rather difficult to describe without illustrations so I have > > > posted a description here: > > > http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 > > > > > > Steve > > > > confirmed here on Vista. > > The problem can be reproduced using a slightly simpler procedure: > > 1. open a stero track. > > 2. Adjust the height of the Audacity window so that only the top > > channel of the track is visible. > > 3. scroll down to see the bottom channel. > > 4. The reappearing mute and solo controls don't work properly, as > > described by Steve. > > > > David. > > The mute and solo handlers were using GetLinked() to check if the tracks were > linked, which works only for the first (left) of the linked tracks. Here's a > patch that fixes it for me. In fact this was already on the Checklist in this form: P3 (reported on Windows) At 120 DPI, importing a second stereo track causes the pre-existing stereo track above to split. * GA: See after importing second track: http://www.gaclrecords.org.uk/dp12.png If you mute the upper track, that only mutes the right-hand channel so you still hear the unwanted left-channel. To make the pre-existing track stereo again you have to up-arrow. I can't seem to reproduce David's issue on XP, unless I am misunderstanding the steps. IMO the real bug is that the track is being split in the first place, which is very confusing. 1.2 does not do this so it looks like a regression to me, so probably might even have been a P2 instead of a P3. Gale |
From: Gale A. <ga...@au...> - 2009-08-01 00:56:24
|
| From Gale Andrews <ga...@au...> | Fri, 31 Jul 2009 22:36:14 +0100 | Subject: [Audacity-devel] Solo and Mute not working on stereo track at top of window > | From Al Dimond <bus...@gm...> > | Fri, 31 Jul 2009 12:31:04 -0600 > | Subject: [Audacity-devel] Solo and Mute not working on stereo track at top of window > > On Friday 31 July 2009 11:06:23 David Bailes wrote: > > > On Fri, Jul 31, 2009 at 3:51 PM, Steve<ste...@gm...> wrote: > > > > This is rather difficult to describe without illustrations so I have > > > > posted a description here: > > > > http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 > > > > > > > > Steve > > > > > > confirmed here on Vista. > > > The problem can be reproduced using a slightly simpler procedure: > > > 1. open a stero track. > > > 2. Adjust the height of the Audacity window so that only the top > > > channel of the track is visible. > > > 3. scroll down to see the bottom channel. > > > 4. The reappearing mute and solo controls don't work properly, as > > > described by Steve. > > > > > > David. > > > > The mute and solo handlers were using GetLinked() to check if the tracks were > > linked, which works only for the first (left) of the linked tracks. Here's a > > patch that fixes it for me. > > In fact this was already on the Checklist in this form: > > P3 (reported on Windows) At 120 DPI, importing a second stereo track > causes the pre-existing stereo track above to split. > * GA: See after importing second track: > http://www.gaclrecords.org.uk/dp12.png > If you mute the upper track, that only mutes the right-hand > channel so you still hear the unwanted left-channel. To make the > pre-existing track stereo again you have to up-arrow. In fact, this unasked-for splitting occurs for me on Windows XP even at normal 96 DPI in that scenario of importing one stereo track then another. It doesn't occur if I import a track and duplicate it at normal DPI. Do we agree to promote this to P2 and fix it, or does anyone regard this splitting as a "feature" if we patch the mute/solo buttons to work? My view is: if the user has not split their stereo track, they do not get to see it split, irrespective of DPI and screen size. Otherwise, we're just breaking basic rules and making the user think they have split their track when they haven't. Gale > I can't seem to reproduce David's issue on XP, unless I am > misunderstanding the steps. > > IMO the real bug is that the track is being split in the first place, > which is very confusing. 1.2 does not do this so it looks like a > regression to me, so probably might even have been a P2 instead > of a P3. |
From: David B. <drb...@go...> - 2009-08-01 09:15:29
Attachments:
mute-solo-bug.png
|
On Fri, Jul 31, 2009 at 10:36 PM, Gale Andrews<ga...@au...> wrote: > >> > >> > confirmed here on Vista. >> > The problem can be reproduced using a slightly simpler procedure: >> > 1. open a stero track. >> > 2. Adjust the height of the Audacity window so that only the top >> > channel of the track is visible. >> > 3. scroll down to see the bottom channel. >> > 4. The reappearing mute and solo controls don't work properly, as >> > described by Steve. >> > > > I can't seem to reproduce David's issue on XP, unless I am > misunderstanding the steps. attached screen shot which is after step 3, David. |
From: Gale A. <ga...@au...> - 2009-08-01 21:15:36
|
| From David Bailes <drb...@go...> | Sat, 1 Aug 2009 10:15:15 +0100 | Subject: [Audacity-devel] Solo and Mute not working on stereo track at top of window > On Fri, Jul 31, 2009 at 10:36 PM, Gale Andrews<ga...@au...> wrote: > >> > confirmed here on Vista. > >> > The problem can be reproduced using a slightly simpler procedure: > >> > 1. open a stero track. > >> > 2. Adjust the height of the Audacity window so that only the top > >> > channel of the track is visible. > >> > 3. scroll down to see the bottom channel. > >> > 4. The reappearing mute and solo controls don't work properly, as > >> > described by Steve. > > > > I can't seem to reproduce David's issue on XP, unless I am > > misunderstanding the steps. > > attached screen shot which is after step 3, Thanks, David. Yes I can see it, I was trying to do it by dragging the track downwards as well, and the track split does occur in that case too, providing you drag the vertical scrollbar down far enough. I'm making these unwanted splits a P2 soon unless someone makes a strong case why we show an unsplit track as split when you can only see the right-hand channel. If you drag up the Audacity window a bit, drag the track down and then scroll down slowly as I was trying to do, I think you will see just how confusing this behaviour is. Gale |
From: Al D. <bus...@gm...> - 2009-08-02 05:36:03
|
On Saturday 01 August 2009 15:15:25 Gale Andrews wrote: > I'm making these unwanted splits a P2 soon unless someone makes a > strong case why we show an unsplit track as split when you can only > see the right-hand channel. If you drag up the Audacity window a bit, > drag the track down and then scroll down slowly as I was trying to > do, I think you will see just how confusing this behaviour is. I agree, the track shouldn't show up as split... it might (might) be cool if on tall tracks the buttons and sliders tried to stay visible when part of the track was off-screen, but the current behavior is weird. I don't really know the history of the behavior or how any of the display code works but I wouldn't be surprised if the root cause was pretty similar to why the mute/solo buttons aren't working... I'll try to figure it out tomorrow, but I'm not sure I'll get it. |
From: Steve <ste...@gm...> - 2009-08-02 15:37:45
|
On Sat, 2009-08-01 at 23:35 -0600, Al Dimond wrote: > On Saturday 01 August 2009 15:15:25 Gale Andrews wrote: > > I'm making these unwanted splits a P2 soon unless someone makes a > > strong case why we show an unsplit track as split when you can only > > see the right-hand channel. If you drag up the Audacity window a bit, > > drag the track down and then scroll down slowly as I was trying to > > do, I think you will see just how confusing this behaviour is. > > I agree, the track shouldn't show up as split... it might (might) be cool if > on tall tracks the buttons and sliders tried to stay visible when part of the > track was off-screen, but the current behavior is weird. When I first saw the track controls move I thought "that's cool - the controls are still visible" (I was assuming that they would behave just the same as when in their normal position), then I found they were doing weird things. Steve > I don't really know > the history of the behavior or how any of the display code works but I > wouldn't be surprised if the root cause was pretty similar to why the > mute/solo buttons aren't working... I'll try to figure it out tomorrow, but I'm > not sure I'll get it. |
From: Gale A. <ga...@au...> - 2009-08-02 17:51:54
|
| From Steve <ste...@gm...> | Sun, 02 Aug 2009 16:37:26 +0100 | Subject: [Audacity-devel] Solo and Mute not working on stereo track at top of window > On Sat, 2009-08-01 at 23:35 -0600, Al Dimond wrote: > > On Saturday 01 August 2009 15:15:25 Gale Andrews wrote: > > > I'm making these unwanted splits a P2 soon unless someone makes a > > > strong case why we show an unsplit track as split when you can only > > > see the right-hand channel. If you drag up the Audacity window a bit, > > > drag the track down and then scroll down slowly as I was trying to > > > do, I think you will see just how confusing this behaviour is. > > > > I agree, the track shouldn't show up as split... it might (might) be cool if > > on tall tracks the buttons and sliders tried to stay visible when part of the > > track was off-screen, but the current behavior is weird. > > When I first saw the track controls move I thought "that's cool - the > controls are still visible" (I was assuming that they would behave just > the same as when in their normal position), then I found they were doing > weird things. I thought so too, also that Audacity was being very clever to indicate that you were only looking at the right-hand channel of an unsplit stereo track. But I don't see how the track controls can be made to stay visible without this being confusing in itself - it means they would appear to float up and down the track panel, wouldn't it? I'd also be surprised if trying to do this was safe and without unintended consequences, which we really do not want at this stage. People have the Mixer Board now if they want access to controls for all the tracks irrespective of how the tracks display in the main window. Gale > > > I don't really know > > the history of the behavior or how any of the display code works but I > > wouldn't be surprised if the root cause was pretty similar to why the > > mute/solo buttons aren't working... I'll try to figure it out tomorrow, but I'm > > not sure I'll get it. > > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel |
From: Martyn S. <mar...@go...> - 2009-08-02 19:09:09
|
Hi there I see that the problem is in TrackPanel::DrawEverythingElse where VisibleTrackIterator does not find the Left track once it isn't visible. The First one found is the Right track, which isn't linked and hence the drawing that we get. Any ideas how to fix it? I wondered about modifying VisibleTrackIterator but I think that would break things elsewhere. TTFN Martyn Al Dimond wrote: > On Saturday 01 August 2009 15:15:25 Gale Andrews wrote: >> I'm making these unwanted splits a P2 soon unless someone makes a >> strong case why we show an unsplit track as split when you can only >> see the right-hand channel. If you drag up the Audacity window a bit, >> drag the track down and then scroll down slowly as I was trying to >> do, I think you will see just how confusing this behaviour is. > > I agree, the track shouldn't show up as split... it might (might) be cool if > on tall tracks the buttons and sliders tried to stay visible when part of the > track was off-screen, but the current behavior is weird. I don't really know > the history of the behavior or how any of the display code works but I > wouldn't be surprised if the root cause was pretty similar to why the > mute/solo buttons aren't working... I'll try to figure it out tomorrow, but I'm > not sure I'll get it. > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > _______________________________________________ > audacity-devel mailing list > aud...@li... > https://lists.sourceforge.net/lists/listinfo/audacity-devel > |
From: Al D. <bus...@gm...> - 2009-08-02 19:18:25
|
On Sunday 02 August 2009 13:09:06 Martyn Shaw wrote: > Hi there > > I see that the problem is in TrackPanel::DrawEverythingElse where > VisibleTrackIterator does not find the Left track once it isn't > visible. The First one found is the Right track, which isn't linked > and hence the drawing that we get. > > Any ideas how to fix it? I wondered about modifying > VisibleTrackIterator but I think that would break things elsewhere. > > TTFN > Martyn > The right-channel track won't come up linked by Track::GetLinked(), but if you instead call Track::GetLink() that will return a pointer to the Track linked to it. If it's null then nothing is linked to it. |
From: Al D. <bus...@gm...> - 2009-08-02 22:15:07
Attachments:
right_channel_fix_2.patch
|
On Sunday 02 August 2009 13:09:06 Martyn Shaw wrote: > Hi there > > I see that the problem is in TrackPanel::DrawEverythingElse where > VisibleTrackIterator does not find the Left track once it isn't > visible. The First one found is the Right track, which isn't linked > and hence the drawing that we get. > > Any ideas how to fix it? I wondered about modifying > VisibleTrackIterator but I think that would break things elsewhere. > > TTFN > Martyn Here's a patch that keeps all the changes in TrackPanel::DrawEverythingElse(). The basic idea is swapping l and t if l's border should be drawn but l will be missed by the iterator, but I didn't actually want to swap them because it changes the meaning of the variables, making future edits dangerous. I checked for usage of VisibleTrackIterator and it looks like it's only used in TrackPanel.cpp at this point and changing it might only cause some extra off-screen draws. If we wanted to change it but not change it I could add an optional parameter to VisibleTrackIterator::First() sort of like the skiplinked parameter to ::Next(). Optional bool parameters aren't my favorite thing, but they might be more elegant than this. - Al |
From: Steve <ste...@gm...> - 2009-07-31 20:30:12
|
On Fri, 2009-07-31 at 12:31 -0600, Al Dimond wrote: > On Friday 31 July 2009 11:06:23 David Bailes wrote: > > On Fri, Jul 31, 2009 at 3:51 PM, Steve<ste...@gm...> wrote: > > > This is rather difficult to describe without illustrations so I have > > > posted a description here: > > > http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 > > > > > > Steve > > > > confirmed here on Vista. > > The problem can be reproduced using a slightly simpler procedure: > > 1. open a stero track. > > 2. Adjust the height of the Audacity window so that only the top > > channel of the track is visible. > > 3. scroll down to see the bottom channel. > > 4. The reappearing mute and solo controls don't work properly, as > > described by Steve. > > > > David. > > The mute and solo handlers were using GetLinked() to check if the tracks were > linked, which works only for the first (left) of the linked tracks. Here's a > patch that fixes it for me. When the Audacity Preferences are set to "Solo button: Standard" (Tracks tab of Preferences), the patch works. When it is set to "Solo button: Simple", the mute button still works but not the solo button. Steve |
From: Al D. <bus...@gm...> - 2009-07-31 21:06:11
Attachments:
solo_mute_fix_2.patch
|
On Friday 31 July 2009 14:29:54 Steve wrote: > On Fri, 2009-07-31 at 12:31 -0600, Al Dimond wrote: > > On Friday 31 July 2009 11:06:23 David Bailes wrote: > > > On Fri, Jul 31, 2009 at 3:51 PM, Steve<ste...@gm...> wrote: > > > > This is rather difficult to describe without illustrations so I have > > > > posted a description here: > > > > http://forum.audacityteam.org/viewtopic.php?f=18&t=11905 > > > > > > > > Steve > > > > > > confirmed here on Vista. > > > The problem can be reproduced using a slightly simpler procedure: > > > 1. open a stero track. > > > 2. Adjust the height of the Audacity window so that only the top > > > channel of the track is visible. > > > 3. scroll down to see the bottom channel. > > > 4. The reappearing mute and solo controls don't work properly, as > > > described by Steve. > > > > > > David. > > > > The mute and solo handlers were using GetLinked() to check if the tracks > > were linked, which works only for the first (left) of the linked tracks. > > Here's a patch that fixes it for me. > > When the Audacity Preferences are set to "Solo button: Standard" (Tracks > tab of Preferences), the patch works. > When it is set to "Solo button: Simple", the mute button still works but > not the solo button. > > Steve Oops. I also missed the case where you're holding shift and hit mute. I thought those would work for some reason. New patch attached. |
From: Gale (A. Team) <ga...@au...> - 2009-08-03 19:30:11
|
Al Dimond wrote: >>On Sunday 02 August 2009 13:09:06 Martyn Shaw wrote: >> I see that the problem is in TrackPanel::DrawEverythingElse where >> VisibleTrackIterator does not find the Left track once it isn't >> visible. The First one found is the Right track, which isn't linked >> and hence the drawing that we get. >> >> Any ideas how to fix it? I wondered about modifying >> VisibleTrackIterator but I think that would break things elsewhere. >> >> TTFN >> Martyn > > Here's a patch that keeps all the changes in > TrackPanel::DrawEverythingElse(). > The basic idea is swapping l and t if l's border should be drawn but l > will be > missed by the iterator, but I didn't actually want to swap them because it > changes the meaning of the variables, making future edits dangerous. > > > I checked for usage of VisibleTrackIterator and it looks like it's only > used > in TrackPanel.cpp at this point and changing it might only cause some > extra > off-screen draws. If we wanted to change it but not change it I could add > an > optional parameter to VisibleTrackIterator::First() sort of like the > skiplinked parameter to ::Next(). Optional bool parameters aren't my > favorite > thing, but they might be more elegant than this. > > > Al I've applied the patch and tried various ways of reproducing the bug by importing two stereo tracks, changing DPI, screen resolution, window resizing etc. and it seems perfect here on Windows XP. Thanks, Al. I think we should commit this unless someone finds any problems on the other platforms. The latest Windows "Nightly": http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.9-alpha.zip includes the patch if anyone needs to test if screen readers behave properly with the fix. I have not tested that. Gale > > Index: src/TrackPanel.cpp > =================================================================== > RCS file: /cvsroot/audacity/audacity-src/src/TrackPanel.cpp,v > retrieving revision 1.471 > diff -u -r1.471 TrackPanel.cpp > --- src/TrackPanel.cpp 31 Jul 2009 16:39:34 -0000 1.471 > +++ src/TrackPanel.cpp 2 Aug 2009 22:04:20 -0000 > @@ -4927,12 +4927,29 @@ > skipBorder = true; > } > > + // If the previous track is linked to this one but isn't on the > screen > + // (and thus would have been skipped by VisibleTrackIterator) we > need to > + // draw that track's border instead. > + Track *borderTrack = t; > + wxRect borderRect = r, borderTrackRect = trackRect; > + > + if (l && !t->GetLinked() && trackRect.y < 0) > + { > + borderTrack = l; > + > + borderTrackRect.y = l->GetY() - mViewInfo->vpos; > + borderTrackRect.height = l->GetHeight(); > + > + borderRect = borderTrackRect; > + borderRect.height += t->GetHeight(); > + } > + > if (!skipBorder) { > if (mAx->IsFocused(t)) { > - focusRect = r; > + focusRect = borderRect; > } > > - DrawOutside(t, dc, r, trackRect); > + DrawOutside(borderTrack, dc, borderRect, borderTrackRect); > } > > // Believe it or not, we can speed up redrawing if we don't > > -- View this message in context: http://n2.nabble.com/Solo-and-Mute-not-working-on-stereo-track-at-top-of-window-tp3363076p3379936.html Sent from the audacity-devel mailing list archive at Nabble.com. |
From: Martyn S. <mar...@go...> - 2009-08-03 22:04:17
|
Gale (Audacity Team) wrote: > Al Dimond wrote: >>> On Sunday 02 August 2009 13:09:06 Martyn Shaw wrote: >>> I see that the problem is in TrackPanel::DrawEverythingElse where >>> VisibleTrackIterator does not find the Left track once it isn't >>> visible. The First one found is the Right track, which isn't linked >>> and hence the drawing that we get. >>> >>> Any ideas how to fix it? I wondered about modifying >>> VisibleTrackIterator but I think that would break things elsewhere. >>> >>> TTFN >>> Martyn >> Here's a patch that keeps all the changes in >> TrackPanel::DrawEverythingElse(). >> The basic idea is swapping l and t if l's border should be drawn but l >> will be >> missed by the iterator, but I didn't actually want to swap them because it >> changes the meaning of the variables, making future edits dangerous. >> >> >> I checked for usage of VisibleTrackIterator and it looks like it's only >> used >> in TrackPanel.cpp at this point and changing it might only cause some >> extra >> off-screen draws. If we wanted to change it but not change it I could add >> an >> optional parameter to VisibleTrackIterator::First() sort of like the >> skiplinked parameter to ::Next(). Optional bool parameters aren't my >> favorite >> thing, but they might be more elegant than this. >> >> >> Al > > I've applied the patch and tried various ways of reproducing the bug by > importing two stereo tracks, changing DPI, screen resolution, window > resizing etc. and it seems perfect here on Windows XP. Thanks, Al. I think > we should commit this unless someone finds any problems on the other > platforms. The latest Windows "Nightly": > http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.9-alpha.zip > > includes the patch if anyone needs to test if screen readers behave properly > with the fix. I have not tested that. I looked at this carefully with Al last night and it looks good to me as well. Committed. Martyn > Gale > > > > >> Index: src/TrackPanel.cpp >> =================================================================== >> RCS file: /cvsroot/audacity/audacity-src/src/TrackPanel.cpp,v >> retrieving revision 1.471 >> diff -u -r1.471 TrackPanel.cpp >> --- src/TrackPanel.cpp 31 Jul 2009 16:39:34 -0000 1.471 >> +++ src/TrackPanel.cpp 2 Aug 2009 22:04:20 -0000 >> @@ -4927,12 +4927,29 @@ >> skipBorder = true; >> } >> >> + // If the previous track is linked to this one but isn't on the >> screen >> + // (and thus would have been skipped by VisibleTrackIterator) we >> need to >> + // draw that track's border instead. >> + Track *borderTrack = t; >> + wxRect borderRect = r, borderTrackRect = trackRect; >> + >> + if (l && !t->GetLinked() && trackRect.y < 0) >> + { >> + borderTrack = l; >> + >> + borderTrackRect.y = l->GetY() - mViewInfo->vpos; >> + borderTrackRect.height = l->GetHeight(); >> + >> + borderRect = borderTrackRect; >> + borderRect.height += t->GetHeight(); >> + } >> + >> if (!skipBorder) { >> if (mAx->IsFocused(t)) { >> - focusRect = r; >> + focusRect = borderRect; >> } >> >> - DrawOutside(t, dc, r, trackRect); >> + DrawOutside(borderTrack, dc, borderRect, borderTrackRect); >> } >> >> // Believe it or not, we can speed up redrawing if we don't >> >> > |
From: David B. <drb...@go...> - 2009-08-04 08:04:28
|
On Mon, Aug 3, 2009 at 8:30 PM, Gale (Audacity Team)<ga...@au...> wrote: > > I've applied the patch and tried various ways of reproducing the bug by > importing two stereo tracks, changing DPI, screen resolution, window > resizing etc. and it seems perfect here on Windows XP. Thanks, Al. I think > we should commit this unless someone finds any problems on the other > platforms. The latest Windows "Nightly": > http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.9-alpha.zip > > includes the patch if anyone needs to test if screen readers behave properly > with the fix. I have not tested that. Screen reader's still behave properly - they weren't affected by the bug, since the keystrokes worked correctly. In passing, the keystrokes for mute and solo on a single track (shift+u, and shift+s) work whilst audio is playing, but the keystrokes for mute/unmute all (ctrl+u, ctrl+shift+u) don't. I presume this is a minor bug, rather than intentional, David. |
From: Gale A. <ga...@au...> - 2009-08-05 07:51:51
|
| From David Bailes <drb...@go...> | Tue, 4 Aug 2009 09:04:17 +0100 | Subject: [Audacity-devel] Solo and Mute not working on stereo track at top of window > On Mon, Aug 3, 2009 at 8:30 PM, Gale (Audacity > Team)<ga...@au...> wrote: > > I've applied the patch and tried various ways of reproducing the bug by > > importing two stereo tracks, changing DPI, screen resolution, window > > resizing etc. and it seems perfect here on Windows XP. Thanks, Al. I think > > we should commit this unless someone finds any problems on the other > > platforms. The latest Windows "Nightly": > > http://www.gaclrecords.org.uk/audacity-win-unicode-1.3.9-alpha.zip > > > > includes the patch if anyone needs to test if screen readers behave properly > > with the fix. I have not tested that. > > Screen reader's still behave properly - they weren't affected by the > bug, since the keystrokes worked correctly. > > In passing, the keystrokes for mute and solo on a single track > (shift+u, and shift+s) work whilst audio is playing, but the > keystrokes for mute/unmute all (ctrl+u, ctrl+shift+u) don't. I presume > this is a minor bug, rather than intentional, Mute All Tracks/UnMute (sic) All Tracks is greyed out in the menus when playing, so cannot be used by sighted persons either. I'd assume it should be "enabled whenever an audio track is open", not "disabled only if one is playing" as it appears (it's pointless having these menu items active to "mute" a time track or label track). Gale |