I'm being cautious here. I could just commit this and see if there
are consequences, and might do that next week.
On 17/04/2012 22:02, Vaughan Johnson wrote:
> On 4/17/2012 12:28 PM, James Crook wrote:
>> If we do a concerted Cleanspeech cleanup, I'd like us to hit everything
>> that is relevant, rather than have more to do for 2.0.2.
OK, so I've followed this and tried to hit all the relevant things
from this thread, from a CleanSpeech perspective. You might have to
remove your C:\Users\Martyn\AppData\Roaming\Audacity\Chains (or
whatever) to test it.
Please test/review attached patch. I have used
#else // CLEANSPEECH
#endif // CLEANSPEECH
to identify everything that I can to remove CS from the code. One
sweep for 'CLEANSPEECH' should come up with all the required deletions
necessary. Some of the patch looks long but it is just indents.
CLEANSPEECH is defined/undefined in Experimental.h, this patch sets it
undefined but it compiles fine here either way.
I have tried to separate out the removal of CS from changes to 'Batch'.
Issues that I see remaining are:
I have left in ADVANCED_EFFECT and additionalEffects, in case they are
useful in the future (for batch, or whatever).
BatchPrefs are commented out in PrefsDialog::PrefsDialog so
Batch/Debug is never set/used. The whole of BatchPrefs could be
removed (or might be useful in the future). Not a CS issue.
HIDDEN_EFFECT is a mystery to me.
SIMPLE_EFFECT appears to be unused, but, as with HIDDEN_EFFECT, may be
useful in future.
The whole 'SpecialCommands' thing is a bit of a bodge, which I have
left in, since we need to decide if we need it or not (or have another
plan). There are comments to that effect in the code above
BatchCommands::ApplySpecialCommand. BuildCleanFileName comes into that.
The RestoreChain methodology is flawed, with a new method needing to
be added for each default chain. I have left it in for the single
default chain 'MP3Conversion' that is left. The method used in EQ for
default curves is much better, I feel.
HTH, and I welcome comments
> - V
> Better than sec? Nothing is better than sec when it comes to
> monitoring Big Data applications. Try Boundary one-second
> resolution app monitoring today. Free.
> Audacity-quality mailing list