From: Gale Andrews <gale@au...> - 2012-12-10 00:36:15
| From Campbell Barton <ideasman42@...>
| Thu, 6 Dec 2012 14:33:33 +1100
| Subject: [Audacity-devel] fix for undo while shifting [diff on r12052]
> On Thu, Dec 6, 2012 at 11:26 AM, Gale Andrews <gale@...> wrote:
> > | From Richard Ash <richard@...>
> > | Tue, 4 Dec 2012 16:42:57 +0000
> > | Subject: [Audacity-devel] fix for undo while shifting [diff on r12052]
> >> On Sun, 02 Dec 2012 00:16:56 +0000
> >> Martyn Shaw <martynshaw99@...> wrote:
> >> > Can you confirm that the last few lines of Campbell's patch fixes
> >> > this on Mac and Linux?
> >> I can confirm the crash and the fix on Linux, so I've committed the
> >> changes (I can't see anyone discovering this other than through a
> >> crash).
> > I can confirm on Mac that keyboard undo while dragging selections
> > or time-shifting tracks/clips no longer crashes. Thanks, Campbell.
> > New bugs opened for the Mac/Linux crashes for keyboard undo
> > while dragging envelope points or sample points:
> > http://bugzilla.audacityteam.org/show_bug.cgi?id=602
> > http://bugzilla.audacityteam.org/show_bug.cgi?id=603
> > Started as P2 (I could see someone hurriedly undoing a batch of
> > points while forgetfully still holding the mouse).
> > Gale
> Hi, I found another issue on linux - when Shift-Tol is active and '['
> is pressed (any popup in fact), the new window opens but the main
> window still holds focus (Its still grabbed as far as X11 is
> concerned), and I can't click on the toolbox or exit it, shifting also
> The only way I found to exit it is to press escape which exits the
> tool and the popup.
Sorry, what Desktop Environment is this? I use GNOME on Ubuntu.
There is this issue where dialogues can only accept OK or ESC
without mouse input:
However on Ubuntu the dialogue "appears" to have focus insofar as
its title bar is bolded.
> Perhaps the logic should be inverted - so rather then disable specific
> functions when a tool runs, it might be better to disable all other
> tools until the modal operation finishes.
Isn't that what is intended to happen now?
> In Blender, modal tools get its own keymap which can choose to handle
> the events or pass them through to the other handlers. This way its
> possible to have a modal tool that can still zoom/pan for instance.
> Though I'm not sure audacity really needs that kind of flexibility.