On 20 August 2013 16:05, Steve the Fiddle <stevethefiddle@gmail.com> wrote:



On 20 August 2013 09:59, Joel Bouchat <bouchat@hotmail.com> wrote:
Hello,

>From release 12462, the patch to libsndfile "0001-Add-support-for-Album-and-Track-tags-in-RIFF-files-for-libsndfile" is committed. Thank you Richard!

Here is the update to ImportPCM.cpp and ExportPCM.cpp to take advantage of this modification of "libsndfile".

This patch also includes the small improvement to AIFF files: adding a space to odd length strings in the metadata tags. This improvement has been successfuly checked by Gale with dBPoweramp and Riffpad (and also with an Hex editor).
It would be nice to also test it on a MAC and an iPod.
For the commitment, the patches on WAV files and AIFF files cannot be dissociated. Both belongs to the "PCM" family processed by "libsndfile".

I'm getting the following build error on Linux:

export/ExportMultiple.cpp: In member function 'int ExportMultiple::ExportMultipleByLabel(bool, wxString, bool)':
export/ExportMultiple.cpp:669:45: error: cannot pass objects of non-trivially-copyable type 'class wxString' through '...'
export/ExportMultiple.cpp:672:45: error: cannot pass objects of non-trivially-copyable type 'class wxString' through '...'
export/ExportMultiple.cpp:746:48: error: cannot pass objects of non-trivially-copyable type 'class wxString' through '...'
export/ExportMultiple.cpp:780:47: error: cannot pass objects of non-trivially-copyable type 'class wxString' through '...'
make[1]: *** [export/ExportMultiple.o] Error 1
make[1]: Leaving directory `/home/steve/sourcecode/audacity-clean/src'
make: *** [audacity] Error 2

My mistake - that was just some cruft left over from a previous patch.
It builds fine here when I do it right.

Steve


Steve

 
Best regards,

Joel