Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

pull requests on github

Help
abma
2012-11-05
2013-06-03
  • abma
    abma
    2012-11-05

    did you miss the pull requests on github?

    https://github.com/assimp/assimp/pulls

    it seems like devs are most active in this forum… (a mail related to pull requests wasn't answered on the mailinglist, too)

     
  • The only one I know how is using Github is Aramis, but he has been very busy in the last months. I've never had a look there. I'll see if I can merge these change requests manually.

     
  • I merged the three small pull requests manually. I won't do that for large pyassimp change request, though… too much work to do manually. Is there a way to get everything as one patch file? If not, I'll probably leave this to Aramis.

     
  • Just add ».diff« or ».patch« to the end of the URL to get the pull request as a plain diff or a series of patches: https://github.com/assimp/assimp/pull/8.patch

    In general, it would probably be a wise idea to set up forwarding of the GitHub notifications to the mailing list as long as not all of the committers »Watch« the GitHub repo. I don't know how soon I'll get around to look into this, but maybe Alex can set it up?

    David

     
  • Kim Kulling
    Kim Kulling
    2012-11-06

    Hi,

    I just set me as a watcher to the git-repo and will commit any pull requests.

    Kimmi

     
  • abma
    abma
    2012-11-08

    thanks!