#635 Patch for bug 3598830 - Alice Farmer

closed-accepted
bluelads4
None
2013-02-12
2013-01-17
bonneville
No

I made a test for the conversation with Alice Farmer and I could reproduce the issue in 3598830 (Alice Farmer in Ados replies with an empty message).
HolidayingWomanNPC uses TriggerIsProducedItemOfClassCondition to recognize different types of food, and items with trailing dots are matched here because expressions are used. Later on, it uses ListProducedItemDetailAction to get the result, and this would only match if using expressions as well.

Discussion

  • bluelads4
    bluelads4
    2013-01-17

    Thanks for the bugfix patch! :) I commited the ListProducedItemDetailAction.java changes but not the test so far cause it shows a failure, that's why I'm going to leave the tracker entry still open as long as the test will be commited :)

    Greetings

    Bluelads4

     
  • bonneville
    bonneville
    2013-01-19

    I installed Jenkins, I saw the test failing and I fixed it. Should work now.

     
  • bluelads4
    bluelads4
    2013-02-12

    Hello again :)

    I can't apply the fixed test cause it's not made as a patch and it wants to start directly and I'm not sure how to implement it. can you maybe create a patch out of it? :)

    Greetings

    Bluelads4

     
  • bluelads4
    bluelads4
    2013-02-12

    • assigned_to: nobody --> bluelads99
    • status: open --> closed-accepted
     
  • bluelads4
    bluelads4
    2013-02-12

    Oh sorry nevermind, it worked and the test runs perfectly through :)

    Thanks for the patches! :)

    Greetings

    Bluelads4

     
  • bluelads4
    bluelads4
    2013-02-12

    Thanks for the patch.
    It has been applied to cvs trunk.

     


Anonymous


Cancel   Add attachments