Menu
▾
▴
[Arianne-bugs] [ arianne-Bugs-1870577 ] Underscore Conversion should destroys, quests, visited zones
|
From: SourceForge.net <no...@so...> - 2008-01-19 18:44:04
|
Bugs item #1870577, was opened at 2008-01-13 23:31 Message generated for change (Comment added) made by martinfuchs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1870577&group_id=1111 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: Hendrik (nhnb) Assigned to: Martin Fuchs (martinfuchs) Summary: Underscore Conversion should destroys, quests, visited zones Initial Comment: Underscore Conversion should destroys, quests, visited zones I think it be would be enough to simple change the item name in PlayerRPClass.loadSlotContent(...) between these lines String name = item.get("name"); if (ITEM_NAMES_OLD.indexOf(name) > -1) { and have a little method with converts the kill-slot? StendhalRPObjectFactory seems to be too deep. ---------------------------------------------------------------------- >Comment By: Martin Fuchs (martinfuchs) Date: 2008-01-19 19:44 Message: Logged In: YES user_id=1534223 Originator: NO Hendrik, what do you think now about this issue? The current implementation seems to work, shall we steill change it to not use the recursive aproach iterating through slots? It has the advantage to possibly only do the conversion once at login time. Later there is no need for it when putting something in a slot. I would like to close this report if you agree. But if you think it's really better we could of course create a method like transformKillSlot(), which is called at login time and do the item name conversion only in PlayerRPClass.loadSlotContent(). ---------------------------------------------------------------------- Comment By: Martin Fuchs (martinfuchs) Date: 2008-01-14 09:00 Message: Logged In: YES user_id=1534223 Originator: NO OK, i will look into this this evening. Then we can discuss this a bit more. ---------------------------------------------------------------------- Comment By: Martin Fuchs (martinfuchs) Date: 2008-01-14 08:59 Message: Logged In: YES user_id=1534223 Originator: NO OK, i will look into this this evening. Then we can discuss this a bit more. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=101111&aid=1870577&group_id=1111 |