I'm currently spending some time splitting big functions in the code,
apologies for any inconvenience (especially when wanting to re-merge the
These functions need to be splitted, because small functions increase
readability of the code and heavily reduce the possibilities of bugs (and
the time needed to fix them).
I'll quote /usr/src/linux/Documentation/CodingStyle (Chapter 4):
> Functions should be short and sweet, and do just one thing. They
> should fit on one or two screenfuls of text (the ISO/ANSI screen size
> is 80x24, as we all know), and do one thing and do that well.
(I won't consume bandwidth by pasting the rest here, check your local
kernel source or http://www.linuxhq.com/kernel/v2.4/doc/CodingStyle.html
for non-linux ppl).
Note: That's right, I don't follow the brace placing chapter, just I think
it's more readable the way I do, but I may be wrong.
This "do one thing and do that well" part is very important IMHO, that's
why I'll spend some time on it (anyway I'm stuck waiting for pchitescu,
currently). Note, a better way would be that _you_ split your functions
when they become too long...
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12 - http://www.ebb.org/ungeek/
GCS/IT d-- s: a--- C++++ ULVB++++ P+++ L+++$>++++$ E---(-) W+(-) N+(++) o?
K? w---(--) O? M- V? !PS PE(--) Y+(++) PGP+ t- 5? X R(+) tv-- b+(+++) DI
D++ G++ e->++ h* r-- y?
------END GEEK CODE BLOCK------
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com