Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#5069 achievement notification doesn't show title, desc is x2

closed-fixed
Katie Russell
None
5
2011-02-10
2011-01-29
Katie Russell
No

the achievement notification shows the description twice, it should show the title and the description, i think?

i.e. in the case of the screen shot:
Experienced Adventurer
Reach Level 300

Not
Reach Level 300
Reach Level 300

Discussion

  • Katie Russell
    Katie Russell
    2011-01-30

    I found the cause in games.server.events.ReachedAchievementEvent, can upload patch later

     
  • Katie Russell
    Katie Russell
    2011-01-30

    Okay, its just:

    diff --git a/src/games/stendhal/server/events/ReachedAchievementEvent.java b/src/games/stendhal/server/events/ReachedAchievementEvent.java
    index d2c0d20..a4db7ae 100644
    --- a/src/games/stendhal/server/events/ReachedAchievementEvent.java
    +++ b/src/games/stendhal/server/events/ReachedAchievementEvent.java
    @@ -26,7 +26,7 @@ public class ReachedAchievementEvent extends RPEvent {
    public ReachedAchievementEvent(Achievement achievement) {
    super(Events.REACHED_ACHIEVEMENT);
    put("category", achievement.getCategory().toString());
    - put("title", achievement.getDescription());
    + put("title", achievement.getTitle());
    put("description", achievement.getDescription());
    }

     


Anonymous


Cancel   Add attachments