Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#3 Changed location of color code

closed-accepted
Bob Savage
None
5
2002-01-23
2002-01-17
Bob Savage
No

This patch changes the location of color code. After
the patch is applied everything runs as before, but
the build is clean (the warnings about setColor are
gone).

I did two things:
(1) I moved setColor out of a private category and
into the main AQTGraphic interface/
implementation.

I did this to get rid of the warnings, and because
there didn't seem to be any reason for this extra
level of privacy, and I think it helps to not have the
warnings so if something does go wrong, it
doesn't get lost.

(2) I moved getColorFromIndex out of the category
on NSColor and into the interface/implementation
of AQTGraphic.

I did this because I noticed that the only classes
calling this method were subclasses of
AQTGraphic, so it looks to me like this is where it
belongs.

This is the section that needs to be changed so
that the user can select which colors are
associated with the indices. A model class will be
needed to implement that (not a category)
because it requires saving a variable. I believe
having this code in AQTGraphic means we can
use a set of class variables.

-- Bob

Discussion

  • Bob Savage
    Bob Savage
    2002-01-17

    diff to implement color changes

     
    Attachments
  • Per Persson
    Per Persson
    2002-01-23

    • status: open --> open-accepted
     
  • Per Persson
    Per Persson
    2002-01-23

    • assigned_to: nobody --> bobsavage
     
  • Per Persson
    Per Persson
    2002-01-23

    • status: open-accepted --> closed-accepted