Re: [Aoetools-discuss] kvblade patch: ATA_SERNO_LEN --> ATA_ID_SERNO_LEN after linux-2.6.20

[Sam H. <sa...@co...>]

Hello Bernard,

The only changes that currently would go into an alpha4 would be
Adam's patches.

Sam

> Hi Sam:
> 
> Besides Adam's patch, has there been any changes since alpha3?
> 
> TIA,
> 
> Bernard
> 
> On 4/16/07, Sam Hopkins <sa...@co...> wrote:
>> Hello Adam,
>>
>> Kvblade uses a compatibility patch system in order to make the sources
>> compilable on (hopefully) any given system.  The patches you've
>> provided should be integrated into the compat patch system (see conf/)
>> in order to make a kvblade-alpha-4.  We eschew just making the source
>> compilable on the latest systems -- it should be useable by anyone.
>>
>> If you provide patches to kvblade that use the conf compat patches,
>> I'll quickly integrate them and release a kvblade-alpha-4.  Otherwise
>> alpha-4 will wait until I find time to integrate your work myself.
>>
>> As a tip, the compat patches always go from old to new (ie:
>> removing/adding a feature for a newer kernel).  The released source
>> should be ready for the latest kernels (ie: all the compat patches are
>> applied).
>>
>> Cheers,
>>
>> Sam
>>
>> >       A name change in include/linux/ata.h that occurred after
>> > linux-2.6.20 and either before or at 2.6.20-git7 causes kvblade not
>> > to compile.  I have attached a trivial patch against kvblade-alpha-3.
>> >
>> >       I have only tested that this patch compiles under
>> > 2.6.21-rc6-git8 with my other patches applied.
>> >
>> >       The new symbol is ATA_ID_SERNO_LEN.  Because this symbol and
>> > the old one it replaces are both enums rather than #defines, I cannot
>> > check for it with #ifdef.  Instead, I had to use <linux/version.h>,
>> > and even this change will break under kernels like 2.6.20-git7, which
>> > are encoded the same as 2.6.20.  However, 2.6.21-rc kernels should be
>> > fine.
>> >
>> >       By the way, I am submitting this patch in the form of the
>> > output of the stg ("stacked git") "export" command because this change
>> > overlaps with another similar trivial change that I submitted some
>> > time ago, when include/linux/config.h disappeared.  I, for one, would
>> > encourage an alpha-4 release even if the only changes are trivial name
>> > adjustments like these.
>> >
>> >       Also, if there is some public development repository that I
>> > should be checking, I apologize for missing it and would be interested
>> > in knowing about it.  The sourceforge CVS tree for aoetools appears to
>> > be empty.
>> >
>> > Adam Richter
>>
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by DB2 Express
>> Download DB2 Express C - the FREE version of DB2 express and take
>> control of your XML. No limits. Just data. Click to get it now.
>> http://sourceforge.net/powerbar/db2/
>> _______________________________________________
>> Aoetools-discuss mailing list
>> Aoe...@li...
>> https://lists.sourceforge.net/lists/listinfo/aoetools-discuss
>>