From: Sake S. <ec...@gm...> - 2007-03-31 19:39:06
|
Hi Kakaroto, I finished all the TODO regarding the change font size feature, namely: - the "view->text size" menu should show text like "custom font/smallest/small/medium/large/largest" In my implementation: smallest corresponds to size -2 from basesize (size 1= 1 - 2 =3D 9), small to -1 from basesize (size 11 - 1 =3D 10), medium is size = 11, large is size 13 (11 + 2), and largest is size 15 (11 + 4) - the "view->text size" items should become checkboxes so users can see the current size they chose (only if time permits) It is a checkbox now, and the program will remember users selection as well...And if user change font from the choose font window, and the font does not correspond to any of the font size of smallest ... largest, then none of the checkbox is checked. Actually, they are radio button, only one or none of the is selected at one time. - the change font dialog should have a 'size' column Added - add a "change my font" menu item in the view menu under "text size" to allow accessibility to changing the font from the menu, if the buttonbar is hidden Added as well Here is the diff: Index: chatwindow.tcl =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- chatwindow.tcl (revision 8341) +++ chatwindow.tcl (working copy) @@ -1417,6 +1414,9 @@ #textstyle $viewmenu add cascade -label "[trans textsize]" -menu [CreateTextSizeMenu $viewmenu] + #changefont + $viewmenu add command -label "[trans changefont]" -command "after = 1 change_font [string range $w 1 end] mychatfont" + #---------------------- $viewmenu add separator @@ -1442,13 +1442,11 @@ set textsizemenu $menu.textsize menu $textsizemenu -tearoff 0 -type normal - foreach size {" 8" " 6" " 4" " 2" " 1" " 0" " -2" " -4" } { - if {$size > 0 } { - $textsizemenu add command -label "+$size" -command "change_myfontsize $size" - } else { - $textsizemenu add command -label "$size" -command "change_myfontsize $size" - } - } + $textsizemenu add radiobutton -label "[trans smallest]" -value -2 -variable [::config::getVar textsize] -command "change_myfontsize -2" + $textsizemenu add radiobutton -label "[trans small]" -value -1 -variable [::config::getVar textsize] -command "change_myfontsize -1" + $textsizemenu add radiobutton -label "[trans medium]" -value 0 -variable [::config::getVar textsize] -command "change_myfontsize 0" + $textsizemenu add radiobutton -label "[trans large]" -value 2 -variable [::config::getVar textsize] -command "change_myfontsize 2" + $textsizemenu add radiobutton -label "[trans largest]" -value 4 -variable [::config::getVar textsize] -command "change_myfontsize 4" return $textsizemenu } Index: lang/langen =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- lang/langen (revision 8341) +++ lang/langen (working copy) @@ -440,6 +440,7 @@ language Language language_manager Language manager large Large +largest Largest lastlogin Last Log In lastlogout Last Log Out lastmsgedme Last Message @@ -494,6 +495,7 @@ mailer Mailer maintenance The server is going down for maintenance in $1 minutes maximised Maximised +medium Medium minimised Minimised/Iconified minimize Minimize to Tray mins minutes @@ -758,6 +760,7 @@ skinselector Select Skin skin Skin small Small +smallest Smallest smileconfig Custom emoticon configuration smilefile Smiley filename smileintro2 Please edit the required fields to customize this smiley (see the FAQ for help) Index: gui.tcl =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gui.tcl (revision 8341) +++ gui.tcl (working copy) @@ -3803,7 +3803,7 @@ return } - set selected_font [SelectFont .fontsel -parent $parent -title $title -font $initialfont -initialcolor $initialcolor -nosizes 1] + set selected_font [SelectFont .fontsel -parent $parent -title $title -font $initialfont -initialcolor $initialcolor] return $selected_font } @@ -3833,6 +3833,7 @@ } set sel_fontfamily [lindex $selfont 0] + set sel_fontsize [lindex $selfont 1] set sel_fontstyle [lrange $selfont 2 end] @@ -3844,7 +3845,7 @@ ::config::setKey $key [list $sel_fontfamily $sel_fontstyle $selcolor] - change_myfontsize [::config::getKey textsize] + change_myfontsize [expr {$sel_fontsize - $basesize} ] } And concerning the "alarm window", here is the diff: Index: alarm.tcl =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- alarm.tcl (revision 8341) +++ alarm.tcl (working copy) @@ -307,9 +307,9 @@ if { [::alarms::getAlarmItem ${config_user} pic_st] =3D=3D 1 || [::alarms::getAlarmItem ${config_user} sound_st] =3D=3D 1 } { toplevel .${wind_name} - set myDate [ clock format [clock seconds] -format " - %d/%m/%y at %H:%M" ] - wm title .${wind_name} "[trans alarm] $user $myDate" - label .${wind_name}.txt -text "$msg" + set myDate [ clock format [clock seconds] -format "%d %b %Y %T" ] + wm title .${wind_name} "[trans alarm] - $nick" + label .${wind_name}.txt -text "$nick ($user)\n[trans on] $myDate\n\n$msg\n" pack .${wind_name}.txt } Thanks Kakaroto, I look forward for your reply... :) Regards, Sakesashimi On 3/28/07, Sake Sashimi <ec...@gm...> wrote: > > Hi Kakaroto, > > Thanks for the reply. As soon as I have everything, I'll send you the > diff... > > Regards, > Sakesashimi > > > On 3/28/07, Youness Alaoui <kak...@ka...> wrote: > > > > Hi, > > Thanks Sake, > > About translation, it's really simple, all you have to do is : [trans > > translation_keyword] (for example [trans > > medium] and [trans small], etc..) then you open the file > > amsn/lang/langen (for english) and add the words in > > there, the keyword as the first of the line, so, for example : > > medium Medium > > small Small > > etc.. > > and that's all you have to do for adding the translation... after that, > > the translators will notice that there > > is a 'new, untranslated key' and they will send their translations, > > that's all you care about it. > > So having the need to add a new translation key is not an issue at all, > > the only thing, we , developers, care > > about is the english words that need to be in lang/langen and the > > [trans] call.. > > > > p.s.: sorry, I'm very busy lately, so I didn't have time to review your > > code changes and commit your patches, > > but from what I saw, it's looking good so far... once you finish, if yo= u > > would be kind enough to send all the > > diffs in a single email so I won't have to search for them (especially > > since you sent many diffs..) > > > > Thanks.. > > KaKaRoTo > > > > > > On Wed, Mar 28, 2007 at 01:00:28AM -0400, Sake Sashimi wrote: > > > Hi Kakaroto, > > > > > > Thanks for your reply. For the list of TODO that you gave me at the > > bottom > > > of your email, I implemented the 3rd and 4rd, namely: > > > > > > - the change font dialog should have a 'size' column (already done > > afaik) > > > - add a "change my font" menu item in the view menu under "text size" > > to > > > allow accessibility to changing the > > > font from the menu, if the buttonbar is hidden > > > > > > For the first one, namely: the "view->text size" menu should show tex= t > > like > > > "custom font/smallest/small/medium/large/largest", I checked aMSN > > language > > > translation, and we do not have translation for smallest, medium, and > > > largest. From experience with the 'alarm window', I believe I could > > not > > > just hard code the word right ? they must be translated? > > > > > > Here is the diff for implementation 3 and 4: > > > > > > Index: chatwindow.tcl > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- chatwindow.tcl (revision 8320) > > > +++ chatwindow.tcl (working copy) > > > @@ -1414,6 +1414,9 @@ > > > #textstyle > > > $viewmenu add cascade -label "[trans textsize]" -menu > > > [CreateTextSizeMenu $viewmenu] > > > > > > + #changefont > > > + $viewmenu add command -label "[trans changefont]" > > -command > > > "after 1 change_font [string range $w 1 end] mychatfont" > > > + > > > #---------------------- > > > $viewmenu add separator > > > > > > > > > Index: gui.tcl > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- gui.tcl (revision 8320) > > > +++ gui.tcl (working copy) > > > @@ -3803,7 +3803,7 @@ > > > return > > > } > > > > > > - set selected_font [SelectFont .fontsel -parent $parent -title > > $title > > > -font $initialfont -initialcolor $initialcolor -nosizes 1] > > > + set selected_font [SelectFont .fontsel -parent $parent -title > > $title > > > -font $initialfont -initialcolor $initialcolor] > > > return $selected_font > > > } > > > > > > @@ -3833,6 +3833,7 @@ > > > } > > > > > > set sel_fontfamily [lindex $selfont 0] > > > + set sel_fontsize [lindex $selfont 1] > > > set sel_fontstyle [lrange $selfont 2 end] > > > > > > > > > @@ -3844,7 +3845,7 @@ > > > > > > ::config::setKey $key [list $sel_fontfamily $sel_fontstyle > > > $selcolor] > > > > > > - change_myfontsize [::config::getKey textsize] > > > + change_myfontsize [expr {$sel_fontsize - $basesize} ] > > > } > > > > > > Please let me know if anything :) > > > > > > Thanks, > > > Sakesashimi > > > > > > > > > > > > > > > On 3/21/07, Youness Alaoui < kak...@ka...> wrote: > > > > > > > >Hi sake, > > > >I think your suggestion is good.. adding the size column and keeping > > the > > > >view->text size in the menu, but change > > > >its content from +1, +2, 0, -1, -2 into something more intuitive > > like > > > >"small, smallest, medium, large, largest" > > > >and have them as checkboxes so users can see which one is currently > > > >selected... maybe adding a 'custom' that > > > >owuld open the change font dialog... I would also appreciate seeing = a > > > >'change my font' menu item added... > > > >you don't have to apologize, but I'm sorry for giving you so much > > hassle, > > > >it should have been a simple fix but > > > >now it gets discussed and a lot of back and forth which is probably > > both > > > >our strength (since we discuss things > > > >to make them as good as possible) but also our weakness (we loose > > time and > > > >a developer could loose motivation or > > > >not have time anymore to implement the discussed feature). I think > > it's a > > > >good leson for you : specs should be > > > >highly defined before any implementation occurs ;) > > > >Anyways, the way you should do it is that whenever you send an email > > and > > > >wait for an answer, you should put the > > > >issue 'on hold' and work on something else, it will require you to > > work on > > > >many things in parallel, but this way > > > >you won't waste time waiting on others' input.. and you're lucky thi= s > > > >time, you were able to get answers, > > > >sometimes a mail in the ML could remain unanswered for weeks :p > > > >good luck and keep me informed! > > > >once you get a final diff implemented the things mentionned above, > > send it > > > >to us please... > > > > > > > >summary TODO : > > > >- the "view->text size" menu should show text like "custom > > > >font/smallest/small/medium/large/largest" > > > >- the "view->text size" items should become checkboxes so users can > > see > > > >the current size they chose (only if > > > >time permits) > > > >- the change font dialog should have a 'size' column (already done > > afaik) > > > >- add a "change my font" menu item in the view menu under "text size= " > > to > > > >allow accessibility to changing the > > > >font from the menu, if the buttonbar is hidden > > > > > > > > > > > >Thanks, > > > >KaKaRoTo > > > > > > > >On Wed, Mar 21, 2007 at 01:33:37PM -0800, Sake Sashimi wrote: > > > >> Hi Kakaroto and everyone, > > > >> > > > >> Thanks for the answer. In my opinion, we should leave the menu > > > >> (view->text size) as is. And then add the size column in the > > 'change > > > >font' > > > >> window that pop up when you click the 'A' button on the button > > > >bar. This > > > >> way is more intuitive, and perfectly portraying the original > > request on > > > >the > > > >> bulletin board concerning this feature. It retains the UI of > > original > > > >msn > > > >> plus further enhancement on aMSN. Furthermore, we know that the > > reason > > > >that > > > >> -nosizes was there before is not because the size column is causin= g > > any > > > >bug. > > > >> > > > >> > > > >> Attached is the screenshot of the implementation I was mentioning. > > > >> Previously, there was no 'size column' on the change font window. > > > >> > > > >> This implementation is also carried on the > > Preference->Personal->Change > > > >Font > > > >> button. > > > >> > > > >> If you or the community has other suggestion, please let me > > know. Or > > > >> probably consider this addition as a one a time enchancement :) I > > would > > > >> greatly appreciate if we could have immediate consensus about this= , > > > >since I > > > >> am really racing againts time here :) and need to work on the othe= r > > > >> feature. I am really sorry in advance if it cause you guys to rus= h > > as > > > >> well... please accept my sincere apology... > > > >> > > > >> Warmest regards, > > > >> Sakesashimi > > > >> > > > >> > > > >> > > > >> On 3/21/07, Youness Alaoui < kak...@ka...> > > wrote: > > > >> > > > > >> >Hi Alvaro, > > > >> >thanks for the answer, that's what I thought.. bad UI design from > > msn > > > >:p > > > >> >lool, I just checked and it still is > > "small/smaller/medium/big/bigger" > > > >> >(with 'smaller' selected by default:s) > > > >> >yes, it's not very good I think, so it would be better to just > > remove > > > >it.. > > > >> >I don't know what the UI guys think > > > >> >since I'm not that good with UI design.. > > > >> >I would suggest removing the 'change text size' from the menu and > > > >> >replacing it with 'change their font' and > > > >> >adding above it a 'change my font'.. > > > >> >there's no 'change my font' in the menus, so users with no > > buttonbar > > > >can't > > > >> >change their font.. > > > >> >the menu should have two new menu entries and one less.. > > > >> > > > > >> >KKRT > > > >> > > > > >> >On Wed, Mar 21, 2007 at 06:44:14PM +0100, =C1lvaro J. Iradier wro= te: > > > > > >> >> It was added to mimic the behavior in the MSN Messenger. The > > text > > > >size > > > >> >> was selected from the menu, as "Big, Normal, Small, ..." and > > that was > > > >> >> +1, +0, -1, etc. from the default font. So, choosing a fixed > > size in > > > >> >> the font dialog made no sense for me. > > > >> >> > > > >> >> Anyways, the font size is not sent to the destination (did this > > > >> >> change?), it's just a local display setting. > > > >> >> > > > >> >> Greets. > > > >> >> > > > >> >> On 3/21/07, Youness Alaoui <kak...@ka... > > > wrote: > > > >> >> > Hi, > > > >> >> > thanks for the diff, I looked into the -nosizes option.. it > > was > > > >indeed > > > >> >added on purpose.. > > > >> >> > look here : > > > >> >> > > > http://amsn.svn.sourceforge.net/viewvc/amsn?view=3Drev&revision=3D2208 > > > >> >> > > > > >> >> > Which means that Alvaro added the option on purpose at > > revision > > > >2208, > > > >> >on march 14th 2204 (3 years ago)... there > > > >> >> > was no specific reason specified in the commit log :( > > > >> >> > > > > >> >> > Alvaro, do you know why it would have been added ? I know it'= s > > 3 > > > >years > > > >> >and it's a long time ago, but do you have > > > >> >> > any idea or can remember anything on why you added that optio= n > > ? > > > >was > > > >> >there a specific issue caused by this ? Or > > > >> >> > was it just to avoid the redunduncy from the 'text size' menu > > of > > > >the > > > >> >chat window which was itself a legacy of > > > >> >> > ccmsn ? > > > >> >> > Thanks! > > > >> >> > > > > >> >> > KaKaRoTo > > > >> >> > > > > >> >> > On Tue, Mar 20, 2007 at 10:12:29PM -0400, Sake Sashimi wrote: > > > >> >> > > Hi Kakaroto and everyone, > > > >> >> > > > > > >> >> > > I went ahead and change the way user will choose font size > > from > > > >> >menu->text > > > >> >> > > size as you have suggested. So, instead of +8 +4 ... etc, > > user > > > >will > > > >> >now be > > > >> >> > > able to choose font size, ie: 4,5,6,7,8,9,10...24. I teste= d > > the > > > >> >change and > > > >> >> > > it works properly. > > > >> >> > > > > > >> >> > > I attached the diff file (font_diff.txt) as the email > > > >> >attachment. Sorry, it > > > >> >> > > is because gmail does not allow me to copy paste (really > > weird > > > >> >indeed) :( > > > >> >> > > > > > >> >> > > In font_diff.txt, the first diff on chatwindow.tcl is the > > new > > > >> >implementation > > > >> >> > > on menu->text size that you suggested me to do. > > > >> >> > > > > > >> >> > > The second diff on gui.tcl is the previous implementation I > > did > > > >on > > > >> >adding > > > >> >> > > size column. They are separate. > > > >> >> > > > > > >> >> > > Thanks a lot. I look forward to hearing your feedback :) > > > >> >> > > > > > >> >> > > Regards, > > > >> >> > > Sakesashimi > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > On 3/20/07, Sake Sashimi <ec...@gm...> wrote: > > > >> >> > > > > > > >> >> > > >Hi Kakaroto, > > > >> >> > > > > > > >> >> > > >Thanks for your reply. I was previously thinking that the > > size > > > >> >column was > > > >> >> > > >not there because amsn already has the menu entry to > > increase or > > > >> >decrease > > > >> >> > > >the text size. Therefore, with this in mind, the person > > who > > > >> >> > > >implemented the Change Font window purposedly left out the > > size > > > >> >column > > > >> >> > > > > > > >> >> > > >From what I understood from the forum thread, the one > > requesting > > > >> >the > > > >> >> > > >feature was asking if amsn could have a window with all > > three > > > >> >options (to > > > >> >> > > >change font name, size and style) similar to the window on > > > >> >> > > >Preference->Appearance->Change Font on the chat window and > > on > > > >> >> > > >Preference->Personal->Change Fonts buttons. Right now, if > > user > > > >> >click the > > > >> >> > > >'A' button on chat windows, a new windows showing what was > > > >> >requested > > > >> >> > > >appears > > > >> >> > > >and user will be able to change all three parameters from > > that > > > >one > > > >> >window. > > > >> >> > > > > > > >> >> > > >"maybe the whole 'text size' menu could be removed and jus= t > > add > > > >a > > > >> >single > > > >> >> > > >menu entry to change the font > > > >> >> > > >of how you see user's text, so they get it all in one > > window > > > >(the > > > >> >same > > > >> >> > > >button is in the prefs window)" > > > >> >> > > > > > > >> >> > > >From your quote above, I think the current code i submitte= d > > > >> >implemented > > > >> >> > > >that. However, you might probably be right if the person > > who > > > >first > > > >> >> > > >implemented this window purposedly left out the size colum= n > > > >because > > > >> >of > > > >> >> > > >something. Therefore, I will wait for more information > > from you > > > >:) > > > >> >> > > > > > > >> >> > > >Meanwhile, I'll do as you suggested, modifying the menu > > entry to > > > >> >show font > > > >> >> > > >sizes instead of just +1 +2 ... etc... Thanks... > > > >> >> > > > > > > >> >> > > >Regards, > > > >> >> > > >sakesashimi > > > >> >> > > > > > > >> >> > > > > > > >> >> > > > > > > >> >> > > >On 3/20/07, Youness Alaoui <kak...@ka...= t > > > > > > >wrote: > > > >> >> > > >> > > > >> >> > > >> Hi Sake, > > > >> >> > > >> Like vivia said, the best way to send a patch is to save > > your > > > >> >work, do a > > > >> >> > > >> 'svn update', then 'svn diff', and send > > > >> >> > > >> us the diff result... > > > >> >> > > >> Now, I'm sorry but I don't understand what you did... > > with > > > >this > > > >> >fix... > > > >> >> > > >> it has nothing to do with what was > > > >> >> > > >> asked... Maybe you forgot to send the diff for the > > > >> >chatwindow.tclfile > > > >> >> > > >> or something.. or maybe you > > > >> >> > > >> misunderstood.. > > > >> >> > > >> humm.. ok, I just reread the forum thread and you're > > right, > > > >I'm > > > >> >the one > > > >> >> > > >> who misunderstood.. I was actually > > > >> >> > > >> refering to the line in the post that says : > > > >> >> > > >> "The menu view->text size, isn't user friendly" > > > >> >> > > >> referring to the menu of the chatwindow, wich is why I > > told > > > >you > > > >> >to look > > > >> >> > > >> at the CreateTextSizeMenu in > > > >> >> > > >> chatwindow.tcl... > > > >> >> > > >> Now I understand your diff a bit better.. but I' masking > > > >myself, > > > >> >why the > > > >> >> > > >> -nosizes 1 was put there in the first > > > >> >> > > >> place ? that's what you should ask yourself.. see who > > added it > > > >> >and when > > > >> >> > > >> and for what reason, maybe the sizes > > > >> >> > > >> column caused a bug or something.. I'll try to find that > > > >answer > > > >> >for you, > > > >> >> > > >> in the meantime, you could try changing > > > >> >> > > >> the chat window's menus so it could be more user friendl= y > > (now > > > >> >it's +1, > > > >> >> > > >> +2, etc.. maybe font sizes would be > > > >> >> > > >> better).. maybe the whole 'text size' menu could be > > removed > > > >and > > > >> >just add > > > >> >> > > >> a single menu entry to change the font > > > >> >> > > >> of how you see user's text, so they get it all in one > > window > > > >(the > > > >> >same > > > >> >> > > >> button is in the prefs window) > > > >> >> > > >> > > > >> >> > > >> KaKaRoTo > > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> On Tue, Mar 20, 2007 at 02:20:32AM -0400, Sake Sashimi > > wrote: > > > >> >> > > >> > Hi Kakaroto, > > > >> >> > > >> > > > > >> >> > > >> > I manage to finish the first TODO (better usable menu > > > >options > > > >> >for > > > >> >> > > >> changing > > > >> >> > > >> > text size) > > > >> >> > > >> > > > > >> >> > > >> > http://www.amsn-project.net/forums/viewtopic.php?t=3D2= 827- > > > >> >better > > > >> >> > > >> usable menu > > > >> >> > > >> > options for the change text size... > > > >> >> > > >> > > > > >> >> > > >> > Basically, I modified gui.tcl file within choose_font > > and > > > >> >change_font > > > >> >> > > >> > procs. Right now, if user click the 'change font' > > button in > > > >> >the chat > > > >> >> > > >> > window, and also the two 'change buttons' in > > > >> >Preference->Appearance, a > > > >> >> > > >> > change font window with additional font size list > > column > > > >will > > > >> >> > > >> appear. User > > > >> >> > > >> > can change text size by selecting the size number on > > the > > > >> >list. The > > > >> >> > > >> change > > > >> >> > > >> > will be persistent. > > > >> >> > > >> > > > > >> >> > > >> > I have tested it thoroughly, and it works > > consistently. The > > > >> >only > > > >> >> > > >> thing is > > > >> >> > > >> > that, if you ever notice, some fonts have a range size= s > > in > > > >> >which if > > > >> >> > > >> you > > > >> >> > > >> > change the size within that range, the size of the fon= t > > does > > > >> >not > > > >> >> > > >> change (for > > > >> >> > > >> > example: for font 'times', size between 19 to 22 does > > not > > > >> >actually > > > >> >> > > >> change > > > >> >> > > >> > the size of the font, ie: size 19 to 22 is the same > > size for > > > >> >font > > > >> >> > > >> 'times'). > > > >> >> > > >> > I am sure this is not amsn issue. it probably tcl > > issue. > > > >> >> > > >> > > > > >> >> > > >> > I am not too familiar about the process of submitting > > the > > > >> >code. I > > > >> >> > > >> attached > > > >> >> > > >> > the file that I modified in this email. I hope my > > change is > > > >> >> > > >> acceptable :) > > > >> >> > > >> > Please let me know if there is a specific way to send > > fixes. > > > >> >> > > >> > > > > >> >> > > >> > Thank you, > > > >> >> > > >> > sakesashimi > > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> > > > > >> >> > > >> > > > >> > > > > > >>---------------------------------------------------------------------= ---- > > > >> >> > > >> > Take Surveys. Earn Cash. Influence the Future of IT > > > >> >> > > >> > Join SourceForge.net 's Techsay panel and you'll get > > the > > > >chance > > > >> >to > > > >> >> > > >> share your > > > >> >> > > >> > opinions on IT & business topics through brief > > surveys-and > > > >earn > > > >> >cash > > > >> >> > > >> > > > > >> >> > > >> > > > >> > > > > >http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&C= ID=3DDEVDEV > > > >> >> > > >> > _______________________________________________ > > > >> >> > > >> > Amsn-devel mailing list > > > >> >> > > >> > Ams...@li... > > > >> >> > > >> > https://lists.sourceforge.net/lists/listinfo/amsn-deve= l > > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> > > > >> > > > > > >>---------------------------------------------------------------------= ---- > > > >> >> > > >> > > > >> >> > > >> Take Surveys. Earn Cash. Influence the Future of IT > > > >> >> > > >> Join SourceForge.net's Techsay panel and you'll get the > > chance > > > >to > > > >> >share > > > >> >> > > >> your > > > >> >> > > >> opinions on IT & business topics through brief > > surveys-and > > > >earn > > > >> >cash > > > >> >> > > >> > > > >> >> > > >> > > > >> > > > > >http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&C= ID=3DDEVDEV > > > >> >> > > >> _______________________________________________ > > > >> >> > > >> Amsn-devel mailing list > > > >> >> > > >> Ams...@li... > > > >> >> > > >> https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > >> >> > > >> > > > >> >> > > > > > > >> >> > > > > > > >> >> > > > > >> >> > > Index: chatwindow.tcl > > > >> >> > > > > > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > >> >> > > --- chatwindow.tcl (revision 8265) > > > >> >> > > +++ chatwindow.tcl (working copy) > > > >> >> > > @@ -1436,15 +1436,13 @@ > > > >> >> > > # of the chat window > > > >> >> > > # > > > >> >> > > proc CreateTextSizeMenu { menu } { > > > >> >> > > + set basesize [lindex [::config::getGlobalKey > > > >basefont] > > > >> >1] > > > >> >> > > set textsizemenu $menu.textsize > > > >> >> > > menu $textsizemenu -tearoff 0 -type normal > > > >> >> > > > > > >> >> > > - foreach size {" 8" " 6" " 4" " 2" " 1" " 0" > > " -2" > > > >" > > > >> >-4" } { > > > >> >> > > - if {$size > 0 } { > > > >> >> > > - $textsizemenu add command > > -label > > > >> >"+$size" -command "change_myfontsize $size" > > > >> >> > > - } else { > > > >> >> > > - $textsizemenu add command > > -label > > > >> >"$size" -command "change_myfontsize $size" > > > >> >> > > - } > > > >> >> > > + foreach size {" 4" " 5" " 6" " 7" " 8" " 9" > > "10" > > > >"11" > > > >> >"12" "13" "14" "15" "16" "17" "18" "19" "20" "21" "22" "23" "24" = } > > { > > > >> >> > > + $textsizemenu add command -label > > "$size" > > > >> >-command "change_myfontsize [expr {$size - $basesize} ]" > > > >> >> > > + > > > >> >> > > } > > > >> >> > > > > > >> >> > > return $textsizemenu > > > >> >> > > Index: gui.tcl > > > >> >> > > > > > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > >> >> > > --- gui.tcl (revision 8265) > > > >> >> > > +++ gui.tcl (working copy) > > > >> >> > > @@ -3789,7 +3789,7 @@ > > > >> >> > > return > > > >> >> > > } > > > >> >> > > > > > >> >> > > - set selected_font [SelectFont .fontsel -parent $paren= t > > > > > >-title > > > >> >$title -font $initialfont -initialcolor $initialcolor -nosizes 1] > > > >> >> > > + set selected_font [SelectFont .fontsel -parent $paren= t > > > >-title > > > >> >$title -font $initialfont -initialcolor $initialcolor] > > > >> >> > > return $selected_font > > > >> >> > > } > > > >> >> > > > > > >> >> > > @@ -3803,7 +3803,8 @@ > > > >> >> > > > > > >> >> > > #Get current font configuration > > > >> >> > > set fontname [lindex [::config::getKey $key] 0] > > > >> >> > > - set fontsize [expr {$basesize + [::config::getKey > > > >textsize]}] > > > >> >> > > + set fontsize [expr {$basesize + [::config::getKey > > textsize] > > > >} > > > >> >] > > > >> >> > > + > > > >> >> > > set fontstyle [lindex [::config::getKey $key] 1] > > > >> >> > > set fontcolor [lindex [::config::getKey $key] 2] > > > >> >> > > > > > >> >> > > @@ -3819,6 +3820,7 @@ > > > >> >> > > } > > > >> >> > > > > > >> >> > > set sel_fontfamily [lindex $selfont 0] > > > >> >> > > + set sel_fontsize [lindex $selfont 1] > > > >> >> > > set sel_fontstyle [lrange $selfont 2 end] > > > >> >> > > > > > >> >> > > > > > >> >> > > @@ -3830,7 +3832,7 @@ > > > >> >> > > > > > >> >> > > ::config::setKey $key [list $sel_fontfamily > > $sel_fontstyle > > > >> >$selcolor] > > > >> >> > > > > > >> >> > > - change_myfontsize [::config::getKey textsize] > > > >> >> > > + change_myfontsize [expr {$sel_fontsize - $basesize} ] > > > >> >> > > } > > > >> >> > > > > >> > > > >>> > > > > > >#/////////////////////////////////////////////////////////////////////= // > > > >> >> > > > > > >> >> > > > > >> >> > > > > > >> > > > > > >>---------------------------------------------------------------------= ---- > > > >> >> > > Take Surveys. Earn Cash. Influence the Future of IT > > > >> >> > > Join SourceForge.net's Techsay panel and you'll get the > > chance to > > > >> >share your > > > >> >> > > opinions on IT & business topics through brief surveys-and > > earn > > > >cash > > > >> >> > > > > > >> > > > > >http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&C= ID=3DDEVDEV > > > > > >> >> > > _______________________________________________ > > > >> >> > > Amsn-devel mailing list > > > >> >> > > Ams...@li... > > > >> >> > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > >> >> > > > > >> >> > > > > >> >> > > > > >> > > > > > >>---------------------------------------------------------------------= ---- > > > >> >> > Take Surveys. Earn Cash. Influence the Future of IT > > > >> >> > Join SourceForge.net's Techsay panel and you'll get the chanc= e > > to > > > >> >share your > > > >> >> > opinions on IT & business topics through brief surveys-and > > earn > > > >cash > > > >> >> > > > > >> > > > > >http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&C= ID=3DDEVDEV > > > > > >> >> > _______________________________________________ > > > >> >> > Amsn-devel mailing list > > > >> >> > Ams...@li... > > > >> >> > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > >> >> > > > > >> >> > > > >> >> > > > >> >> -- > > > >> >> (:=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D:) > > > >> >> Alvaro J. Iradier Muro - air...@gm... > > > >> >> > > > >> >> > > > >> > > > > > >>---------------------------------------------------------------------= ---- > > > >> >> Take Surveys. Earn Cash. Influence the Future of IT > > > >> >> Join SourceForge.net's Techsay panel and you'll get the chance > > to > > > >share > > > >> >your > > > >> >> opinions on IT & business topics through brief surveys-and earn > > cash > > > >> >> > > > >> > > > > >http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&C= ID=3DDEVDEV > > > > > >> >> _______________________________________________ > > > >> >> Amsn-devel mailing list > > > >> >> Ams...@li... > > > >> >> https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > >> > > > > >> > > > > > >>---------------------------------------------------------------------= ---- > > > >> >Take Surveys. Earn Cash. Influence the Future of IT > > > >> >Join SourceForge.net's Techsay panel and you'll get the chance to > > share > > > >> >your > > > >> >opinions on IT & business topics through brief surveys-and earn > > cash > > > >> > > > > > > > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID= =3DDEVDEV > > > >> >_______________________________________________ > > > >> >Amsn-devel mailing list > > > >> >Ams...@li... > > > >> > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > >> > > > > > > > > > > > > >> > > > > > >----------------------------------------------------------------------= --- > > > >> Take Surveys. Earn Cash. Influence the Future of IT > > > >> Join SourceForge.net's Techsay panel and you'll get the chance to > > share > > > >your > > > >> opinions on IT & business topics through brief surveys-and earn > > cash > > > >> > > > > > > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID= =3DDEVDEV > > > >> _______________________________________________ > > > >> Amsn-devel mailing list > > > >> Ams...@li... > > > >> https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > > > > > > > > > > >----------------------------------------------------------------------= --- > > > >Take Surveys. Earn Cash. Influence the Future of IT > > > >Join SourceForge.net's Techsay panel and you'll get the chance to > > share > > > >your > > > >opinions on IT & business topics through brief surveys-and earn cash > > > >http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&C= ID=3DDEVDEV > > > >_______________________________________________ > > > >Amsn-devel mailing list > > > > Ams...@li... > > > >https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > > > > > > > > -----------------------------------------------------------------------= -- > > > Take Surveys. Earn Cash. Influence the Future of IT > > > Join SourceForge.net's Techsay panel and you'll get the chance to > > share your > > > opinions on IT & business topics through brief surveys-and earn cash > > > > > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID= =3DDEVDEV > > > _______________________________________________ > > > Amsn-devel mailing list > > > Ams...@li... > > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > > > > > -----------------------------------------------------------------------= -- > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share > > your > > opinions on IT & business topics through brief surveys-and earn cash > > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID= =3DDEVDEV > > > > _______________________________________________ > > Amsn-devel mailing list > > Ams...@li... > > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > > > |