[Althea-devel] Fixed crash in on_check_mail_menu_activate().

[Steven A. <steve@Augart.com>]

I fixed a crash in on_check_mail_menu_activate() that happens if we
try to check for mail when there's a server selected with a
zero-length folder list.

I also cleaned up dead code (looked alive, but could never actually be
executed!) in that function; rewrote it so that each error condition
is tested and griped about in exactly one place.


It also includes a minor enhancement in the error messages.  
When there is no server available (because none has been set up yet),
on_check_mail_menu_activate will now give the better error message:
   "Go to Althea ==> Setup... and define a server."
instead of the confusing:
    "Select a server first."

I've uploaded this patch to sourceforge.net.

--Steve Augart