#9 Core dump when port number is incorrect

closed-fixed
Daler
6
2001-10-19
2001-05-18
Anonymous
No

IMAPLogin() will cause a core dump when the port is
wrong and
probably when the host is wrong too. MakeConnection()
calls
connect which fails and MakeConnection() returns null.
Then
readTilEOL is called with a NULL.

I used this:
/* connect to port "port" on "host" */
if ((the_connection = MakeConnection(
host.c_str(), port, usessl )) == NULL)
return SERVER_NOT_READY_FOR_CONNECTION;

Instead of putting the port number in the server
config, it seems like it would be better to look it up
based on the usessl flag. Of course having the port is
nice if a forwarding mechanism is in place.

Discussion

  • Daler
    Daler
    2001-05-30

    • priority: 5 --> 6
    • assigned_to: nobody --> mulvihiw
    • status: open --> open-accepted
     
  • Daler
    Daler
    2001-05-30

    Logged In: YES
    user_id=99089

    I have verified the bug. However, the solution you
    presented is not exactly what we want. I'm trying to figure
    out the best way to do this. I need to look back at it.
    But I agree that this needs fixed and that in general, the
    configuration should be more fault-tolerant (at least to the
    point of identifying why it isn't working.

    In thinking about using the usessl flag to configure the
    port, I know we definitely do not want to do that for the
    user automagically. But it might actually help if we did
    something like this:
    When configuring your server in the configuration window,
    whenever you toggle the UseSSL checkbox, it will switch the
    port to the default for IMAP(143) or IMAPSSL (993). I'll
    have to think about the possibility of this but I think
    there is some way we can make this less confusing.
    I'll update this bug whenever I've got a fix for it. Thanks
    for your input!

     
  • Ethan Sommer
    Ethan Sommer
    2001-10-19

    • status: open-accepted --> closed-fixed