#5978 guess_repo too slow on Allura repo

forge-apr-05
closed
Cory Johns
General
2
2013-03-29
2013-03-18
Dave Brondsema
No

https://sourceforge.net/p/allura/pastebin/514771f57929e5773688e6e4

Probably could cache the first result, and make it a bit smarter too (e.g. can we instantiate only scm apps?)

Related

Tickets: #6031

Discussion

  • Cory Johns
    Cory Johns
    2013-03-26

    allura:cj/5978

    It turns out that guess_repo is already cached in the two places it's called, and I didn't want to hard-code tool-names to identify SCM apps (we probably need some way to identify "types" of tools).

    However, guess_repo shouldn't have been being called at all, so I fixed that (missing call to set_context) so it should be much faster now.

    To test, view any SCM tree with stats logging enabled (1) and see that guess_repo no longer shows up in the stats.

     
  • Dave Brondsema
    Dave Brondsema
    2013-03-28

    Couldn't duplicate guess_repo being called on a tree view, but it is called a lot on a log view.

     
  • Cory Johns
    Cory Johns
    2013-03-28

    Fix for History view and logging any other calls pushed.

     


Anonymous


Cancel   Add attachments