Apache Allura / Chat

Apache Allura / Chat is hosted on FreeNode IRC channel #allura

Log for 2013-11-08

  • 14:34:36
    ctsai-sf

    The new markdown caching stuff doesn't appear to be working properly for wiki.

  • 14:35:04
    ctsai-sf

    It displays fine immediately after save, but not after subsequent refreshes.

  • 14:37:01
    brondsem

    yeah, certainly looks wrong :(

  • 14:37:39
    tvansteenburgh

    i can look into that

  • 14:40:18
    ctsai-sf

    Cool, thanks.

  • 15:01:31
    tvansteenburgh

    well so far i have no idea

  • 15:01:46
    ctsai-sf

    Sounds fun.

  • 15:01:55
    tvansteenburgh

    the same text on a sandbox renders properly

  • 15:02:56
    tvansteenburgh

    i don't see anything that explains this

  • 15:03:24
    tvansteenburgh

    page.html_text doesn't get passed through the | safe filter, but it didn't before either

  • 15:05:16
    brondsem

    locally is it getting cached? same text may render at different speed

  • 15:06:03
    tvansteenburgh

    yeah i have my local set to always cache

  • 15:13:13
    cory_fu

    Have you compared the cached value in prod vs local?

  • 15:13:27
    cory_fu

    Is it somehow caching something different in one env?

  • 15:14:34
    brondsem
  • 15:14:41
    brondsem

    i was just looking at that anyway

  • 15:16:59
    brondsem

    does markdown_wiki.convert return a MarkupSafe object and markdown_wiki.cached_convert does not?

  • 15:18:13
    tvansteenburgh

    cached_convert calls convert, so i wouldn't think that'd be possible

  • 15:18:48
    tvansteenburgh

    um

  • 15:18:50
    brondsem

    unless it's pulling it from the db

  • 15:19:05
    tvansteenburgh

    on my sandbox this is not in fact being cached

  • 15:20:55
    brondsem

    aha

  • 15:21:08
    tvansteenburgh

    and i'm not sure why :P

  • 15:23:05
    brondsem

    how are you allegedly setting it to always cache?

  • 15:23:24
    tvansteenburgh

    markdown_cache_threshhold = 0

  • 15:23:40
    brondsem

    s/threshhold/threshold/

  • 15:23:47
    tvansteenburgh

    omg

  • 15:23:53
    tvansteenburgh

    nice one, thanks

  • 15:23:53
    brondsem

    :)

  • 15:24:48
    tvansteenburgh

    ok, repro++

  • 15:25:05
    tvansteenburgh

    first view renders properly, after that it's raw html

  • 15:28:03
    tvansteenburgh

    h.html.literal(text)

  • 15:28:10
    tvansteenburgh

    perhaps this is the missing ingredient

  • 15:28:26
    brondsem

    ACTION is making a ticket for this

  • 15:29:16
    brondsem
  • 15:36:32
    brondsem

    +1, with a test

  • 15:37:00
    brondsem

    was reading docs and looks like webhelpers' html.literal uses a markupsafe.Markup class

  • 15:45:57
    cory_fu

    I asume everyone saw Marvin's thread on the incubator-general list?

  • 15:46:22
    cory_fu

    Seems like it would be good for one or more of us to chime in as well.

  • 15:46:56
    brondsem

    yeah, very interesting thread

  • 15:49:03
    brondsem

    i'm not sure yet exactly what I want to say

  • 15:55:49
    cory_fu

    Yeah, nor I

  • 15:56:11
    cory_fu

    Also, what do we have to do to get the Allura wikipedia page moving. grr. :-p

  • 15:56:56
    brondsem

    i think just wait..

  • 15:57:23
    brondsem
  • 16:08:54
    cory_fu

    Hrm. This seems like something that would really benefit from a functional test

  • 16:09:18
    cory_fu

    Confirm that the actual rendered HTML is correct

  • 16:09:42
    brondsem

    yeah, probably

  • 16:09:48
    tvansteenburgh

    i hate you guys

  • 16:09:51
    cory_fu

    lol

  • 16:10:02
    brondsem

    or at least assert that it's a Markup class, since literal extends from Markup and Markup is what we use more often

  • 16:11:37
    brondsem

    functional test should be too hard it seems, create a WikiPage instance and save it, forcing caching, then request the URL

  • 16:12:49
    cory_fu

    Your Freudian slip is showing. *shouldn't

  • 16:17:12
    tvansteenburgh

    i'mjust here to do your bidding guys

  • 16:47:29
    tvansteenburgh

    [#6859] is up for review

  • 17:51:39
    Humbedooh

    brondsem et al: I chimed in on the release vote :)

  • 18:40:18
    cory_fu

    Humbedooh: What would it take to sway you? Fixing that (and a few other) reference(s) would require updating the release artifact and there have been quite a few other changes since then. Do you think the SF reference is worth such a significant update?

  • 18:43:02
    Humbedooh

    cory_fu: if I were that anally retentive, I would have said -1 and not +0.9 ;)

  • 18:43:12
    cory_fu

    :-)

  • 18:43:32
    cory_fu

    So, what are we missing for that last 10%?

  • 18:43:54
    Humbedooh

    well, mostly just me agreeing with myself that this isn't a big issue and changing it to a +1

  • 18:44:00
    Humbedooh

    which will probably happen sometime during today

  • 18:44:22
    cory_fu

    Ok. I'm writing up a ticket as we speak to fix those references

  • 18:45:20
    brondsem

    we've got one alraedy

  • 18:45:48
    brondsem
  • 18:46:35
    cory_fu

    I figured we might

  • 18:55:13
    Humbedooh

    so, there's rich and me voting for it, anybody else?

  • 18:56:23
    brondsem

    Jim voted on the ppmc list

  • 18:56:34
    brondsem

    Not 100% sure if that counts or not

  • 18:58:39
    Humbedooh

    let's call it a documentation bug and proceed ;)

  • 18:58:45
    Humbedooh

    +1!

  • 18:58:56
    Humbedooh

    (posted on ML for sake of archives)

  • 19:01:53
    Humbedooh

    I think the incubator rules require the 3x+1 to be in the vote thread in general@, so best to ping jim and get him to recast his +1

  • 19:02:39
    brondsem

    k

  • 19:02:47
    Humbedooh

    just ping him on irc, I suppose :)

  • 19:06:02
    Humbedooh

    pfft, marvin and his records

  • 19:51:34
    cory_fu

    We recently had an issue with the guess_mime_type logic failing because of a lack of file extension, did we not? What was the resolution to that?

  • 19:52:17
    brondsem

    it was a typo in the importer

  • 19:52:43
    brondsem

    iirc guess_mime_type handles that situation ok

  • 19:53:02
    brondsem

    returns a binary mime type

  • 20:10:51
    brondsem

    might be nice to switch allura-vm from a cron git pull to http://www.apache.org/dev/gitpubsub.html some day

  • 20:16:28
    brondsem

    tvansteenburgh: I think we need a repo_refresh call in logic we do have now

  • 20:18:14
    tvansteenburgh

    the cron ends with curl -L http://forge-allura.apache.org/p/allura/git/refresh;

  • 20:18:19
    tvansteenburgh

    do we need something else?

  • 20:19:10
    brondsem

    hm

  • 20:19:15
    brondsem

    is taskd running?

  • 20:19:23
    brondsem

    i tried manually submitting a refresh too

  • 20:19:30
    brondsem

    but nothing showing up on our repo browser yet

  • 20:19:38
    tvansteenburgh

    allura@allura-vm:/var/local$ service reactor status

  • 20:19:39
    tvansteenburgh

    Taskd NORMAL.1 (#1) is stopped

  • 20:19:39
    tvansteenburgh

    Taskd NORMAL.2 (#2) is stopped

  • 20:19:40
    tvansteenburgh

    :(

  • 20:19:45
    tvansteenburgh

    not sure why...

  • 20:20:04
    brondsem

    you're using the same watch & restart scripts as we do on SF sandboxes?

  • 20:20:17
    tvansteenburgh

    well i had to modify them, but yeah

  • 20:20:23
    brondsem

    same thing happens there

  • 20:20:37
    brondsem

    too many restart signals sent to the process right in a row

  • 20:20:57
    brondsem

    so some hit a newly-restarted proc that doesn't have signal handling set up yet, and it dies

  • 20:20:57
    tvansteenburgh

    what causes that?

  • 20:21:17
    brondsem

    inotify sees multiple changes

  • 20:21:21
    tvansteenburgh

    ah

  • 20:21:42
    brondsem

    i don't know what the proper fix is

  • 20:21:51
    brondsem

    probably rewrite the watching script in python instead of bash, so it can be smarter

  • 20:22:23
    brondsem

    or cron job to start reactor service every 5 min?

  • 20:22:28
    tvansteenburgh

    man you need to get root asap

  • 20:22:43
    tvansteenburgh

    cron would be my hack

  • 20:23:18
    tvansteenburgh

    i toss that at the end of the current 5min cron entry

  • 20:23:24
    tvansteenburgh

    i could

  • 20:23:30
    brondsem

    yeah, i haven't tried to get root for a while

  • 20:23:38
    brondsem

    but we def. need more than just you doing this stuff

  • 20:23:45
    brondsem

    +1 for now

  • 20:24:48
    tvansteenburgh

    especially since i rarely know what i'm doing

  • 20:24:52
    tvansteenburgh

    ok, cron updated

  • 20:24:55
    brondsem

    ha

  • 20:28:54
    brondsem
  • 20:29:18
    brondsem

    this is to fix an issue in recently-merged code that changed To headers in outgoing email

  • 20:30:08
    tvansteenburgh

    was just looking at that, lgtm

  • 20:30:29
    brondsem

    coo

  • 20:31:15
    tvansteenburgh

    i thought i knew how to fix the cc thing too, but i think the sandbox forwarding is messing with the smtp envelope to

  • 20:31:22
    tvansteenburgh

    at least i assume that's how it works

  • 20:31:37
    brondsem

    make sure you have valid email addresses

  • 20:31:46
    brondsem

    some of our sample data is foo@localhost which exim might not like

  • 20:42:05
    cory_fu

    brondsem: Just to be clear, [#6845] is going to open up at least those two ref styles (rXXX and issue XXX) styles in general markdown usage, and unless there's an objection, I'm going to open up the other Trac styles as well.

  • 20:42:42
    brondsem

    would we want to consider handling those links during import?

  • 20:42:46
    brondsem

    like we do for trac import

  • 20:42:55
    cory_fu

    We don't for trac

  • 20:42:55
    brondsem

    not sure how that fits in to the way we import that GC content

  • 20:43:08
    brondsem

    right, we get html links

  • 20:43:19
    brondsem

    do we have the html content when importing GC?

  • 20:43:19
    cory_fu

    Ah, hrm

  • 20:43:26
    cory_fu

    Yes

  • 20:43:27
    cory_fu

    Only

  • 20:43:43
    cory_fu

    So, it's a different issue, actually

  • 20:43:53
    brondsem

    i'd probably lean that way, leverage the remote site's cross-linking by just taking their links. and keep our core parsing/rendering cleaner

  • 20:45:01
    cory_fu

    With [#6140], our markdown already supports the rXXX style at least, but it's just currently limited to commit messages. But there was a TBD on that ticket to open it up to general use

  • 20:45:32
    brondsem

    yeah

  • 20:45:36
    cory_fu

    tvansteenburgh did a good job with making a clean implementation for it, and it would be easy to extend to the issue XXX style as well

  • 20:45:48
    brondsem

    'issue NNN' would be pretty broad though

  • 20:46:02
    cory_fu

    Yeah, possibly

  • 20:46:10
    brondsem

    i'm just hesitant to complicate our core markdown rendering any more than necessary :)

  • 20:46:22
    brondsem

    it's already a beast

  • 20:46:29
    cory_fu

    One more relatively simple regex isn't going to complicate things

  • 20:46:40
    tvansteenburgh

    fight fight fight!

  • 20:46:43
    cory_fu

    lol

  • 20:46:59
    cory_fu

    I'm not vested, I just think you're misapprehending how easy it would be to add support for that

  • 20:47:12
    cory_fu

    Only concern is that it might match a bit more often than intended

  • 20:47:50
    brondsem

    regex would be context aware so it doesn't run in a code block, literal, [some other link] etc?

  • 20:49:21
    cory_fu

    Hrm. I guess they're currently done as a preprocessor so they would have that problem, now that I look at it again

  • 20:49:47
    brondsem

    i know you can hook into the right stages of markdown, but it takes some work to get the right one, and also make sure there aren't any conflicts with other processors using that stage

  • 20:51:00
    cory_fu

    Yeah, ok. I was thinking I'd have to do it anyway and that it would just be a case of including the patterns that tvansteenburgh added, but I see that it's not going to be quite that easy and won't solve the issue from the ticket anyway