Apache Allura / Chat

Apache Allura / Chat is hosted on FreeNode IRC channel #allura

Log for 2013-10-15

  • 14:19:42
    rokuingh

    brondsem, hi, we've just resubmitted the import, can you see it now?

  • 14:23:19
    brondsem

    rokuingh: i'm still not seeing any

  • 14:23:43
    brondsem

    our upload limit was increased, but i'll admit I didn't test it since I didn't have a large import available

  • 14:24:06
    brondsem

    seems like we need to test it more ourselves and get back to you again

  • 14:29:32
    rokuingh

    ok, let me know if I can help.. you could use this file for testing if you'd like

  • 14:29:56
    brondsem

    sure, that would help

  • 14:33:36
    rokuingh

    ok, just sent it off, good luck!

  • 15:39:55
    tvansteenburgh

    +1

  • 15:41:17
    ASFBot

    Allura/379: #379 started building, estimated 12 minutes left. https://builds.apache.org/job/allura/379/

  • 15:52:18
    ASFBot

    Allura/379: #379 built successfully after 11 minutes https://builds.apache.org/job/allura/379/

  • 18:06:51
    brondsem

    during testing of the 1.0.1 release, I found that ForgeImporter tests depend on svn & git. https://sourceforge.net/p/allura/pastebin/525d841d0910d40b9b7f91a8 makes it a little better

  • 18:07:44
    brondsem

    also makes it not hit google code urls

  • 18:13:56
    cory_fu

    Much better

  • 18:47:00
    ASFBot

    Allura/380: #380 started building, estimated 11 minutes left. https://builds.apache.org/job/allura/380/

  • 19:00:07
    ASFBot

    Allura/380: #380 built successfully after 12 minutes https://builds.apache.org/job/allura/380/

  • 19:32:03
    brondsem

    so our Google Code wiki importer ends up in a bit of a funny state if there's no default wiki page specified on the GC side

  • 19:32:11
    brondsem

    on GC, clicking wiki brings you to a list of the pages

  • 19:32:41
    brondsem

    on allura, after an import, "Home" is still set as the default page, so you just get the default Home page. You have to click on "Browse Pages" to realize that the import actually did happen

  • 19:33:46
    cory_fu

    I don't think we can really set Browse as the default page, though

  • 19:34:00
    brondsem

    just tried it

  • 19:34:03
    brondsem

    "browse_pages" works

  • 19:34:05
    brondsem

    :)

  • 19:34:20
    cory_fu

    Oh

  • 19:34:23
    cory_fu

    Well then

  • 19:34:24
    cory_fu

    Easy fix

  • 19:34:31
    brondsem

    yep

  • 19:39:44
    brondsem

    weird, that makes browse_pages show up in the list of pages

  • 20:05:45
    brondsem

    included that and a few more things, after a test with the SF community mgr, in https://sourceforge.net/p/allura/tickets/6759/

  • 20:05:59
    cory_fu

    Shoot. I replied from the wrong email account on the release VOTE thread. Hope everyone sees it

  • 20:32:40
    cory_fu

    tvansteenburgh: In #6735, for the common case of not needing to cache, would it be worth avoiding calculating the md5 by checking for cache.md5 is None and delaying calling md5() until after we know it's over the threshold?

  • 20:32:56
    cory_fu
  • 20:46:54
    tvansteenburgh

    cory_fu, you make me cry

  • 20:47:25
    tvansteenburgh

    of course it's not worth it

  • 20:47:34
    brondsem

    lol

  • 20:47:37
    cory_fu

    Just thinking that we should try to minimize impact on the non-caching case.

  • 20:47:48
    cory_fu

    I know md5 isn't terribly expensive to compute, but it does cost something

  • 20:47:57
    tvansteenburgh

    yeah, let me see what i can do

  • 20:52:05
    ASFBot

    Allura/381: #381 started building, estimated 11 minutes left. https://builds.apache.org/job/allura/381/

  • 20:52:07
    ASFBot

    dbrondsema: Rename README -> INSTALL

  • 20:52:12
    ASFBot

    dbrondsema: Update INSTALL to reference other ways of installing (vagrant, non-ubuntu, release tarball)

  • 20:52:12
    ASFBot

    dbrondsema: Add simple README

  • 20:52:19
    ASFBot

    cjohns: Added DISCLAIMER for ASF Incubation

  • 20:52:34
    ASFBot

    cjohns: Fixed ASF release script VOTE thread template not showing and including info for incubator-general posting instead of just allura-dev

  • 20:52:35
    ASFBot

    cjohns: CHANGES updated for ASF release 1.0.1

  • 21:01:07
    ASFBot

    Allura/381: #381 built successfully after 8 minutes https://builds.apache.org/job/allura/381/

  • 21:05:38
    tvansteenburgh

    it's uglier, that's for sure

  • 21:05:44
    tvansteenburgh

    but the tests all pass

  • 21:06:34
    tvansteenburgh

    let me know if you want me to commit it

  • 21:06:59
    cory_fu

    1 sec

  • 21:08:17
    brondsem

    seems like you could make that a 2-branch if instead of 3-part

  • 21:08:33
    brondsem

    if cache.md5 is not None and cache.md5 == ....

  • 21:08:37
    tvansteenburgh

    not if you want to avoid the md5 call :/

  • 21:08:53
    brondsem

    won't it short circuit?

  • 21:09:05
    cory_fu

    Yeah, it will

  • 21:09:18
    cory_fu

    But we should also be able to avoid calling md5 twice

  • 21:11:27
    tvansteenburgh

    overcomplicating

  • 21:11:45
    brondsem

    :)

  • 21:12:14
    cory_fu

    Yeah, I thought it would be simpler when I made the suggestion

  • 21:12:55
    tvansteenburgh

    the way it is now is ugly but uses the fewest md5 calls

  • 21:13:14
    tvansteenburgh

    the 2-branch if causes a redundant md5 call, defeating the purpose

  • 21:14:25
    tvansteenburgh

    which would you rather maintain?

  • 21:14:49
    cory_fu

    That avoids the duplicate md5 call but it's still ugly

  • 21:15:44
    tvansteenburgh

    that's not too bad

  • 21:15:50
    tvansteenburgh

    better than mine

  • 21:15:53
    tvansteenburgh

    tests pass?

  • 21:16:36
    cory_fu

    Yes

  • 21:16:42
    cory_fu

    Want me to commit that, then?

  • 21:16:42
    tvansteenburgh

    +1 from me then

  • 21:16:46
    cory_fu

    OK

  • 21:17:21
    cory_fu

    The original was definitely cleaner but I guess this is the downside of optimization

  • 21:44:03
    wjp

    it's "threshold" by the way (single 'h' in the middle)

  • 21:44:21
    wjp

    usually I wouldn't care, but since it ends up in a config file...

  • 21:48:30
    cory_fu

    I can't believe I missed that

  • 21:53:40
    ASFBot

    Allura/382: #382 started building, estimated 10 minutes left. https://builds.apache.org/job/allura/382/

  • 21:55:41
    cory_fu

    (And corresponding internal configtree changes)

  • 21:55:43
    brondsem

    +1

  • 22:14:11
    ASFBot

    Allura/382: #382 built successfully after 20 minutes https://builds.apache.org/job/allura/382/

  • 22:39:53
    ASFBot

    Allura/383: #383 started building, estimated 13 minutes left. https://builds.apache.org/job/allura/383/

  • 22:51:19
    ASFBot

    Allura/383: #383 built successfully after 13 minutes https://builds.apache.org/job/allura/383/