Patches for 360lts (maintained by globalqss)

Developers
2010-10-05
2013-03-08
1 2 3 .. 6 > >> (Page 1 of 6)
  • Carlos Ruiz
    Carlos Ruiz
    2010-10-05

    Hi community, I just released the first patches for 360lts version maintained by globalqss.

    The plan is just to provide a way to share with community the bugs that we find and fix in our own maintained version.
    NOTE: Other maintainers are welcome, without noise, and following rules for the branch globalqss/adempiere361

    To check the fixed bugs you can review this revision:
    http://adempiere.svn.sourceforge.net/viewvc/adempiere?view=revision&revision=14096

    It's recommended also to apply the scripts 739 and 740 provided there to fix a couple of bugs.
    Also, script 739 implement a useful functionality in case you want to check (zoom from "used in" tabs)

    Regards,

    Carlos Ruiz
    http://qss.co

     
  • KittiU
    KittiU
    2010-10-06

    Thank you very much Carlos!

     
  • Dirk Niemeyer
    Dirk Niemeyer
    2010-10-06

    Carlos,

    thank you very much.

    Can you give information on how these patches relate to bugs or feature requests?

    Regards,

    Dirk Niemeyer

     
  • Carlos Ruiz
    Carlos Ruiz
    2010-10-06

    Hi Dirk, some of the bugs are related to sf adempiere trackers, other are bugs discovered in our customer installations and tracked with an internal system that we use in globalqss.

    As we had an internal repository to fix bugs and now we decided to make it public here, the first commit combine several bug fixes, in future most probably you'll find atomic commits with self-explanatory messages.

    Regards,

    Carlos Ruiz

     
  • Dirk Niemeyer
    Dirk Niemeyer
    2010-10-16

    Hi Carlos,

    I have a question concerning
    FR  Custom Separator Character,
    http://sourceforge.net/tracker/?func=detail&aid=3010957&group_id=176962&atid=879335

    There is a patch related to this in adempiere/branches/patches_360. Your patches branch contains almost the same change in source code. But patches_360 also contains a migration script named 740_BF_3010957.sql. I do not see this file in your branch.

    I wonder what happened to it?

    Is the numbering of the migration scripts managed somewhere? This should prevent use of the same number for different scripts.

    Thank you.

    Regards,

    Dirk Niemeyer

     
  • Carlos Ruiz
    Carlos Ruiz
    2010-10-16

    @Dirk #7

    Hi Dirk,

    > There is a patch related to this in adempiere/branches/patches_360.
    > Your patches branch contains almost the same change in source code.
    > But patches_360 also contains a migration script named 740_BF_3010957.sql.
    > I do not see this file in your branch.
    > I wonder what happened to it?

    That migration script is not needed, it's a workaround to "solve" the issue without patching, the patch solves the problem without the need of changing the DB.

    > Is the numbering of the migration scripts managed somewhere?
    > This should prevent use of the same number for different scripts

    I'm not following trunk closely, so I don't know how is the numbering going on there.
    Perhaps there are some things in trunk or contributions worth to be integrated, but I'm planning to discuss what to integrate from other branches or contributions with the people who wants to join this maintenance effort.  There are some people that have answered my past call, so I'm planning to set up a meeting next week to check if we can agree about management and maintenance.

    _______________________________

    @rsashka #8

    Hi Rsashka,

    > In your archive file …file patches.jar broken. Please check it

    I just double checked this:
    - downloaded the files
    - checked the md5sum of files
    - installed in a plain 360 applying the migration scripts on database
    - it's working

    So, please let me know what issues are you having with that file, so I can guide you with the install.

    Regards,

    Carlos Ruiz

     
  • rsashka
    rsashka
    2010-10-16

    Hi Carlos!

    I wrote about that in tgz archive all the jar files are broken (patches.jar  zkpatches.jar liberoHR.jar poi-3.5-FINAL-20090928.jar).

    Regards
    RSashka

     
  • Carlos Ruiz
    Carlos Ruiz
    2010-10-16

    Hi RSashka, can you please check the file patches_360lts_20101015.tgz against the md5 checksum provided patches_360lts_20101015.tgz.MD5 ?

    Regards,

    Carlos Ruiz

     
  • rsashka
    rsashka
    2010-10-16

    Hi Carlos!

    patches_360lts_20101015.tgz.MD5  - 56b2958ef2705491161f9be8af9ee4a6
    Your tgz archive OK.

    Corrupted files inside it (patches.jar zkpatches.jar liberoHR.jar poi-3.5-FINAL-20090928.jar).

    Regards RSashka

     
  • Carlos Ruiz
    Carlos Ruiz
    2010-10-17

    Hi RSashka,

    My ubuntu session for your review:

    # wget -O patches_360lts_20101015.tgz "http://sourceforge.net/projects/adempiere/files/GlobalQSS_Patches/360lts/patches_360lts_20101015.tgz/download"
    # wget -O patches_360lts_20101015_migra.tgz "http://sourceforge.net/projects/adempiere/files/GlobalQSS_Patches/360lts/patches_360lts_20101015_migra.tgz/download"
    # wget -O patches_360lts_20101015.tgz.MD5 "http://sourceforge.net/projects/adempiere/files/GlobalQSS_Patches/360lts/patches_360lts_20101015.tgz.MD5/download"
    # wget -O patches_360lts_20101015_migra.tgz.MD5 "http://sourceforge.net/projects/adempiere/files/GlobalQSS_Patches/360lts/patches_360lts_20101015_migra.tgz.MD5/download"
    # md5sum -c patches_360lts_20101015.tgz.MD5
    OK
    # md5sum -c patches_360lts_20101015_migra.tgz.MD5
    OK
    # tar tvzf patches_360lts_20101015.tgz
    -rw-r--r-- carlos/carlos 117137 2010-10-15 17:34 Adempiere/lib/patches.jar
    -rw-r--r-- carlos/carlos  38033 2010-10-15 17:34 Adempiere/lib/zkpatches.jar
    -rw-r--r-- carlos/carlos  66680 2010-10-15 16:56 Adempiere/packages/liberoHR/lib/liberoHR.jar
    -rw-r--r-- carlos/carlos 1516415 2010-10-15 16:56 Adempiere/packages/poi/lib/poi-3.5-FINAL-20090928.jar
    # tar tvzf patches_360lts_20101015_migra.tgz 
    -rw-r--r-- carlos/carlos  4049 2010-10-01 10:46 migration/360lts-release/oracle/738_AddZoomToUsedIn.sql
    -rw-r--r-- carlos/carlos   944 2010-10-01 10:46 migration/360lts-release/oracle/739_FixReleaseNoLength.sql
    -rw-r--r-- carlos/carlos   101 2010-10-01 10:46 migration/360lts-release/oracle/740_FixCaptureSequenceBrazil.sql
    -rw-r--r-- carlos/carlos  2914 2010-10-15 15:15 migration/360lts-release/oracle/741_PayrollDictionaryFixes.sql
    -rw-r--r-- carlos/carlos 78193 2010-10-13 17:22 migration/360lts-release/oracle/742_FR2878276_ImportPayroll.sql
    -rw-r--r-- carlos/carlos   127 2010-10-15 16:47 migration/360lts-release/oracle/742v_patchversion2010-10-15.sql
    -rw-r--r-- carlos/carlos  4104 2010-10-01 10:47 migration/360lts-release/postgresql/738_AddZoomToUsedIn.sql
    -rw-r--r-- carlos/carlos  1036 2010-10-01 10:47 migration/360lts-release/postgresql/739_FixReleaseNoLength.sql
    -rw-r--r-- carlos/carlos   101 2010-10-01 10:47 migration/360lts-release/postgresql/740_FixCaptureSequenceBrazil.sql
    -rw-r--r-- carlos/carlos  2984 2010-10-15 15:16 migration/360lts-release/postgresql/741_PayrollDictionaryFixes.sql
    -rw-r--r-- carlos/carlos 79038 2010-10-13 17:22 migration/360lts-release/postgresql/742_FR2878276_ImportPayroll.sql
    -rw-r--r-- carlos/carlos   127 2010-10-15 16:47 migration/360lts-release/postgresql/742v_patchversion2010-10-15.sql
    # tar xzf patches_360lts_20101015.tgz
    # jar tvf Adempiere/lib/patches.jar
        25 Fri Oct 15 17:34:22 COT 2010 META-INF/MANIFEST.MF
        54 Fri Oct 15 16:34:14 COT 2010 org/adempiere/version.properties
     24437 Fri Oct 15 16:55:52 COT 2010 org/adempiere/pipo/PackOut.class
      5415 Fri Oct 15 16:55:52 COT 2010 org/adempiere/pipo/handler/DataElementHandler$DataColumnElementHandler.class
      7625 Fri Oct 15 16:55:52 COT 2010 org/adempiere/pipo/handler/DataElementHandler$DataRowElementHandler.class
      8022 Fri Oct 15 16:55:52 COT 2010 org/adempiere/pipo/handler/DataElementHandler.class
     12592 Fri Oct 15 16:55:52 COT 2010 org/compiere/impexp/ImpFormat.class
     66890 Fri Oct 15 16:55:52 COT 2010 org/compiere/model/PO.class
       568 Fri Oct 15 16:55:52 COT 2010 org/compiere/model/GridTab$Loader.class
     52589 Fri Oct 15 16:55:52 COT 2010 org/compiere/model/GridTab.class
      6090 Fri Oct 15 16:55:52 COT 2010 org/compiere/model/MImage.class
      8623 Fri Oct 15 16:55:52 COT 2010 org/compiere/model/Scriptlet.class
      9115 Fri Oct 15 16:55:52 COT 2010 org/compiere/process/M_Production_Run.class
     29871 Fri Oct 15 16:55:52 COT 2010 org/compiere/util/Env.class
      3783 Fri Oct 15 16:55:52 COT 2010 org/eevolution/model/I_I_HR_Movement.class
      8016 Fri Oct 15 16:55:52 COT 2010 org/eevolution/model/X_I_HR_Movement.class
    # jar tvf Adempiere/lib/zkpatches.jar
        25 Fri Oct 15 17:34:18 COT 2010 META-INF/MANIFEST.MF
     16837 Fri Oct 15 16:55:52 COT 2010 WEB-INF/classes/org/adempiere/webui/component/CWindowToolbar.class
      1723 Fri Oct 15 16:55:52 COT 2010 WEB-INF/classes/org/adempiere/webui/panel/AbstractADWindowPanel$1.class
      1395 Fri Oct 15 16:55:52 COT 2010 WEB-INF/classes/org/adempiere/webui/panel/AbstractADWindowPanel$2.class
      2994 Fri Oct 15 16:55:52 COT 2010 WEB-INF/classes/org/adempiere/webui/panel/AbstractADWindowPanel$3.class
      1061 Fri Oct 15 16:55:52 COT 2010 WEB-INF/classes/org/adempiere/webui/panel/AbstractADWindowPanel$4.class
     46026 Fri Oct 15 16:55:52 COT 2010 WEB-INF/classes/org/adempiere/webui/panel/AbstractADWindowPanel.class
      5571 Fri Oct 15 16:55:52 COT 2010 WEB-INF/classes/org/adempiere/webui/window/WChat.class
    # jar tvf Adempiere/packages/liberoHR/lib/liberoHR.jar
        25 Fri Oct 15 16:52:18 COT 2010 META-INF/MANIFEST.MF
      2382 Fri Oct 15 08:45:58 COT 2010 org/compiere/acct/DocLine_Payroll.class
      8787 Fri Oct 15 10:56:40 COT 2010 org/compiere/acct/Doc_HRProcess.class
     21896 Fri Oct 15 08:45:58 COT 2010 org/eevolution/form/VHRActionNotice.class
      4225 Fri Oct 15 08:45:56 COT 2010 org/eevolution/model/MHRYear.class
      1353 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/CalloutPayroll.class
      6679 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRMovement.class
      1564 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRPeriod.class
      3084 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRConceptCategory.class
      5671 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRConcept.class
     34935 Fri Oct 15 10:02:56 COT 2010 org/eevolution/model/MHRProcess.class
      2787 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRDepartment.class
      3510 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRPayroll.class
      4552 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHREmployee.class
      3026 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRAttribute.class
      3277 Fri Oct 15 08:45:58 COT 2010 org/eevolution/model/MHRPayrollConcept.class
     10000 Fri Oct 15 08:45:56 COT 2010 org/eevolution/process/ImportPayrollMovement.class
      2113 Fri Oct 15 08:45:56 COT 2010 org/eevolution/process/HRCreateConcept.class
      1446 Fri Oct 15 08:45:56 COT 2010 org/eevolution/process/HRCreatePeriods.class
      2559 Fri Oct 15 08:45:56 COT 2010 org/eevolution/process/PayrollProcessing.class
      8799 Fri Oct 15 08:45:56 COT 2010 org/eevolution/process/PayrollViaEMail.class
       556 Fri Oct 15 08:45:56 COT 2010 org/eevolution/process/HRAttributeEmployee.class
    # jar tvf Adempiere/packages/poi/lib/poi-3.5-FINAL-20090928.jar 
         0 Mon Sep 28 17:52:38 COT 2009 META-INF/
       334 Mon Sep 28 17:52:36 COT 2009 META-INF/MANIFEST.MF
         0 Mon Sep 28 17:48:42 COT 2009 org/
         0 Mon Sep 28 17:48:42 COT 2009 org/apache/
         0 Mon Sep 28 17:52:38 COT 2009 org/apache/poi/
    ... a list of 1083 files ...
    

    Regards,

    Carlos Ruiz

     
  • jmpiloq
    jmpiloq
    2010-10-17

    Hi Carlos, hi all,

    are these patches also integrated into trunk? Who keeps track of this?

    Kind regards,

    jmpiloq

     
  • rsashka
    rsashka
    2010-10-17

    I have twice cut off the process of applying updates to the file patches.jar
    I tried to see its structure with the help of viewer and saw that it was broken (error in displaying the directory structure and filenames).

    Now done step by step upgrade process again.
    Everything went well. I never understood why I could not do it initially, but now I will no longer use the "wrong browser", because it was he misread the structure of the archives.

    Forgive me for generously raised a panic. All archives are serviceable, it's me too (not) helpful user. ;-)

     
  • Hi jmpilog,

    >are these patches also integrated into trunk? Who keeps track of this?

    All ADempiere developers who can commit in trunk can integrate patches which Carlos have provided for free in his branch.
    Today Victor have integrated few of HR fixes.

    Regards,
    Trifon

     
  • Jack
    Jack
    2010-11-07

    Hi Carlos,

    Thanks for the GlobalQSS patch. Does your patch contain also changes done in adempiere/branches/patches_360 ? If not, what is the strategy between trunk patches_360 and GlobalQSS patch? If GlobalQSS patch contains most of trunk patches changes, then I want to directly use GlobalQSS patch instead of trunk's patches_360 

    BR,
    Jack

     
  • Carlos Ruiz
    Carlos Ruiz
    2010-11-07

    Hi Jack,

    > Does your patch contain also changes done in adempiere/branches/patches_360?

    I don't know, I'm not following closely trunk or branches/patches_360.  Some times I see an interesting commit and I integrate it to my own patched version.  But unfortunately I'm not reviewing all commits, so I cannot answer 100% sure your question.

    > If not, what is the strategy between trunk patches_360 and GlobalQSS patch?

    No strategy from my side, just trying to provide a service here.
    ______________

    Let me try to explain to community what globalqss patches for 360 are:

    branches/globalqss/adempiere361 (and corresponding patches for 360) is somewhat like a "private" effort from globalqss to *publish* our bug fixes and tested additions from our customer, or selected things integrated from trunk and other branches.

    One of the things that I hate most is people maintaining "private" versions (bug fixes) and not sharing with community.

    It's up to community if they want to use our version, or to integrate some things we add in trunk (it has happened recently with some of our additions, but not all).

    It's not my intention to fork, unfortunately I cannot trust in trunk to maintain my installed base of customers, and fortunately I don't like to keep my bug fixes and additions as private.

    On the other hand, I don't feel comfortable contributing at this moment to trunk without clear rules and proper quality process set up, we're all expectants to see how trunk management will be set up, but in the meantime we have a installed base to maintain and a lot of bugs to stabilize.  If trunk management is properly defined in future I would consider contributing back there.  What still hasn't passed through my mind is to hide my bug fixes and/or improvements because of the current situation.

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz
    Carlos Ruiz
    2010-11-08

    Hi community, somebody asked me today how to contribute on branches/globalqss/adempiere361 branch.

    I'll put this simple, if you find a bug on this specific version you can file a bug and assign it to me (globalqss), I'll try my best to review and answer it.
    If you have a fix for a bug, please attach a patch on the bug report and I'll review and comment it.
    Also, if you prefer you can send me an e-mail describing the case.

    If you have a contribution that you think it's worthy to be integrated/included please send me an e-mail with the contribution (or open a contribution tracker here and assign it to me - globalqss) - I'll answer.
    Preferrably, if you want to have a bigger change that my review is smooth - please follow the functional specification template described here:
    http://www.adempiere.com/index.php/Proposal_Functional_Specification_Template

    You can find a couple of samples here:
    http://www.adempiere.com/index.php/FS01_Commitment_AR_AP
    http://www.adempiere.com/index.php/FS02_Cash_Flow

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz
    Carlos Ruiz
    2010-11-09

    Hi community, in advance of my yesterday's post I received a couple of requests to review some bugs.

    So, please allow me to shape up this a little more:

    - Please fill the bug report (or the e-mail) following the guide I just wrote on wiki:
    http://www.adempiere.com/index.php/How_to_report_a_bug
    Most possible I'll reject to review a bug reported without steps to reproduce.

    - I'm not reviewing bugs on trunk, so you must let me know which scripts have you applied from the branches/globalqss/adempiere361 branch, and the steps to reproduce must be applicable to a 360+globalqss_patched version

    Regards,

    Carlos Ruiz

     
1 2 3 .. 6 > >> (Page 1 of 6)