Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#2239 fix BOM back compatibility

Core
closed-works-for-me
9
2009-12-24
2009-11-26
No

Dear Community!

I implement an best approach to BOM back compatibility, the Product window now show the BOM Tab as was in the past, also I migrate the old BOM Drop from to support the new Model BOM Lines.

The bill of material & formula was restore original place and the Product configuration was move the original location.

the BOM Drop and Product Configure are to differentness because in Product Configuration you can use the features, option, varian while that BOM Drop the old alternate Group now are variants types.

kind regards
Victor Perez
www.e-evolution.com

Discussion

1 2 > >> (Page 1 of 2)
    • status: open --> open-fixed
     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-27

    Hi Victor,

    Thanks for the changes. I tested and it seems almost everything is working - except the product window.

    I think it's better to have a Product BOM window (or call it BOM & Formula, whatever) - independent from the product window.

    The issue is that I found big problems because the third tab (Components) is having a M_Product_ID field, and all the tabs below are depending on the context variable M_Product_ID.

    I fixed your mistake on the tab levels of BOM and component (you defined them as 0 and 1, I changed to 1 and 2) - but still the window doesn't behave properly because of the overwriting of the context variable.

    My advice - drop those two tabs and we better configure the BOM's in a new window.

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-27

    • status: open-fixed --> open
     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-27

    Ah, forgot to say - BOM Drop worked properly in my tests.

    I think is better to move the BOM & Formula window below Product - but it's up to you if you prefer to duplicate the window.

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-30

    Great thing we're stabilizing - we just added a new bug core-priority 9. 4 days now without solution. Great trunk!

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-30

    • priority: 5 --> 9
    • milestone: --> Core
     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-30

    Victor, independent if the issue is from window engine or not - YOU INTRODUCED A BUG HERE, AND ETIQUETTE WOULD SAY YOU MUST FIX IT.

    Because the cause is different doesn't mean that you must not take care of quality here.

    If Kai's proposal solve the problem - then it must be implemented BEFORE your change - without Kai's patch you're breaking a functionality.

    What kind of QA is this? If I can break Adempiere because there is a misbehavior in window engine and it doesn't matter to me?

    _________
    Carlos Ruiz

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-30

    Bug still not solved implementing Kai's suggestion.

    If we go this way then this window needs further arrangements:

    1 - BOM tab must be level 1

    2 - Component tab must be level 2

    But I still think the Kai's patch doesn't fix this - because you need to mark all the other tabs as filtered by product on tab 0 - and get rid of link column - so probably the Kai's patch needs further work to make this window work.

    Victor, you're fixing a bug opening another bug, and the fix original bug opening another bug, and so on

    I think you must conduct complete tests before committing and try to commit complete solutions. With proper QA this would be reverted from the beginning - where is QA here?

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-11-30

    Test case:

    Open product window
    select PatioSet
    navigate to BOM
    navigate to Component
    navigate to Price

    The wrong product will be shown on the Price tab - with the corresponding risk that a user inadvertently ends filling a price for the wrong product - same for all the other detail tabs.

    ________
    Carlos Ruiz

     
  • Thank a lot for your test Carlos!

    I am fix and create more intensive test.

    So let me finish with this work

    Victor Perez
    www.e-evolution.com

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-12-07

    Hi developers - I'm proposing to revert this - and leave the Product and BOM maintenance in separate windows.

    Currently "Product" window - one of the most important windows in Adempiere is not working properly.

    Regards,

    Carlos Ruiz

     
  • SCalderon
    SCalderon
    2009-12-07

    Hi Carlos,
    what do you meen with "does not work properly"?
    Ragards
    Susanne

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-12-07

    Thanks Susanne, please read my comments below - I described the problem and provided test cases.

    Regards,

    Carlos Ruiz

     
  • Redhuan D. Oon
    Redhuan D. Oon
    2009-12-07

    Please can others test this and provide feedback to us also?

    Kind Regards
    red1

     
  • Carlos Ruiz
    Carlos Ruiz
    2009-12-08

    Thanks Redhuan, IMHO product window is so important that it must keep STABLE - the window is broken since commits from this specific tracker. It doesn't matter if the culprit is a different issue - the window MUST WORK until the other issue is solved.

    BTW - you can test and follow my provided test cases in http://www.testadempiere.com/webui

    Regards,

    Carlos Ruiz

     
    • status: open --> pending-fixed
     
  • Carlos Ruiz
    Carlos Ruiz
    2009-12-08

    • status: pending-fixed --> open-fixed
     
  • Carlos Ruiz
    Carlos Ruiz
    2009-12-08

    Just checked and THIS specific problem is still not solved.

    Please don't close tracker unless the problem is solved - it makes traceability harder.

    I implemented a temporal approach (meanwhile the other trackers are implemented or solved).
    - hide the two new tabs causing problems in product window
    - moved the BOM & Formula window to material management rules
    committed this temporal solution with revision 11057.
    http://adempiere.svn.sourceforge.net/adempiere/?rev=11057&view=rev

    PLEASE don't commit again INCOMPLETE things - if you're going to commit a solution PRODUCT WINDOW MUST WORK.

    If in doubt please post a tracker here (instead of committing) and other developers will help with peer review.

    Regards,

    Carlos Ruiz

     
    • status: open-fixed --> open-works-for-me
     
1 2 > >> (Page 1 of 2)