[Acx100-devel] Re: From: Carlos Mart??n <carlos@cmartin.tk>

[Christoph H. <hc...@in...>]

On Sat, Feb 18, 2006 at 11:35:21PM +0100, Carlos Martin wrote:
> [PATCH] acxsm: Fix Kconfig option check
> 
> This check never actually worked because CONFIG_ACX_{ACX,USB} are
> tristate. With Adrian Bunk's patch to the Kconfig, this works with the
> _BOOL hidden Kconfig options.
> Also update error message adding that this shouldn't happen anymore.

All the fixes discussed so far are not very nice at all.  The right
fix is the following:


 - split the module into three:
	acx-common.ko
	acx-pci.ko
	acx-usb.ko

 - make CONFIG_ACX_PCI and CONFIG_ACX_USB user-visible tristate
   varibles in the Kconfig.
 - build acx-common.ko when either of those is selected, with the
   following makefile:

---- snip ----
acx-common-y		+= wlan.o conv.o ioctl.o common.o
acx-pci-y		+= pci.o
acx-usb-y		+= usb.o

obj-$(CONFIG_ACX_PCI)	+= acx-common.o acx-pci.o
obj-$(CONFIG_ACX_USB)	+= acx-common.o acx-usb.o
---- snip ----

 - kill the IS_PCI/IS_USB macros and add a acx_operations structure that
   handles the different hardware without branches all over and allows
   the hw-specific code to be in separate modules.