RE: [ACPI] help needed with invalid method in GPE block

[Grover, A. <and...@in...>]

> From: Charl P. Botha [mailto:c.p...@it...] 
> > > Through printk()s all over, it seems that the acpi code never 
> > > explicitly
> > > enables the 0x1D event on my machine at all, nevermind 
> enabling it for
> > > waking.  Is this a problem with my firmware/dsdt or with the 
> > > acpi kernel
> > > code?
> > 
> > Are you sure? We should be calling acpi_ev_save_method_info for each
> > _Lxx or _Exx entry under _GPE scope, and that function 
> enables the GPE.
> > Please let me know if this is not the case.
> 
> I'm quite sure.  Yes, you do call acpi_ev_save_method_info() 
> for each _Lxx
> and _Exx method, but in acpi_ev_save_method_info() you only call
> acpi_hw_enable_gpe() and NEVER 
> acpi_hw_enable_gpe_for_wakeup().  As a matter
> of fact, shouldn't that call rather be acpi_enable_event() (INSTEAD of
> acpi_hw_enable_gpe()) with the WAKEUP parameter according to 
> some mask?

I agree that it is currently never enabled for wakeup, but you said we
never enable it at all, the opposite of what your last email said. I
guess I'll assume the second statement is what you meant.

BTW here is the bug:
http://bugme.osdl.org/show_bug.cgi?id=470

Apparently it only allows CCs to registered people, so I couldn't add
you, but if you have any extra comments, feel free to register and add
them there.

Regards -- Andy