From: Luis Neves <lneves@es...> - 2002-04-30 14:04:47
Here are my comments regarding the patch Juliusz proposed applied to my=20
machine, a COMPAQ Presario 12XL515.
It works as Juliusz said. Now I have events (finally I got something when=
cat /proc/acpi/event and press the power button), and it also signs when=20
battery status change. I also got C2 working.
These results were obtained with a plain 2.4.18 kernel + acpi-20020404 +=20
Juliusz patch + Jeff Snyder's patch regarding the _SB bug on COMPAQ machi=
Unfortunately I lost the battery status information and I don't know what=
the cause, if it is the latest acpi or Jeff Snyder's patch.=20
I used to override the DSDT with a corrected one but I was unable to do i=
with this last version as the tbget.c code changed, and my guess of what =
do failed. I couldn't access the intel site for checking if this is alrea=
explained. Can anyone help me on this?=20
Anyway, here is my humble opinion regarding the inclusion of this kind of=
1 - I understand Andrew Grover's policy of developping the ACPI code, bas=
on "perfect" implementations. In this stage of development, if we can put=
compliant machine working is already a major goal. However, I wonder how =
"perfect" machines are out there? COMPAQ is one of the largest PC=20
manufacturers and it seems that almost all their machines have flaws. Tos=
seems no better. In the laptop market, what is the remaining share?
2 - I know that one of the principles on which Linux is based is a=20
do-it-for-yourself, but if this is ok for starting up things, it doesn't =
to me as a good basis for serious development, specially of basic things =
ACPI is for recent and future laptops.=20
3 - The existence of small hacks for particular machines must be somehow=20
mantained by who is developping the main code as it changes a lot, like t=
tbget.c which now prevents me of doing my usual DSDT override.
4 - It would be great if we could have a config time option of including=20
these things, or at least a kind of public library of optional patches fo=
ACPI which one could apply on the main tree to have it included.
Thank you all and keep up the good work,