Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#86 move the "msg.is_from_ourselves()" test

open
nobody
None
5
2004-05-14
2004-05-14
Marc Herbert
No

This extremely simple suggestion is about moving a filtering action lost in some subroutine in askmessage.py, back to the main filtering code in askmain.py. Reading the patch is the best way to understand it. This patch is totally UNTESTED, it's just a way to precisely define the suggestion.

Hopefully this change does not alter the current behaviour at all.

One nice side effect of this suggested "clean-up", besides a shorter code, is that any user may then easily customize the filtering by modifying _only_ the main filtering procedure, without digging into obscure subsubroutines in askmessage.py

Thanks in advance.

Discussion

  • Marc Herbert
    Marc Herbert
    2004-05-14

    suggested change

     
    Attachments