PNG and MNG/JNG image formats: home site

Email Archive: png-mng-implement (read-only)

[png-mng-implement] FW: Compiler warnings for pngrtran.c

From: Jeff Phillips <Jeff.Phillips@sa...> - 2007-09-11 15:31

Hi, we are getting some compiler warnings for pngrtran.c

   553     png_ptr->flags &=3D !(PNG_FLAG_ROW_INIT);
   582     png_ptr->flags &=3D !(PNG_FLAG_ROW_INIT);
   595     png_ptr->flags &=3D !(PNG_FLAG_ROW_INIT);
   620     png_ptr->flags &=3D !(PNG_FLAG_ROW_INIT);
   632     png_ptr->flags &=3D !(PNG_FLAG_ROW_INIT);

Should the "!" instead be "~" ?

  3871              png_byte red_high =3D (trans_value->red > 8) & 0xff;
  3872              png_byte green_high =3D (trans_value->green > 8) &
0xff;
  3873              png_byte blue_high =3D (trans_value->blue > 8) & =
0xff;

Should the ">" instead be ">>" ?

Thanks much for looking into this,
Jeff Phillips

Thread View

Thread	Author	Date
[png-mng-implement] FW: Compiler warnings for pngrtran.c	Jeff Phillips <Jeff.Phillips@sa...>

Re: [png-mng-implement] FW: Compiler warnings for pngrtran.c

From: Glenn Randers-Pehrson <glennrp@gm...> - 2007-09-11 19:37

On 9/11/07, Jeff Phillips <Jeff.Phillips@sas.com> wrote:

> 3871 png_byte red_high = (trans_value->red > 8) & 0xff;
> 3872 png_byte green_high = (trans_value->green > 8) &
> 0xff;
> 3873 png_byte blue_high = (trans_value->blue > 8) & 0xff;
>
> Should the ">" instead be ">>" ?

Ahah. This no doubt explains Cook's bug.

Glenn

Re: [png-mng-implement] FW: Compiler warnings for pngrtran.c

From: George Cook <COOK@wv...> - 2007-09-11 19:50

>On 9/11/07, Jeff Phillips <Jeff.Phillips@sas.com> wrote:

>> 3871 png_byte red_high = (trans_value->red > 8) & 0xff;
>> 3872 png_byte green_high = (trans_value->green > 8) &
>> 0xff;
>> 3873 png_byte blue_high = (trans_value->blue > 8) & 0xff;
>>
>> Should the ">" instead be ">>" ?

>Ahah. This no doubt explains Cook's bug.

Yes, that fixes the problem.

BTW, would it be possible to change line 225 in PNGSET.C from

if (info_ptr->num_palette <= 0 || info_ptr->num_palette

to

if (info_ptr->num_palette = 0 || info_ptr->num_palette

This would keep my C compiler from giving an informational message
saying that it makes no sense to do an < 0 comparison on an unsigned
value.

George Cook

Re: [png-mng-implement] FW: Compiler warnings for pngrtran.c

From: Jeff Phillips <Jeff.Phillips@sa...> - 2007-09-11 19:53

Just like ">" should be ">>", "=3D" should be "=3D=3D" :)=20

-----Original Message-----
From: png-mng-implement-bounces@lists.sourceforge.net /> [mailto:png-mng-implement-bounces@lists.sourceforge.net] On Behalf Of
George Cook
Sent: Tuesday, September 11, 2007 3:43 PM
To: PNG/MNG implementation discussion list
Cc: COOK@wvnvaxa.wvnet.edu /> Subject: Re: [png-mng-implement] FW: Compiler warnings for pngrtran.c

>On 9/11/07, Jeff Phillips <Jeff.Phillips@sas.com> wrote:

>> 3871 png_byte red_high =3D (trans_value->red > 8) & =
0xff;
>> 3872 png_byte green_high =3D (trans_value->green > 8) &
>> 0xff;
>> 3873 png_byte blue_high =3D (trans_value->blue > 8) &
0xff;
>>
>> Should the ">" instead be ">>" ?

>Ahah. This no doubt explains Cook's bug.

Yes, that fixes the problem.

BTW, would it be possible to change line 225 in PNGSET.C from

if (info_ptr->num_palette <=3D 0 || info_ptr->num_palette

to

if (info_ptr->num_palette =3D 0 || info_ptr->num_palette

This would keep my C compiler from giving an informational message
saying that it makes no sense to do an < 0 comparison on an unsigned
value.

George Cook

------------------------------------------------------------------------
-
This SF.net email is sponsored by: Microsoft Defy all challenges.
Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
png-mng-implement mailing list
png-mng-implement@lists.sourceforge.net /> https://lists.sourceforge.net/lists/listinfo/png-mng-implement

Re: [png-mng-implement] FW: Compiler warnings for pngrtran.c

From: George Cook <COOK@wv...> - 2007-09-11 19:58

>Just like ">" should be ">>", "=" should be "==" :)

Sorry, I made the change correctly in the code, but got it wrong
in the email.

>-----Original Message-----
>From: png-mng-implement-bounces@lists.sourceforge.net /> >[mailto:png-mng-implement-bounces@lists.sourceforge.net] On Behalf Of
>George Cook
>Sent: Tuesday, September 11, 2007 3:43 PM
>To: PNG/MNG implementation discussion list
>Cc: COOK@wvnvaxa.wvnet.edu /> >Subject: Re: [png-mng-implement] FW: Compiler warnings for pngrtran.c

>>On 9/11/07, Jeff Phillips <Jeff.Phillips@sas.com> wrote:

>>> 3871 png_byte red_high = (trans_value->red > 8) & 0xff;
>>> 3872 png_byte green_high = (trans_value->green > 8) &
>>> 0xff;
>>> 3873 png_byte blue_high = (trans_value->blue > 8) &
>0xff;
>>>
>>> Should the ">" instead be ">>" ?

>>Ahah. This no doubt explains Cook's bug.

>Yes, that fixes the problem.

>BTW, would it be possible to change line 225 in PNGSET.C from

> if (info_ptr->num_palette <= 0 || info_ptr->num_palette

>to

> if (info_ptr->num_palette = 0 || info_ptr->num_palette

>This would keep my C compiler from giving an informational message
>saying that it makes no sense to do an < 0 comparison on an unsigned
>value.

>George Cook

PNG and MNG/JNG image formats: home site

Email Archive: png-mng-implement (read-only)

Thread View

About SourceForge

Find Software

Develop Software

Community

Help