Earnie Boyd wrote:
> On 11:38:06 pm 2005-07-05 "Max T. Woodbury" <max@...> wrote:
> > Earnie Boyd wrote:
> > >
> > > On 9:50:45 pm 2005-07-05 "Max T. Woodbury" <max@...>
> > > > wrote: I just finished a rebuild of yesterday's CVS HEAD version
> > > > of MSys. Several things stopped working on Windows98/SE. (I was
> > > > going to use it to rebuild the today's changes.)
> > > >
> > > > The most important is TAR now blows up without doing any useful
> > > > work. Also FIND.
> > > >
> > > > This bug was reported weeks ago and there is even a patch in the
> > > > bug report to fix it!
> > > >
> > >
> > > And did the patch resolve your issue? Which bug id is it?
> > 1226400
> > It fixed the find and fileutils problem for 1.0.11 rebuild. An
> > indirect test indicates it should have the same impact on TAR. I'm
> > about to apply it (again) to HEAD to make absolutely sure. I'd
> > cleaned out my previous checkout about three days ago to make sure I
> > was building against the latest revision and had not put any of my
> > own patches back in yet.
> Patch commited.
TAR, FIND, and the fileutils are now usable. Thank you.
There is still an issue with 'rm -fr <dir>'. It gives a 'permission denied'
on removing the top level directory. It does the recursion part correctly
and a follow-up 'rmdir <dir>' works. The versions without 'fchdir' enabled
work. I don't think this is a show-stopper, but I could be wrong.
Less important but probably similar is a problem with 'cp -p' and 'tar'
on read-only files. They get a 'permission denied' on the date change
option. This is NOT new. It happened with 1.0.11 snapshot, but is
probably due to the same basic 9x/ME problem. I think this is probably
a 'if you happen to be in that part of the code' kind of fix but it
does have visibility.
There is also a fairly trivial problem with the patch. Technically
a successful operation is not supposed to change 'errno'. That means
errno should be saved before the real open operation and 'restored'
as part of the 'fake' successful open. It might be a problem for a
certain uncommon style of programming and since the solution is
obvious once the problem is recognized, it should probably be fixed.
Bug reports or just patches?