Inkscape

>I found the problem that causes #1 but I didn't found the source that 
>writes the root width and height with the units.

Initially it's set in document.cpp:

/* Quick hack 2 - get default image size into document */
        if (!sp_repr_attr (rroot, "width")) sp_repr_set_attr (rroot, 
"width", A4_WIDTH_STR);
        if (!sp_repr_attr (rroot, "height")) sp_repr_set_attr (rroot, 
"height", A4_HEIGHT_STR);

but that uses preset strings "210mm" and "297mm" so you don't need to change 
that. (Ugly, btw, this needs to be reqritten properly, so it takes initial 
page size from a template.)

Then it may also be set in root.cpp, but that is already covered, because it 
uses sp_repr_set_double. Finally it is also set in 
dialogs/desktop-properties.cpp (document options dialog):

   g_snprintf ( c, 32, "%g%s", adjustment->value,
                 sp_unit_selector_get_unit (us)->abbr );

and this one needs to be replaced.

_________________________________________________________________
Tired of spam? Get advanced junk mail protection with MSN Premium   
http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=http://hotmail.com/enca&HL=Market_MSNIS_Taglines

bulia byak wrote:

> I applied your first three patches, thanks.
> 
>> 1. When drawing a polygon (the star) numbers in the points element are 
>> locale dependent, strange the star is drawn correctly.
>> 2. The root document with and height are also locale dendent.
> 
> 
> Yes, and probably other places, too. What we need to do is just search 
> for "printf" and see if the output of it goes into SVG, and if so, 
> replace them (some printfs print debug messages on screen, you can leave 
> them alone). Now that you know what to do, it should be easy :)
> 

I think that they were all cleaned up
in /xml and /svg, and now it is mostly
the special shapes that have sprintf()'s left.

Mental's use of <sstream> works nicely.  I have
used that elsewhere to format floats free from
locale worries.

Look at how /svg/svg-path.cpp , line 631
uses Inkscape::SVGOStringStream.
It is small and simple.




Bob

bulia byak wrote:
> I applied your first three patches, thanks.
> 
You are my boy ;-)
> 
> 
> Please resend this patch in diff -u format as were the previous ones.
see attached file

Adib.

In the "Elements and Principles of Design" tutorial", the Principles of
Design graphics are all absent. Should this be so?

vellum using Win32 auto-build 27 March 2004.

>>Please resend this patch in diff -u format as were the previous ones.
>see attached file

Thanks, applied

_________________________________________________________________
Free yourself from those irritating pop-up ads with MSn Premium. Get 2months 
FREE*  
http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=http://hotmail.com/enca&HL=Market_MSNIS_Taglines

On Fri, 26 Mar 2004, bulia byak wrote:
> I applied your first three patches, thanks.
> 
> >1. When drawing a polygon (the star) numbers in the points element are 
> >locale dependent, strange the star is drawn correctly.
> >2. The root document with and height are also locale dendent.
> 
> Yes, and probably other places, too. What we need to do is just search for 
> "printf" and see if the output of it goes into SVG, and if so, replace them 
> (some printfs print debug messages on screen, you can leave them alone). Now 
> that you know what to do, it should be easy :)

The printfs that print debug messages should probably be replaced with
g_message() or g_warning() calls, as appropriate.  

Bryce

Hello,
....
> 
>   g_snprintf ( c, 32, "%g%s", adjustment->value,
>                 sp_unit_selector_get_unit (us)->abbr );
> 
> and this one needs to be replaced.
Se attached diff for the function that causes the komma.
For now I don't see other cases that generate wrong number output even 
there are a lot printfs.

Many thanks,

Adib.

Bryce Harrington wrote:
> On Fri, 26 Mar 2004, bulia byak wrote:
> 
>>I applied your first three patches, thanks.
>>
>>
>>>1. When drawing a polygon (the star) numbers in the points element are 
>>>locale dependent, strange the star is drawn correctly.
>>>2. The root document with and height are also locale dendent.
>>
>>Yes, and probably other places, too. What we need to do is just search for 
>>"printf" and see if the output of it goes into SVG, and if so, replace them 
>>(some printfs print debug messages on screen, you can leave them alone). Now 
>>that you know what to do, it should be easy :)
> 
> 
> The printfs that print debug messages should probably be replaced with
> g_message() or g_warning() calls, as appropriate.  
> 
> Bryce 
> 

Bryce,

I was thinking,  wouldn't it be nice if Inkscape
had its own debug output console, like many apps
have?   This is almost  unnecessary on Unix,
but important on platforms that do not
have pty-like consoles.

How about adding a couple of methods to the Inkscape
class (since all code pieces in Inkscape should have it as
their parent),  like   inkscape->error("format", ...)  and
inkscape->warning("format", ...); .

We could use this to redirect the debug output
to either the same Glib g_message() and g_error()
output we have now, or to a separate Gui.
A simple text console similar to Mozilla's
Java Console would be excellent.  We could
redirect many types of informational messages
to it.  And it would be in a format that users
could easily email to us in case of problems.


This might be a good task for a new contributor
to Inkscape.





Bob



Bob

On Sun, 2004-03-28 at 00:24, Bob Jamison wrote:
> We could use this to redirect the debug output
> to either the same Glib g_message() and g_error()
> output we have now, or to a separate Gui.

There's really no reason to do so; glib already provides hooks to
redirect the g_message() and g_error() output elsewhere (e.g. to such a
GUI console).

http://developer.gnome.org/doc/API/2.0/glib/glib-Message-Logging.html#g-log=
-set-handler

-mental

On Sat, 27 Mar 2004, Bob Jamison wrote:
> Bryce,
> 
> I was thinking,  wouldn't it be nice if Inkscape
> had its own debug output console, like many apps
> have?   This is almost  unnecessary on Unix,
> but important on platforms that do not
> have pty-like consoles.

Not a bad idea.  

> How about adding a couple of methods to the Inkscape
> class (since all code pieces in Inkscape should have it as
> their parent),  like   inkscape->error("format", ...)  and
> inkscape->warning("format", ...); .

Could we be certain that all of the places we'd want to
emit errors would have visibility to the inkscape class
definition?  I.e., are there any sub-libraries that we'd
want to emit debug info but not be tied too tightly to 
Inkscape?  How would this work for Inkview?

> We could use this to redirect the debug output
> to either the same Glib g_message() and g_error()
> output we have now, or to a separate Gui.
> A simple text console similar to Mozilla's
> Java Console would be excellent.  We could
> redirect many types of informational messages
> to it.  And it would be in a format that users
> could easily email to us in case of problems.

*Nod*  Do you have examples of how other apps have 
done it, or do you think the Mozilla approach is 
completely representative?  

Bryce

>Se attached diff for the function that causes the komma.

Thanks, applied

>For now I don't see other cases that generate wrong number output even 
>there are a lot printfs.

Here's what I found:

sp_arc_set_elliptical_path_attribute in sp-ellipse

sp_stop_write and sp_gradient_repr_set_vector in sp-gradient

sp-metrics

one more _dump_path is sp-offset

sp_shape_build in sp-shape

still lots of printfs with %g in style.cpp

sp_svg_write_percentage

all postscript output in extensions/internal/ps.cpp

sp_dtw_whatever_changed and 2 more cases in desktop-properties

still more style writing in sp_fill_style_widget_paint_changed in 
dialogs/fill-style

similar in stroke-style, also dash setting there

widget_opacity_value_changed in item-properties

setting font-size in text-edit

Perhaps I still missed something...

_________________________________________________________________
Free yourself from those irritating pop-up ads with MSn Premium. Get 2months 
FREE*  
http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=http://hotmail.com/enca&HL=Market_MSNIS_Taglines

Hi people,

I cannot get special characters using Win32-2000 autobuild 27 March.

Each time I try I get a small empty rectangle instead of the character.

I am also getting the error message shown in the attached file.

I am sure that I used to be able to get special characters. Any help?

vellum

> Here's what I found:
 >
 > sp_arc_set_elliptical_path_attribute in sp-ellipse
 >
....

Oh my god ;-)

ok lets go step by step and where we can produce a failure ...

Attached there is a failure.svg and patch for the "d" property in ellipse.
Also a patch for stroke-with in style.

I noticed that I can't set stroke with from within the dialog. So most 
of the dialog functions are infected.




bulia byak wrote:
>> Se attached diff for the function that causes the komma.
> 
> 
> Thanks, applied
> 
>> For now I don't see other cases that generate wrong number output even 
>> there are a lot printfs.
> 
> 
> Here's what I found:
> 
> sp_arc_set_elliptical_path_attribute in sp-ellipse
> 
> sp_stop_write and sp_gradient_repr_set_vector in sp-gradient
> 
> sp-metrics
> 
> one more _dump_path is sp-offset
> 
> sp_shape_build in sp-shape
> 
> still lots of printfs with %g in style.cpp
> 
> sp_svg_write_percentage
> 
> all postscript output in extensions/internal/ps.cpp
> 
> sp_dtw_whatever_changed and 2 more cases in desktop-properties
> 
> still more style writing in sp_fill_style_widget_paint_changed in 
> dialogs/fill-style
> 
> similar in stroke-style, also dash setting there
> 
> widget_opacity_value_changed in item-properties
> 
> setting font-size in text-edit
> 
> Perhaps I still missed something...
> 
> _________________________________________________________________
> Free yourself from those irritating pop-up ads with MSn Premium. Get 
> 2months FREE*  
> http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI=1034&SU=http://hotmail.com/enca&HL=Market_MSNIS_Taglines 
> 
> 
>