DScaler Deinterlacer/Scaler

Email Archive: deinterlace-discuss (read-only)

Re: [Deinterlace-discuss] AR autodetection

From: Laurent Garnier <laurent.garnier@cl...> - 2001-05-28 22:30

----- Message d'origine ----- 
De : Michael Samblanet <mike@...>

Hi!

> Does the missing line only occur on the bottom or on both the top and
> bottom?

I think it is OK at top. It is difficult to say because top border is greater than
bottom boder for the film I use (Seven). But if I draw a white line at the correct
top position, I can see that your black rectangle touch my white line. So it is ok.

> I can't test from my PC right now - so here is some modified code from
> AspectGUI.cpp you can try...
> 
>  // Draw overlay color in the middle.
>  IntersectRect(&r, &aspectSettings.destinationRectangle, PaintRect);
>  r.right++; r.bottom++; // FillRect excludes Right and Bottom
>  FillRect(hDC, &r, overlay);

It changes nothing as I can see. Sorry Michael.
I even try : r.bottom+=50; No more success !!! Strange, isn't it ?

The problem is not attached to overscan, as I have now set my overscan to 0.

I even tried to use 1.77777777 in place of GetActualSourceFrameAspect()
= 1.778 with no more succeess.

I have same problem using resolution 800x600 and 640x480.

The only solution I find is to substract 30 from the autodetected and calculated
ratio :-(((( The bottom is then ok but the top is no more ok (few lines not hidden).

Michael, there is a mistery.
---------------------------------------------------------------------------------------------------------
Laurent          laurent.garnier@...

Thread View

Thread	Author	Date
Re: [Deinterlace-discuss] AR autodetection	Michael Samblanet <mike@ca...>

Re: [Deinterlace-discuss] AR autodetection

From: Laurent Garnier <laurent.garnier@cl...> - 2001-05-28 22:30

----- Message d'origine ----- 
De : Michael Samblanet <mike@...>

Hi!

> Does the missing line only occur on the bottom or on both the top and
> bottom?

I think it is OK at top. It is difficult to say because top border is greater than
bottom boder for the film I use (Seven). But if I draw a white line at the correct
top position, I can see that your black rectangle touch my white line. So it is ok.

> I can't test from my PC right now - so here is some modified code from
> AspectGUI.cpp you can try...
> 
>  // Draw overlay color in the middle.
>  IntersectRect(&r, &aspectSettings.destinationRectangle, PaintRect);
>  r.right++; r.bottom++; // FillRect excludes Right and Bottom
>  FillRect(hDC, &r, overlay);

It changes nothing as I can see. Sorry Michael.
I even try : r.bottom+=50; No more success !!! Strange, isn't it ?

The problem is not attached to overscan, as I have now set my overscan to 0.

I even tried to use 1.77777777 in place of GetActualSourceFrameAspect()
= 1.778 with no more succeess.

I have same problem using resolution 800x600 and 640x480.

The only solution I find is to substract 30 from the autodetected and calculated
ratio :-(((( The bottom is then ok but the top is no more ok (few lines not hidden).

Michael, there is a mistery.
---------------------------------------------------------------------------------------------------------
Laurent          laurent.garnier@...

Re: [Deinterlace-discuss] AR autodetection

From: Michael Samblanet <mike@ca...> - 2001-05-28 23:47

<sigh> Back to the drawing board...

Sounds like a problem with the source rectangle - but you said the aspect
calculated source rect was bigger than the rectangle you wanted by one line
on the top and bottom...

Well...I'll think about it some, read back over these messages and see if I
can come up with something else...(anybody have a rubber chicken I can
borrow?)

- M

----- Original Message -----
From: "Laurent Garnier" <laurent.garnier@...>
To: <deinterlace-discuss@...>
Sent: Monday, May 28, 2001 6:15 PM
Subject: Re: [Deinterlace-discuss] AR autodetection


> ----- Message d'origine -----
> De : Michael Samblanet <mike@...>
>
> Hi!
>
> > Does the missing line only occur on the bottom or on both the top and
> > bottom?
>
> I think it is OK at top. It is difficult to say because top border is
greater than
> bottom boder for the film I use (Seven). But if I draw a white line at the
correct
> top position, I can see that your black rectangle touch my white line. So
it is ok.
>
> > I can't test from my PC right now - so here is some modified code from
> > AspectGUI.cpp you can try...
> >
> >  // Draw overlay color in the middle.
> >  IntersectRect(&r, &aspectSettings.destinationRectangle, PaintRect);
> >  r.right++; r.bottom++; // FillRect excludes Right and Bottom
> >  FillRect(hDC, &r, overlay);
>
> It changes nothing as I can see. Sorry Michael.
> I even try : r.bottom+=50; No more success !!! Strange, isn't it ?
>
> The problem is not attached to overscan, as I have now set my overscan to
0.
>
> I even tried to use 1.77777777 in place of GetActualSourceFrameAspect()
> = 1.778 with no more succeess.
>
> I have same problem using resolution 800x600 and 640x480.
>
> The only solution I find is to substract 30 from the autodetected and
calculated
> ratio :-(((( The bottom is then ok but the top is no more ok (few lines
not hidden).
>
> Michael, there is a mistery.
> --------------------------------------------------------------------------
-------------------------------
> Laurent          laurent.garnier@...
>

Re: [Deinterlace-discuss] AR autodetection

From: Laurent Garnier <laurent.garnier@cl...> - 2001-05-29 19:52

----- Message d'origine ----- 
De : Michael Samblanet <mike@...>

Hi!

> Sounds like a problem with the source rectangle - but you said the aspect
> calculated source rect was bigger than the rectangle you wanted by one line
> on the top and bottom...

New tests and logs :

- example 1 (without subtitle)

010529 210416.220(170) top 74 bot 71 bord 71 rat 2360
010529 210416.220(170) Line border TOP = 71 BOTTOM = 504

POST FILTER VALUES: CropAspectFilter
SRC : L:0000 R:0640 T:0071 B:0505 [SA: 1.4747 TA: 2.3597 Adj:1.6002]
DEST: L:0000 R:0800 T:0130 B:0469 [SA: 2.3599 TA: 2.3599 Adj:1.0000]

- example 2 (with a subtitle)

010529 210903.480(504) top 74 bot 43 bord 43 rat 2090
010529 210903.480(504) Line border TOP = 43 BOTTOM = 532

PRE FILTER VALUES: CropAspectFilter
SRC : L:0000 R:0640 T:0000 B:0576 [SA: 1.1111 TA: 1.7780 Adj:1.6002]
DEST: L:0000 R:0800 T:0000 B:0600 [SA: 1.3333 TA: 1.3333 Adj:1.0000]POST FILTER VALUES: CropAspectFilter
SRC : L:0000 R:0640 T:0043 B:0533 [SA: 1.3061 TA: 2.0901 Adj:1.6002]
DEST: L:0000 R:0800 T:0108 B:0491 [SA: 2.0888 TA: 2.0888 Adj:1.0000]


Your values for source top and bottom seem to be ok.
L:0000 R:0640 => 641 pixels from left to right and my pixel width is just 640 !
As I understand, your values for right and bottom are 1 more than effective values ?
I have to consider R-1 and B-1 ? If yes, all seems to be ok !
So, I really don't understand what happens :-((((( Michael, I hope you will have
a great idea :-)
Can it be a problem/bug with my GeForce video card ?

PS: maybe I have to save in CVS my corrected AspectDetect.cpp file so that
you could test by yourself if you have same problem as me ?
---------------------------------------------------------------------------------------------------------
Laurent          laurent.garnier@...

Re: [Deinterlace-discuss] AR autodetection

From: Michael Samblanet <mike@ca...> - 2001-05-30 02:39

No great ideas yet and life got thrown a curve today...so I am not sure when
I can look (I will either have lots of free time or no free time soon - will
know tomorrow <grin>)

Will look at when I can....

The off-by-one has only do to with the FillRect finction in Windows and so
it only applies to drawing the overlay color on the screen.  If it applies
to other functions we use, I don't know - research needed.

Anybody have a rubber chicken I can borrow?

----- Original Message -----
From: "Laurent Garnier" <laurent.garnier@...>
To: <deinterlace-discuss@...>
Sent: Tuesday, May 29, 2001 3:43 PM
Subject: Re: [Deinterlace-discuss] AR autodetection


> ----- Message d'origine -----
> De : Michael Samblanet <mike@...>
>
> Hi!
>
> > Sounds like a problem with the source rectangle - but you said the
aspect
> > calculated source rect was bigger than the rectangle you wanted by one
line
> > on the top and bottom...
>
> New tests and logs :
>
> - example 1 (without subtitle)
>
> 010529 210416.220(170) top 74 bot 71 bord 71 rat 2360
> 010529 210416.220(170) Line border TOP = 71 BOTTOM = 504
>
> POST FILTER VALUES: CropAspectFilter
> SRC : L:0000 R:0640 T:0071 B:0505 [SA: 1.4747 TA: 2.3597 Adj:1.6002]
> DEST: L:0000 R:0800 T:0130 B:0469 [SA: 2.3599 TA: 2.3599 Adj:1.0000]
>
> - example 2 (with a subtitle)
>
> 010529 210903.480(504) top 74 bot 43 bord 43 rat 2090
> 010529 210903.480(504) Line border TOP = 43 BOTTOM = 532
>
> PRE FILTER VALUES: CropAspectFilter
> SRC : L:0000 R:0640 T:0000 B:0576 [SA: 1.1111 TA: 1.7780 Adj:1.6002]
> DEST: L:0000 R:0800 T:0000 B:0600 [SA: 1.3333 TA: 1.3333 Adj:1.0000]POST
FILTER VALUES: CropAspectFilter
> SRC : L:0000 R:0640 T:0043 B:0533 [SA: 1.3061 TA: 2.0901 Adj:1.6002]
> DEST: L:0000 R:0800 T:0108 B:0491 [SA: 2.0888 TA: 2.0888 Adj:1.0000]
>
>
> Your values for source top and bottom seem to be ok.
> L:0000 R:0640 => 641 pixels from left to right and my pixel width is just
640 !
> As I understand, your values for right and bottom are 1 more than
effective values ?
> I have to consider R-1 and B-1 ? If yes, all seems to be ok !
> So, I really don't understand what happens :-((((( Michael, I hope you
will have
> a great idea :-)
> Can it be a problem/bug with my GeForce video card ?
>
> PS: maybe I have to save in CVS my corrected AspectDetect.cpp file so that
> you could test by yourself if you have same problem as me ?
> --------------------------------------------------------------------------
-------------------------------
> Laurent          laurent.garnier@...
>
>
> _______________________________________________
> Deinterlace-discuss mailing list
> Deinterlace-discuss@...
> http://lists.sourceforge.net/lists/listinfo/deinterlace-discuss
>
>