GNU Gatekeeper (GnuGk)

Email Archive: openh323gk-developer (read-only)

Re: [Openh323gk-developer] two bugs fixs(gnugk2.2beta1)

From: Chih-Wei Huang <cwhuang@li...> - 2003-07-29 10:04

huyuxin@... =CC=E1=B5=BD:
> *1. mysqlcon.cxx*
> bug: =B1=E0=D2=EB=B4=ED=CE=F3(compile error)
> fix: =B8=C4=B1=E4=CD=B7=CE=C4=BC=FE=CB=B3=D0=F2(change header file incl=
ude sequence)

committed.

> *2. gkstatus.cxx*
> {-- in english
> *bug:*
>     when i connect to status port with telnet, after i send a=20
> command(press return), the program will block at:
> int TelnetSocket::ReadChar()
>     ....
>     =3D=3D>     if (!TCPSocket::Read(&currentByte, 1)) {
>     then gnugk will not response other status client's command!
> *fix:*

Hmmm, the bug only occurs in non LARGE_FDSET mode,
so I didn't notice that :p.
The correct fix is set ReadTimeout of the socket to 0,
so Read() will not be blocked.

It is in CVS now. Please test it.
(I've verified it works on Windows)
Thanks for the report.


--=20
   ~     Chih-Wei Huang (cwhuang@...)
  'v'    CLDP Project : http://www.linux.org.tw/CLDP/ (Coordinator)
 // \\   CLE  Project : http://cle.linux.org.tw/CLE/  (Developer)
/(   )\  I18N Project : http://i18n.linux.org.tw/     (Translator)
 ^`~'^   HomePage     : http://www.cwhuang.idv.tw/

Thread View

Thread	Author	Date
[Openh323gk-developer] two bugs fixs(gnugk2.2beta1)	<huyuxin@sn...>

[Openh323gk-developer] two bugs fixs(gnugk2.2beta1)

From: <huyuxin@sn...> - 2003-07-28 10:05

Attachments: Message as HTML

d2luZG93cyAyMDAwDQp2YyA2LjAgc3A1DQpnbnVnazIuMmJldGExDQpwd2xpYiAxLjUuMA0Kb3Bl
bmgzMjMgMS4xMi4wDQoNCjEuIG15c3FsY29uLmN4eA0KYnVnOiCx4NLrtO3O8yhjb21waWxlIGVy
cm9yKQ0KZml4OiC4xLHkzbfOxLz+y7PQ8ihjaGFuZ2UgaGVhZGVyIGZpbGUgaW5jbHVkZSBzZXF1
ZW5jZSkNCg0KMi4gZ2tzdGF0dXMuY3h4DQpidWc6DQogICAg08MgdGVsbmV0ILXHwry1vde0zKy2
y7/ao6zDv9a00NDSu8z1w/zB7qOss8zQ8r7Nu+HX6Mj71NogDQppbnQgVGVsbmV0U29ja2V0OjpS
ZWFkQ2hhcigpDQogICAgLi4uLg0KICAgID09PiAgICAgaWYgKCFUQ1BTb2NrZXQ6OlJlYWQoJmN1
cnJlbnRCeXRlLCAxKSkgew0KICAgICDWu9PQtb23osvNz8LSu7j219a3+8qxssW74bzM0PjWtNDQ
o6y0y8qxIGdudWdrIM7et6jP4NOmxuTL+7/Nu6e2y7XEx+vH86OhDQpmaXg6DQogICAgztLWu8rH
vPK1pbXYvasgd2hpbGUoIWhhc0RhdGEpINGtu7fIpbX0o6zPo837uN/K1sTc09C4/LrDtcS94r72
sOy3qKGjDQp7LS0gaW4gZW5nbGlzaA0KYnVnOg0KICAgIHdoZW4gaSBjb25uZWN0IHRvIHN0YXR1
cyBwb3J0IHdpdGggdGVsbmV0LCBhZnRlciBpIHNlbmQgYSBjb21tYW5kKHByZXNzIHJldHVybiks
IHRoZSBwcm9ncmFtIHdpbGwgYmxvY2sgYXQ6DQppbnQgVGVsbmV0U29ja2V0OjpSZWFkQ2hhcigp
DQogICAgLi4uLg0KICAgID09PiAgICAgaWYgKCFUQ1BTb2NrZXQ6OlJlYWQoJmN1cnJlbnRCeXRl
LCAxKSkgew0KICAgIHRoZW4gZ251Z2sgd2lsbCBub3QgcmVzcG9uc2Ugb3RoZXIgc3RhdHVzIGNs
aWVudCdzIGNvbW1hbmQhDQpmaXg6DQogICAgaSBqdXN0IHJlbW92ZSB3aGlsZSghaGFzRGF0YSkg
bG9vcCwgbWF5YmUgc29tZW9uZSBoYXMgYmV0dGVyIHNvbHV0aW9uIQ0KLS19DQoNCg0KY3ZzIC16
MyBkaWZmIC11IEdrU3RhdHVzLmN4eCBteXNxbGNvbi5jeHggKGluIGRpcmVjdG9yeSBDOlxvcGVu
aDMyM2drKQ0KSW5kZXg6IEdrU3RhdHVzLmN4eA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNy
b290L29wZW5oMzIzZ2svb3BlbmgzMjNnay9Ha1N0YXR1cy5jeHgsdg0KcmV0cmlldmluZyByZXZp
c2lvbiAxLjMxDQpkaWZmIC11IC1yMS4zMSBHa1N0YXR1cy5jeHgNCi0tLSBHa1N0YXR1cy5jeHgg
MTkgSnVsIDIwMDMgMDY6NDE6NTggLTAwMDAgMS4zMQ0KKysrIEdrU3RhdHVzLmN4eCAyOCBKdWwg
MjAwMyAwODozMzo1NSAtMDAwMA0KQEAgLTExNiwxMyArMTE2LDEyIEBADQogIGJvb2wgaGFzRGF0
YSA9IGZhbHNlOw0KICBCWVRFIGN1cnJlbnRCeXRlOw0KIA0KLSB3aGlsZSAoIWhhc0RhdGEpIHsN
CiAgICAgICAgICBpZiAoIVRDUFNvY2tldDo6UmVhZCgmY3VycmVudEJ5dGUsIDEpKSB7DQogICAg
aWYgKEdldEVycm9yQ29kZShQU29ja2V0OjpMYXN0UmVhZEVycm9yKSAhPSBQU29ja2V0OjpUaW1l
b3V0KSB7DQogICAgIFBUUkFDRSgyLCAiVGVsbmV0XHQiIDw8IEdldE5hbWUoKSA8PCAiIGhhcyBk
aXNjb25uZWN0ZWQiKTsNCiAgICAgQ2xvc2UoKTsNCiAgICB9DQotICAgYnJlYWs7DQorICAgcmV0
dXJuIC0xOw0KICAgfQ0KICAgc3dpdGNoIChzdGF0ZSkNCiAgIHsNCkBAIC0xODQsNyArMTgzLDYg
QEANCiAgICAgc3RhdGUgPSBTdGF0ZU5vcm1hbDsNCiAgICAgYnJlYWs7DQogICB9DQotIH0NCiAN
CiAgcmV0dXJuIGhhc0RhdGEgPyBjdXJyZW50Qnl0ZSA6IC0xOw0KIH0NCkluZGV4OiBteXNxbGNv
bi5jeHgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9vcGVuaDMyM2drL29wZW5oMzIz
Z2svbXlzcWxjb24uY3h4LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4zDQpkaWZmIC11IC1yMS4z
IG15c3FsY29uLmN4eA0KLS0tIG15c3FsY29uLmN4eCAyNCBKdWwgMjAwMyAwMjowMjo0OSAtMDAw
MCAxLjMNCisrKyBteXNxbGNvbi5jeHggMjggSnVsIDIwMDMgMDg6MzM6NTUgLTAwMDANCkBAIC0x
OSwxMSArMTksMTEgQEANCiAjaWZuZGVmIF9fbXlzcWxjb25faF8NCiAjaW5jbHVkZSAibXlzcWxj
b24uaCINCiAjZW5kaWYNCi0jaW5jbHVkZSA8bXlzcWwuaD4NCiAjaWZkZWYgV0lOMzINCiAjaW5j
bHVkZSA8cHRsaWIvc29ja2V0Lmg+DQogI3ByYWdtYSBjb21tZW50KGxpYiwgImxpYm15U1FMLmxp
YiIpDQogI2VuZGlmDQorI2luY2x1ZGUgPG15c3FsLmg+DQogDQogLy8gY2xhc3MgTXlTUUxDb25u
ZWN0aW9uOjpSZXN1bHQNCiBib29sIE15U1FMQ29ubmVjdGlvbjo6UmVzdWx0OjpTdG9yZShNWVNR
TCAqY29ubmVjdGlvbiwgY29uc3QgY2hhciAqc3FsY21kKQ0KDQoqKioqKiBDVlMgZXhpdGVkIG5v
cm1hbGx5IHdpdGggY29kZSAxICoqKioqDQoNCg0KDQoNCg0KSHUgWXV4aW4=

Re: [Openh323gk-developer] two bugs fixs(gnugk2.2beta1)

From: Chih-Wei Huang <cwhuang@li...> - 2003-07-29 10:04

huyuxin@... =CC=E1=B5=BD:
> *1. mysqlcon.cxx*
> bug: =B1=E0=D2=EB=B4=ED=CE=F3(compile error)
> fix: =B8=C4=B1=E4=CD=B7=CE=C4=BC=FE=CB=B3=D0=F2(change header file incl=
ude sequence)

committed.

> *2. gkstatus.cxx*
> {-- in english
> *bug:*
>     when i connect to status port with telnet, after i send a=20
> command(press return), the program will block at:
> int TelnetSocket::ReadChar()
>     ....
>     =3D=3D>     if (!TCPSocket::Read(&currentByte, 1)) {
>     then gnugk will not response other status client's command!
> *fix:*

Hmmm, the bug only occurs in non LARGE_FDSET mode,
so I didn't notice that :p.
The correct fix is set ReadTimeout of the socket to 0,
so Read() will not be blocked.

It is in CVS now. Please test it.
(I've verified it works on Windows)
Thanks for the report.


--=20
   ~     Chih-Wei Huang (cwhuang@...)
  'v'    CLDP Project : http://www.linux.org.tw/CLDP/ (Coordinator)
 // \\   CLE  Project : http://cle.linux.org.tw/CLE/  (Developer)
/(   )\  I18N Project : http://i18n.linux.org.tw/     (Translator)
 ^`~'^   HomePage     : http://www.cwhuang.idv.tw/