Slash

** Reply to message from Jamie McCarthy <jamie@...> on Sat,  6 Mar 2004
11:48:49 -0500

Hi Jamie,

> The template_show_comments var, which is on by default.

Yes - it is on. (Set to 1)

> You have that on and not all templates are generating HTML comments?
> Which ones are missing?

I get comments from many of the templates, but not all.  For example, the
themes/slashcode/templates/imageLink;misc;default template didn't generate one
for the embedded picture.  

A comment would have helped me figure out the workaround for the null image
size on my own.

A quick check of my main web index page shows the following templates:

<!-- start template: ID 108, fancybox;misc;default -->
<!-- start template: ID 111, footer;misc;default -->
<!-- start template: ID 117, getOlderStories;misc;default -->
<!-- start template: ID 120, header;misc;default -->
<!-- start template: ID 124, index;index;default -->
<!-- start template: ID 150, pollbooth;misc;default -->
<!-- start template: ID 172, storylink;index;default -->
<!-- start template: ID 262, setrectop_img;misc;default -->
<!-- start template: ID 68, admin;menu;default -->
<!-- start template: ID 71, currentAdminUsers;misc;default -->
<!-- start template: ID 91, dispStory;misc;default -->

I expect that there are a lot more templates involved than just these.  

Other than the imageLink template, I'm not sure which ones are missing.  The
page definitely includes the mainmenu, so no comment for 
mainmenu;misc;default.   It is nested inside a fancybox, which does generate a
comment.   And my mainmenu has an explicit include for
sections_updated;misc;default, [% INCLUDE sections_updated;misc;default %].  So
no comment for that one either.

Is there some limit to the nesting depth for comments?

george

On Mar 6, 2004, at 6:19 AM, George Clark wrote:

> ** Reply to message from Jamie McCarthy <jamie@...> on Sat,  6 
> Mar 2004
> 11:48:49 -0500
>
> Hi Jamie,
>
>> The template_show_comments var, which is on by default.
>
> Yes - it is on. (Set to 1)
>
>> You have that on and not all templates are generating HTML comments?
>> Which ones are missing?
>
> I get comments from many of the templates, but not all.  For example, 
> the
> themes/slashcode/templates/imageLink;misc;default template didn't 
> generate one
> for the embedded picture.
>
> A comment would have helped me figure out the workaround for the null 
> image
> size on my own.
>

It's because of the way they are called:

coolio:/usr/local/src/slash/slash/Slash shane$ grep "imageLink" * -r
Utility/Display/Display.pm:     my $content = slashDisplay('imageLink', 
{
coolio:/usr/local/src/slash/slash/Slash shane$ less 
Utility/Display/Display.pm

in there:

         my $content = slashDisplay('imageLink', {
                 id      => $token->[1]{id},
                 title   => $token->[1]{title},
                 align   => $token->[1]{align},
                 width   => $token->[1]{width},
                 height  => $token->[1]{height},
         }, {
                 Return => 1,
                 Nocomm => 1,
         });

There's your reason. slashDisplay's being called and specifically told 
not to return comments.

  Shane

--
One gadget to catch them all, and in digital darkness bind them.

** Reply to message from Shane <shane@...> on Sat, 6 Mar 2004 22:03:50
-0500

Hi Shane

> Nocomm => 1,
>          });
> 
> There's your reason. slashDisplay's being called and specifically told 
> not to return comments.

Ahhh, Thanks... and looking for other Nocomm => 1 instances, they are hardcoded
all over the place.  54 instances in the R113 source.

Also explains why my mainmenu doesn't display comments.  Sure would make it
easier to debug templates and page layout if all of these would honor the
configuration variable.

Thanks,
George