Patches item #1762564, was opened at 2007-07-28 03:53
Message generated for change (Comment added) made by cgroves
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1762564&group_id=12867
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Mehendran (mehendran)
Assigned to: Nobody/Anonymous (nobody)
Summary: patch for [ 1758323 ] list.sort(None) raises TypeError
Initial Comment:
patch for the bug [ 1758323 ]
plz, find the patch attached.
----------------------------------------------------------------------
>Comment By: Charles Groves (cgroves)
Date: 2007-07-29 23:24
Message:
Logged In: YES
user_id=1174327
Originator: NO
Applied with some minor changes in r3367.
PyNone is a singleton, so rather than checking instanceof PyNone to look
for this, you can just use this.compare == Py.None. instanceof is more
expensive than you'd think in Java, so it should be avoided where possible.
Also, I moved the check for None up into the constructor, and don't set
compare if it's None. This saves making that check for every comparison.
Finally, for these types of bugs where I mention that a test is checking
for it in the description, that means I've either disabled or commented out
that portion of the test. It'd be good if you could find that portion of
the test, reenable or uncomment it, and include that in your patch after
assuring that it now passes. You should be able to search for the bug id
number in the source to find any changes I've made for it.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1762564&group_id=12867
|