>>> <klaus.berndl@...> seems to think that:
>Hi,
>
>> Your changes make good sense Klaus.
>
>> Of interest to me was that you made tag names safe against
>>white-space changes. Should this be a generic features of a parser to
>>do white-space reduction for those modes that could be affectedby
>>them?
>
>Concerning tag-names i did this mostly to bring all test-output
>in exactly one line so diff can do better work...=20
>I wondered for myself seeing tag-names containing newlines and spaces
>but appearantly the python parser (semantic/test/test.py) produces
>such ones.... i do not think that the parser itself should normalize
>tag-names with respect to white-space but for generating easy comparable
>test-output i thought i can do it.....
Trimming white-space would be useful for all semantic-format functions
which are specifically for making code pretty.
>>> <klaus.berndl@...> seems to think that:
>> I think a good starting point is the definition of the several elisp-
>> parsers in semantic-el.el - we should at least have one code-exemplar
>> for each of them.
>
>> I had already started with a test.el but not yet finished - i will =
>send it
>> to you today evening, Eric, then you can maybe save some time ;-)
>
>here is my test.el i mentioned - as already said, just a start...
[ ... ]
Thanks!
>>> <klaus.berndl@...> seems to think that:
>Hi,
>
>Eric M. Ludlam wrote:
>> Hi,
>>
>> Your changes make good sense Klaus.
>
> i have now checked in a new version of semantic-regtest.el - patch
>has been sent to this list before...
Thanks
>This new version contains a new function semantic-regtest-excessive-trim
>which is needed by this lib but IMO it is a utility-function which should
>be placed somewhere else in the cedet-suite - what is a good place for such
>general utilities like trimming functions??
[ ... ]
Very generic utilities of large size I like in cedet/common.
Single functions have landed in semantic-fw.el.
This one would be most useful as a part of semantic-format, since that
is where I think it would be most used.
I might name it `semantic-format-cleanup-whitespace', and then change
it to eliminate "^\\s-+" and "\\s-+$" completely, then shorten
whitespace collections afterwards, just to be complete.
`semantic-format-tag-name' would then use the new fcn.
Thanks for your efforts!
Eric
--
Eric Ludlam: zappo@..., eric@...
Home: http://www.ludlam.net Siege: http://www.siege-engine.com
Emacs: http://cedet.sourceforge.net GNU: http://www.gnu.org
|