Steel Bank Common Lisp

Stéphane Conversy <conversy@...> writes:

> Hi,
>
> I tried to use garnet with sbcl.
> I installed sbcl using darwinports on my mac, then I installed clx with asdf.
> I then run this script:
>
> (require 'asdf)
> (require 'clx)
> (load "garnet-prepare-compile")
> (load "garnet-loader")
> (load "garnet-compiler")
>
> but sbcl fails to compile:
>
> The value (T &OPTIONAL T) is not of type SYMBOL.
>
> in kr.lisp: 212
>
> (defun g-value-inherit-values (schema slot is-leaf slot-structure)
>  (declare (function formula-fn (t &optional t) t))
>  (let (has-parents)
>   (if (a-local-only-slot slot)    ; These CANNOT be inherited.        
>                                           
>                  
>    (return-from g-value-inherit-values NIL))
>
> I'm not fluent in lisp, any tips ?

You can try to replace:

   (declare (function formula-fn (t &optional t) t))

with:

   (declare (ftype (function (t &optional t) t)  formula-fn))


-- 
__Pascal Bourguignon__                     http://www.informatimago.com/

NOTE: The most fundamental particles in this product are held
together by a "gluing" force about which little is currently known
and whose adhesive power can therefore not be permanently
guaranteed.

Thanks, compiling works now.
However, when I launch a demo (say demo/demo-scrollbar), I get this:

  The value (LAMBDA () (- (GV '#k<AGGREGATE-556> :TOP) (GVL :HEIGHT)))
   is not of type
     (OR FUNCTION SYMBOL)

it comes from demo/demo-scrollbar.lisp:

  (setf trill-box-incr (MAC-make-incr-box viewport 'trill-box-incr1 =20
indicator
                            (formula `(gv ',scroll-bar-name :left))
                            (formula `(- (gv ',scroll-bar-=20
name :top) ; <-- here
                                             (gvl :height)))
                            (formula `(gv ',scroll-bar-name :width))
                            20))

For those who would be grateful enough to help me, I put a tbz file =20
here with the modifs I made to make it compile:

http://perso.tls.cena.fr/conversy/tmp/garnet.tbz (2,7M)

look at garnet/diff.patch (joined to this mail) to see what path to =20
set (only 3 variables)
and in garnet/src just do:
sbcl --load docompile.lisp
then
sbcl --load dotest.lisp

thanks,

stephane

=EF=BF=BC

Le 24 mai 07 =C3=A0 02:05, Pascal Bourguignon a =C3=A9crit :

> St=C3=A9phane Conversy <conversy@...> writes:
>
>> Hi,
>>
>> I tried to use garnet with sbcl.
>> I installed sbcl using darwinports on my mac, then I installed clx =20=

>> with asdf.
>> I then run this script:
>>
>> (require 'asdf)
>> (require 'clx)
>> (load "garnet-prepare-compile")
>> (load "garnet-loader")
>> (load "garnet-compiler")
>>
>> but sbcl fails to compile:
>>
>> The value (T &OPTIONAL T) is not of type SYMBOL.
>>
>> in kr.lisp: 212
>>
>> (defun g-value-inherit-values (schema slot is-leaf slot-structure)
>>  (declare (function formula-fn (t &optional t) t))
>>  (let (has-parents)
>>   (if (a-local-only-slot slot)    ; These CANNOT be inherited.
>>
>>
>>    (return-from g-value-inherit-values NIL))
>>
>> I'm not fluent in lisp, any tips ?
>
> You can try to replace:
>
>    (declare (function formula-fn (t &optional t) t))
>
> with:
>
>    (declare (ftype (function (t &optional t) t)  formula-fn))
>
>
> --=20
> __Pascal Bourguignon__                     http://=20
> http://www.informatimago.com/
>
> NOTE: The most fundamental particles in this product are held
> together by a "gluing" force about which little is currently known
> and whose adhesive power can therefore not be permanently
> guaranteed.

--
St=C3=A9phane Conversy
Ecole Nationale de l'Aviation Civile, Toulouse, France
http://www.tls.cena.fr/~conversy
enac: +33 5 62 17 40 19
dgac r&d: +33 5 62 25 96 48

Stéphane Conversy <conversy@...> writes:

> Thanks, compiling works now.
> However, when I launch a demo (say demo/demo-scrollbar), I get this:
>
> The value (LAMBDA () (- (GV '#k<AGGREGATE-556> :TOP) (GVL :HEIGHT)))
>  is not of type
>   (OR FUNCTION SYMBOL)
>
> it comes from demo/demo-scrollbar.lisp:
>
> (setf trill-box-incr (MAC-make-incr-box viewport 'trill-box-incr1 indicator
>              (formula `(gv ',scroll-bar-name :left))
>              (formula `(- (gv ',scroll-bar-name :top) ; <-- here
>                       (gvl :height)))
>              (formula `(gv ',scroll-bar-name :width))
>              20))


The bug is in formula-fn in src/kr/constraints.lisp:

	(setf (a-formula-function formula)
	      ;; This version does not work with CL version 2.  It is,
	      ;; however, much more efficient than calling the compiler.
	      #-(or CMU APPLE) `(lambda () ,form)
	      ;; This version works with CL version 2.
	      #+(or CMU APPLE) (compile nil `(lambda () ,form)))

In Common Lisp the ANSI standard, functions cannot be lambda
expressions.  Replace the above form with:

	(setf (a-formula-function formula) (compile nil `(lambda () ,form)))


It seems you fetched an older version of KR.  


-- 
__Pascal Bourguignon__                     http://www.informatimago.com/

NOTE: The most fundamental particles in this product are held
together by a "gluing" force about which little is currently known
and whose adhesive power can therefore not be permanently
guaranteed.