Bugs item #864791, was opened at 2003-12-23 02:22
Message generated for change (Comment added) made by bryce
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=604306&aid=864791&group_id=93438
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 9
Submitted By: bulia byak (buliabyak)
>Assigned to: Bryce Harrington (bryce)
Summary: XML editor: crash when canceling quit
Initial Comment:
1 create a new doc
2 draw something
3 ctrl-shift-x
4 ctrl-q
5 click "cancel"
crashes with:
** ERROR **: file sp-namedview.cpp: line 176 (void
sp_namedview_release(SPObject*)): assertion failed:
(!namedview->views)
aborting...
Aborted
----------------------------------------------------------------------
>Comment By: Bryce Harrington (bryce)
Date: 2004-02-09 03:37
Message:
Logged In: YES
user_id=4782
An assert is getting hit when the XML editor is open and the user
cancels an application quit. But this assert doesn't seem to
provide any value, since this routine doesn't refer to views at all.
So this should be reviewed in more depth to see if commenting
out the assert introduces any new undesired behavior. I've
added a TODO in the code for this purpose.
----------------------------------------------------------------------
Comment By: Peter J. R. Moulder (pjrm)
Date: 2004-01-05 10:09
Message:
Logged In: YES
user_id=827826
quick comments now:
pb seems to be with xml-tree.cpp's shutdown handler getting
run even after sp_dtw_desktop_shutdown has returned true.
[One result of xml-tree.cpp's shutdown handler getting run
is that the result of sp_shutdown_view gets overwritten to
xml-tree.cpp:on_desktop_shutdown's return value of false, so
the closing happens despite pressing cancel. However,
setting result back to true isn't enough of a fix because we
don't want on_desktop_shutdown to run, i.e. we don't want
the xml dialog to be closed.]
A suggested fix would be to have sp_dtw_desktop_shutdown
called before emitting the signal at all, and make the
signal emitting conditional on sp_dtw_desktop_shutdown's
return value.
However, I haven't yet verified that this will work, e.g. i
haven't verified that sp_dtw_desktop_shutdown can be called
unconditionally. (Time for me to leave for the night.)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=604306&aid=864791&group_id=93438
|
