On Wed 15 Mar 2000 07:15:46 -0500,
Rik Faith <faith@...> wrote:
> On Wed 15 Mar 2000 08:17:06 +0100,
> Dieter Nützel <dieter.nuetzel@...> wrote:
> > Hello Rik,
> > you have a little show stopper in your patch. Did you oversee my
> > commented line in "drmP.h"?
> > Linus put your patch in 2.3.99-pre1 (!!!)
> Could you explain why this is a "show stopper" (e.g., if it's a compilation
> problem, could you send some gcc output)? The patch compiles and runs fine
> with this #include on my system using gcc 22.214.171.124. Which compiler are you
> using? This information will help me to understand the problem before I
> fix it.
OK, I can see the problem with egcs 2.91.66. I've confirmed that removing
this line doesn't hurt gcc 126.96.36.199, so I've sent the patch onto Linus.
Since this was needed, we may have to revisit this problem when patching
back to the X tree (so that it works with 2.2.x and 2.3.x and 2.4.x).
Thanks again, Rik.
> Thanks much, Rik.
> > Here is the fix for it (one liner):
> > --- linux-2.3.99-pre1/drivers/char/drm/drmP.h.orig Wed Mar 15
> > 06:22:11 2000
> > +++ linux-2.3.99-pre1/drivers/char/drm/drmP.h Wed Mar 15 06:29:24 2000
> > @@ -50,7 +50,6 @@
> > #include <asm/mtrr.h>
> > #endif
> > #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,1,0)
> > -#include <asm/spinlock.h>
> > #include <linux/poll.h>
> > #endif
> > #include "drm.h"