What about the following case
This is a correct URL and should open the file on
So for the file:/// replacing it with smb:// is not correct.
On Sunday 13 July 2003 10:25 pm, Kevin DeKorte wrote:
> I have got this patch, and it looks ok, but I need to test and intgrate it
> into the code.
> I'll probably be doing that in the next couple of days.
> On Sunday 13 July 2003 7:14 pm, Ivan Kalvachev wrote:
> > Hello
> > I forward this dirrectly to you as i don't get any response though
> > mplayerplug-in maillist
> > (i have only one letter there...)
> > So,
> > I have access to a local site, full of movies trailers.
> > its URL are in form:
> > "file://188.8.131.52/server1/trailers/Matrix/matrix_trailer.avi"
> > This is IE hack that redirects to a windows share (samba).
> > I need to change the "file://" to "smb://" as this is the way
> > mplayer can open not mounted filesystems (main/libmpdemux/open.c::495)
> > I took a look of the file mplayerplug-in.c and i sow that you handle
> > "file://"
> > simply by removing it.
> > I think that you should handle 2 cases "file:///" and "file://".
> > First one replace with "/" second one with
> > "smb://" It may be good this to be done if mplayer have smb support. I
> > don't have idea how to detect that.
> > BTW are you sure that you don't have a small
> > memory leak at this procedure? I see that strdup is used, but the new
> > pointer overwrites the old one without free the old one first. I am not
> > familiar with mozilla, but i know that strdup uses malloc so the memory
> > should be free-ed
> > On another side i very dislike the buffer implementation. This is the
> > usuall cause of buffer overflows. First to do is to remove if from the
> > steck, where it is allocated then NPP_SetWindow function is called.
> > Maybe you should read the qmail's author recomendation and to use him
> > string libary. Remember no matter how big you make the arrays people
> > will try to overflow them:( i had link somewhere)
> > I attach patch that i wrote as example what i need. I haven't test it. I
> > donno if it compiles.
> > Best Regards
> > Ivan Kalvachev
> > iive
> > P.S.
> This SF.Net email sponsored by: Parasoft
> Error proof Web apps, automate testing & more.
> Download & eval WebKing and get a free book.
> Mplayerplug-in-devel mailing list