At Wed, 31 Oct 2007 11:48:53 -0700 (PDT),
Murray S. Kucherawy wrote:
> On Wed, 31 Oct 2007, Hirohisa Yamaguchi wrote:
> > 3. dkim-filter does not build with _FFR_SELECTOR_HEADER
> Fixed, but the warning at the end about data comparisons are interesting.
> I'll try to get onto my amd64 box here and try it.
Those warnings still shown with Beta12.
dkim-filter.c: In function 'main':
dkim-filter.c:4489: warning: large integer implicitly truncated to unsigned type
dkim-filter.c:4496: warning: comparison is always false due to limited range of data type
$ grep -n '\<tmo\>' dkim-filter/dkim-filter.c
331:unsigned int tmo; /* DNS timeout */
4295: tmo = DEFTIMEOUT;
4489: tmo = ULONG_MAX;
4493: tmo = strtoul(optarg, &p, 10);
4496: if (tmo == ULONG_MAX || errno != 0 || *p != '\0')
4789: if (tmo == DEFTIMEOUT)
4790: (void) config_get(cfg, "DNSTimeout", &tmo, sizeof tmo);
6069: &tmo, sizeof tmo);
Using ULONG_MAX against (unsigned int) seems to be inappropriate.